mirror of
https://github.com/Zagrios/bs-manager.git
synced 2026-07-03 14:08:25 +02:00
[chore] remove some code smells
This commit is contained in:
@@ -19,8 +19,6 @@ ipcMain.on("download-update", async (event, request: IpcRequest<void>) => {
|
||||
|
||||
ipc.on("check-update", (_, reply) => {
|
||||
const updaterService = AutoUpdaterService.getInstance();
|
||||
const utilsService = UtilsService.getInstance();
|
||||
|
||||
reply(from(updaterService.isUpdateAvailable()));
|
||||
});
|
||||
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
import path from "path";
|
||||
import log from "electron-log";
|
||||
import { app } from "electron";
|
||||
import ElectronStore from "electron-store";
|
||||
import { copyDirectoryWithJunctions, deleteFolder, ensureFolderExist } from "../helpers/fs.helpers";
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import { BSVersion } from "shared/bs-version.interface";
|
||||
import { useEffect, useState, memo } from "react";
|
||||
import { useState, memo } from "react";
|
||||
import { BsDownloaderService } from "renderer/services/bs-downloader.service";
|
||||
import { distinctUntilChanged, map } from "rxjs/operators";
|
||||
import defaultImage from "../../../../assets/images/default-version-img.jpg";
|
||||
|
||||
@@ -49,7 +49,7 @@ export default function OneClickDownloadMap() {
|
||||
progressBar.complete();
|
||||
|
||||
if (!res) {
|
||||
throw "Failed to download map with OneClick";
|
||||
throw new Error("Failed to download map with OneClick");
|
||||
}
|
||||
|
||||
await timer(300).toPromise();
|
||||
|
||||
@@ -40,7 +40,7 @@ export default function OneClickDownloadModel() {
|
||||
const model = await modelSaber.getModelById(infos.data.id);
|
||||
|
||||
if (!model) {
|
||||
throw "Failed to get model from ModelSaber";
|
||||
throw new Error("Failed to get model from ModelSaber");
|
||||
}
|
||||
|
||||
setModel(() => model);
|
||||
@@ -50,7 +50,7 @@ export default function OneClickDownloadModel() {
|
||||
const res = await modelDownloader.oneClickInstallModel(model);
|
||||
|
||||
if (!res) {
|
||||
throw "Failed to download model";
|
||||
throw new Error("Failed to download model");
|
||||
}
|
||||
})();
|
||||
|
||||
@@ -65,7 +65,7 @@ export default function OneClickDownloadModel() {
|
||||
promise.finally(() => {
|
||||
windows.close("oneclick-download-model.html")
|
||||
});
|
||||
|
||||
|
||||
}, []);
|
||||
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user