From 6bf26edae5a20c3b0e2b6c9158b819b65690ead0 Mon Sep 17 00:00:00 2001
From: MathieuG-P <40181755+Zagrios@users.noreply.github.com>
Date: Sun, 16 Jul 2023 17:40:19 +0200
Subject: [PATCH] [chore] remove some code smells

---
 src/main/ipcs/launcher-ipcs.ts                              | 2 --
 src/main/services/installation-location.service.ts          | 1 -
 .../available-versions/available-version-item.component.tsx | 2 +-
 src/renderer/windows/OneClick/OneClickDownloadMap.tsx       | 2 +-
 src/renderer/windows/OneClick/OneClickDownloadModel.tsx     | 6 +++---
 5 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/src/main/ipcs/launcher-ipcs.ts b/src/main/ipcs/launcher-ipcs.ts
index 502a0095..20473765 100644
--- a/src/main/ipcs/launcher-ipcs.ts
+++ b/src/main/ipcs/launcher-ipcs.ts
@@ -19,8 +19,6 @@ ipcMain.on("download-update", async (event, request: IpcRequest<void>) => {
 
 ipc.on("check-update", (_, reply) => {
     const updaterService = AutoUpdaterService.getInstance();
-    const utilsService = UtilsService.getInstance();
-
     reply(from(updaterService.isUpdateAvailable()));
 });
 
diff --git a/src/main/services/installation-location.service.ts b/src/main/services/installation-location.service.ts
index e8ae6eab..678973ed 100644
--- a/src/main/services/installation-location.service.ts
+++ b/src/main/services/installation-location.service.ts
@@ -1,5 +1,4 @@
 import path from "path";
-import log from "electron-log";
 import { app } from "electron";
 import ElectronStore from "electron-store";
 import { copyDirectoryWithJunctions, deleteFolder, ensureFolderExist } from "../helpers/fs.helpers";
diff --git a/src/renderer/components/available-versions/available-version-item.component.tsx b/src/renderer/components/available-versions/available-version-item.component.tsx
index c77fdfe0..fbb90a32 100644
--- a/src/renderer/components/available-versions/available-version-item.component.tsx
+++ b/src/renderer/components/available-versions/available-version-item.component.tsx
@@ -1,5 +1,5 @@
 import { BSVersion } from "shared/bs-version.interface";
-import { useEffect, useState, memo } from "react";
+import { useState, memo } from "react";
 import { BsDownloaderService } from "renderer/services/bs-downloader.service";
 import { distinctUntilChanged, map } from "rxjs/operators";
 import defaultImage from "../../../../assets/images/default-version-img.jpg";
diff --git a/src/renderer/windows/OneClick/OneClickDownloadMap.tsx b/src/renderer/windows/OneClick/OneClickDownloadMap.tsx
index df5d7ab4..fe8833d4 100644
--- a/src/renderer/windows/OneClick/OneClickDownloadMap.tsx
+++ b/src/renderer/windows/OneClick/OneClickDownloadMap.tsx
@@ -49,7 +49,7 @@ export default function OneClickDownloadMap() {
             progressBar.complete();
 
             if (!res) {
-                throw "Failed to download map with OneClick";
+                throw new Error("Failed to download map with OneClick");
             }
 
             await timer(300).toPromise();
diff --git a/src/renderer/windows/OneClick/OneClickDownloadModel.tsx b/src/renderer/windows/OneClick/OneClickDownloadModel.tsx
index d807b497..a0ec0925 100644
--- a/src/renderer/windows/OneClick/OneClickDownloadModel.tsx
+++ b/src/renderer/windows/OneClick/OneClickDownloadModel.tsx
@@ -40,7 +40,7 @@ export default function OneClickDownloadModel() {
             const model = await modelSaber.getModelById(infos.data.id);
 
             if (!model) {
-                throw "Failed to get model from ModelSaber";
+                throw new Error("Failed to get model from ModelSaber");
             }
 
             setModel(() => model);
@@ -50,7 +50,7 @@ export default function OneClickDownloadModel() {
             const res = await modelDownloader.oneClickInstallModel(model);
 
             if (!res) {
-                throw "Failed to download model";
+                throw new Error("Failed to download model");
             }
         })();
 
@@ -65,7 +65,7 @@ export default function OneClickDownloadModel() {
         promise.finally(() => {
             windows.close("oneclick-download-model.html")
         });
-        
+
     }, []);
 
     return (