- Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS)
was not writable for android10 (older and newer androids are okay)
- the import selectMediaType() showed up,
however never did show the exported file on android10 (also here, older and newer androids are okay)
re-adding the flag `android:requestLegacyExternalStorage="true"` that was removed in #2087
fixed both problems, at least in the emulator.
seems as if the flag is still respected when running on sdk29 even when targeting sdk30;
when running on sdk30, however, the flag is ignored.
at least the following doc does not say that the flag is needless in sdk30:
https://developer.android.com/reference/android/R.attr#requestLegacyExternalStorage
without, there is a warning in gradle7 that says:
"DSL element 'dexOptions' is obsolete and should be removed.
It will be removed in version 8.0 of the Android Gradle plugin.
Using it has no effect, and the AndroidGradle plugin optimizes dexing automatically."
not sure, what the option was about in older gradles.
* allow to copy QR data and to read QR data from clipboard
* add share option
* allow to scan QR from gallery
* use menu_copy_to_clipboard instead of menu_copy_link_to_clipboard
* use AttachmentManager
* reuse Bitmap
* change REQUEST_CODE_IMAGE value
* use getCacheDir()
* replace handleOpenPgp4Fpr with handleQrData
* show error message if scanning QR failed
* use Log.e() instead of Log.w()
* Revert "use getCacheDir()"
This reverts commit 2a2a801b311e7c4929f5063d3340234413528b93.
the impact of this change is eaasily larger than expected,
see comments at https://github.com/deltachat/deltachat-android/pull/2103
if needed, we can discuss and re-add that in a separate, more focused pr.
Co-authored-by: B. Petersen <r10s@b44t.com>
* Target SDK 30
* Pull changes from Signal
* Bugfix, make photo view rail be shown again
* Fix capturing images using an external camera
* Make backups work. Unfortunately, I did this by copying the backup file to the private storage first.
* Fix: Show the correct folder name when exporting attachment
Before, after exporting an attachment, on newer Android versions (and
maybe also on older ones) the toast always said
`File exported to "media"`.
* Update src/org/thoughtcrime/securesms/WelcomeActivity.java
Co-authored-by: Asiel Díaz Benítez <adbenitez@nauta.cu>
Co-authored-by: bjoern <r10s@b44t.com>
Co-authored-by: Asiel Díaz Benítez <adbenitez@nauta.cu>
* add 'New Group or Subject' to contact profiles and allow group creation from there
* preselect contacts on group-creation from profile
* remove dead code
* also for existing group-creation, do not finish calling activity needlessly (this is pretty unexpected behavior)
* on editing groups, just use isProtected() from the chat to edit
* adapt 'profile' hint to reality
- the profile hint misses that also the signature
is sent out, together with name and image
- strike the part about that sent information cannot be retracted -
that is pretty clear,
and if we say that here, why not beside every message ;)
not sure where that comes from,
i checked similar settings in other messengers,
there is no comparable hint.
* remove unclear 'alongside' wording
* make new 'join group' strings translatable
* remove now superfluous group-join-progress-dialog
* remove thread-back-to-main roundtrip, joinSecurejoin() should return fast enough, not much different from any other chat creation
it was removed to have some less menu entries,
however, on recent discussions,
it turns out clearer and clearte that this will break some workflows
(writing text first, then adding attachment).
i just had a look at other "large" messengers -
all of them support "write text, then add attachment" -
as well as our iOS and Desktop apps.
also, this order seems to be pretty normal when it comes to "E-Mail".
all in all,
i think, we should not sacrify this workflow just to save one menu entry.
at some point,
maybe we want to have the "Attach" button always visible left of the input bar
as most other messengers do (as well as iOS and Desktop),
however, this is a larger thing and also has its drawbacks on smaller screens.
so, just leave things as is seems not to be the worse idea here.
the "View Profile" menu entry, however stays, removed,
so, there is some cleanup.
adbenitez