zedcode/bs-manager
1
0
Fork 0
mirror of https://github.com/Zagrios/bs-manager.git synced 2026-07-03 14:08:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

[feature-75] fix some sonarcloud issues + other potentials issues + add logs

Browse Source
This commit is contained in:
MathieuG-P
2024-10-17 13:31:41 +02:00
parent b10900618a
commit 00d6d7de30
2 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/services/additional-content/maps/local-maps-manager.service.ts
+14 -7
View File
@@ -334,25 +334,30 @@ export class LocalMapsManagerService {
(async () => {
const mapsPath = await this.getMapsFolderPath(version);
root: for(const zipPath of zipPaths) {
if(unsubscribed) { break; }
for(const zipPath of zipPaths) {
if(unsubscribed) {
log.info("Maps importation from zip has been cancelled");
return;
}
progress = { total: 0, current: 0 };
obs.next(progress); // reset progress for each zip
if(!pathExistsSync(zipPath)) { continue; }
const zip = new StreamZip.async({ file: zipPath });
const { result: zipEntries, error } = await tryit(() => zip.entries());
const zipEntriesValues = Object.values(zipEntries);
if(error) {
log.error("Could not read zip entries", zipPath, error);
zip.close();
await zip.close();
continue;
}
const mapsFolders = zipEntriesValues.reduce((acc, entry) => {
if(!/(^|\/)(I|i)nfo.dat$/.test(entry.name)){ return acc; }
if(!/(^|\/)[I-i]nfo\.dat$/.test(entry.name)){ return acc; }
acc.push(path.dirname(entry.name));
return acc;
}, []);
@@ -365,9 +370,11 @@ export class LocalMapsManagerService {
obs.next(progress);
for(const folder of mapsFolders) {
if(unsubscribed) {
zip.close();
break root;
log.info("Maps importation from zip has been cancelled");
await zip.close();
return;
}
const isRoot = folder === ".";
@@ -406,7 +413,7 @@ export class LocalMapsManagerService {
obs.next(progress);
}
zip.close();
await zip.close();
}
})()
.then(() => {
src/renderer/components/maps-playlists-panel/maps-playlists-panel.component.tsx
+4 -5
View File
@@ -107,13 +107,12 @@ export function MapsPlaylistsPanel({ version, isActive }: Props) {
const handleFileDrop = async (files: FileList) => {
const zipMimeTypes = ["application/zip", "application/zip-compressed", "application/x-zip-compressed"];
const paths: string[] = [];
for (let i = 0; i < files.length; ++i) {
const file = files[i];
const paths: string[] = Array.from(files).reduce((acc, file) => {
if (zipMimeTypes.includes(file.type)) {
paths.push(window.electron.webUtils.getPathForFile(file));
acc.push(window.electron.webUtils.getPathForFile(file));
}
}
return acc;
}, []);
if (paths.length === 0) {
notifications.notifyError({