The intent of this `if` is to allow the user to select a suggested query
from bang history, but it previously always overwrote |user_text_| even
if it was longer (which is not possible if the user is selecting a
suggestion, as it will always be longer than currently-typed text).
Because |fill_into_edit| is trimmed, it also removed the trailing space
that is desired if the user was inputting a completely new query.
Make it so that |user_text_| is only replaced if it will result in an
expansion.
Fixes#726
i can't remember what this was added for, and bangs seem to be working
fine even without it. so let's just yank it out since it seems to be
causing problems.
Fixes#146Fixes#784
Chromium's canvas noising was mostly removed in 3 parts, which
landed in 144:
1. https://crrev.com/1537919
2. https://crrev.com/1538396
3. https://crrev.com/1538814
Prior to 144, Helium relied on Chromium's implementation of Canvas
noising for fingerprinting protection, as it was the best option at
the time. Now that it's no longer available, we had to either revert
the removal, or come up with our own implementation.
Helium Noise is something in-between: it builds on top of Chromium's
implementation, but removes extras and extends it further.
Key highlights of this implementation:
- Completely independent, doesn't rely on any remaining bits of
Chromium's deprecated implementation.
- Noise isn't locked to just Canvas, it's built with extensibility
in mind, so we can implement fingerprint deception for more browser
APIs in the future.
- Noise generates unique BrowserContext tokens per feature
(kCanvas, kAudio, etc) to prevent (highly unlikely) correlation. Aka
the way it should be implemented.
- Canvas is noised only during readback, just like in Chromium's
implementation.
- Canvas noising works without hardware acceleration unlike Chromium's
implementation.
I've also updated AudioContext fingerprint deception to use Helium Noise,
just like Canvas. This should fix#249, because AudioContext fingerprint
is now consistent within an origin and BrowserContext. More testing is
needed, as I'm unable to replicate the original issue on previous builds.
- `inox-patchset/disable-missing-key-warning.patch`: same behavior as
`debian/disable-google-api-warning.patch`, but one level lower. makes no
sense to keep both.
- `ungoogled-chromium/remove-disable-setuid-sandbox-as-bad-flag.patch`:
irrelevant to helium, and also it is a bad flag
- `ungoogled-chromium/enable-page-saving-on-more-pages.patch`: outdated
or initially useless
- `ungoogled-chromium/disable-download-quarantine.patch`: i understand
why ungoogled has this patch, but helium should allow the OS to
vet/quarantine downloaded files. this is not related to safe browsing.
- `ungoogled-chromium/fix-distilled-icons.patch`: weird workaround +
helium doesn't ship a reading mode, the only place where this could've
been potentially used
- `ungoogled-chromium/add-flag-for-tabsearch-button.patch`: helium hides
the tab search button by default, with an option to enable it in the
toolbar
- `ungoogled-chromium/add-flag-for-qr-generator.patch`: outdated and
irrelevant, the qr code generation entrypoint hasn't been in the address
bar for many years
- `ungoogled-chromium/add-flag-to-disable-sharing-hub.patch`: same as qr
code generator, the sharing hub entry point hasn't been in the address
bar for many years
- `ungoogled-chromium/enable-extra-locales.patch`: irrelevant to helium.
basically extra bloat, considering regular chrome doesn't ship these
- shrunk the toolbar padding
- shrunk the side panel with thumbnails
- fixed different font sizes in the toolbar
- made file title a bit smaller, reduced its margin
- remade the stroke of the selected thumbnail
as a result, a lot more content fits on the screen at once!
wukko