aff01f4ba1
address @dignifiedquire comments
2019-09-23 15:32:33 +02:00
cf8ca16de2
avoid cdata_to_free trick and some more cleanups
2019-09-23 14:15:29 +02:00
09d4693cb7
introduce safety and a particular EncryptHelper
2019-09-23 12:48:29 +02:00
6aee35cc96
another rustification of encrypt()
2019-09-23 02:30:03 +02:00
c059564849
create wrapmime module and simplify some mailmime code
2019-09-23 02:05:47 +02:00
321c5e049b
re-add some comments from core-c
2019-09-22 23:39:16 +02:00
ed7cf218f8
address three comments from @dignifiedquire
2019-09-22 23:39:16 +02:00
74d8368525
rustify references, in_reply_to, mimefactory's recipients_{addr,names}
2019-09-22 23:39:16 +02:00
dcbfa272f9
rustify parts of MimeFactory struct
2019-09-22 23:39:16 +02:00
42dd600e0c
more rustifications
2019-09-22 23:39:16 +02:00
9689df601f
streamline mimetype guessing and build_body_file
2019-09-22 23:39:16 +02:00
f6019583b7
better looping on some clists
2019-09-22 23:39:16 +02:00
2d50a3335d
- add mailimf_field_add helper to reduce number of strdup()s
...
- make build_body_text avoid char*
2019-09-22 23:39:16 +02:00
202bfa987d
dc_mimefactory+friends: simplify used strings, convert message_text and message_text2 to String, convert ints to bools
2019-09-22 23:39:16 +02:00
93f9c7cfbd
e2ee_guaranteed -> bool, rustify set_error
2019-09-22 23:39:16 +02:00
8f6a0bbf09
Remove unused argument of DC_JOB_CONFIGURE_IMAP
2019-09-22 22:22:00 +02:00
1a47c148e5
Merge pull request #574 from KAction/test-dc_remove_cr
...
Add test for `dc_remove_cr_chars`
2019-09-22 19:47:22 +02:00
2435ba1ea0
Merge pull request #576 from KAction/quote_word
...
Remove useless argument to `quote_word`
2019-09-22 19:46:48 +02:00
9ba57a923b
Remove useless argument to quote_word
...
Function "quote_word" accepts display charset argument, but on only call
site it is string constant. Change function to always use "utf-8"
display charset, and remove useless argument.
2019-09-21 22:20:56 +00:00
90e2b6f26b
Add test for dc_remove_cr_chars
2019-09-21 21:26:47 +00:00
05f9f454c3
refactor: remove x module and delete deadcode
2019-09-21 17:56:49 +02:00
b85f59798c
refactor(chat): remove c types and unsafe ( #572 )
...
refactor(chat): remove c types and unsafe
2019-09-21 17:14:52 +02:00
e80345a05b
refactor(chat): remove c types and unsafe
2019-09-21 16:59:59 +02:00
0bdcc3d616
refactor(message): remove remaining unsafe and c types
2019-09-21 16:37:19 +02:00
987f12740e
refactor(message): remove unsafe and c types from the Message api
2019-09-21 16:37:19 +02:00
1265016a55
refactor(message): rustiy api
2019-09-21 16:37:19 +02:00
48d1de3678
Avoid ok-to-continue pattern in set_draft_raw ( #570 )
...
Avoid ok-to-continue pattern in `set_draft_raw`
2019-09-21 14:32:20 +02:00
43f6db3252
cargo-fmt
2019-09-21 06:19:55 +00:00
5b917e7d10
Remove last mutable variable from do_set_draft
2019-09-21 06:19:21 +00:00
0523868a88
Avoid ok-to-continue pattern in "do_set_draft" function
...
Note: I strongly suggest reviewing this commit in side-by-side mode.
Note: This commit fails CI due incorrect formatting. It is done
deliberately to simplify review process.
2019-09-21 06:16:15 +00:00
26f176eb7e
Factor another part of set_draft_raw into separate function
2019-09-21 06:04:55 +00:00
ad32b5ca8f
cargo-fmt
2019-09-21 05:44:31 +00:00
dbf14179dc
Make message argument to set_draft_raw() no longer optional
...
Previously, "set_draft_raw" function was used with "msg = None" only for
side-effect of removing current draft message in chat.
After draft removal functionality was factored into separate
"maybe_delete_draft" function, it is used directly in only call site,
which used to invoke "set_draft_raw" with optional message.
This function is private, and this refactoring does not change FFI
interface.
Note: This commit fails CI due incorrect formatting. It is done
deliberately to simplify review process.
2019-09-21 05:34:48 +00:00
45b0a4ec27
Factor part of set_draft_raw into new function maybe_delete_draft
2019-09-21 05:24:03 +00:00
1969ee02a5
refactor(mimeparser): rustify mailmime_get_type
2019-09-21 00:51:36 +02:00
266b205c75
refactor: rustify interface of maimlime_transfer_decode
2019-09-21 00:51:36 +02:00
7dd3bad8bd
Add factory method MimeFactory::new
...
* src/dc_mimefactory.rs(new): add factory method to have verbose
initialization of all (more than 10) MimeFactory fields only in one place.
* src/dc_mimefactory.rc(dc_mimefactory_load_msg, dc_mimefactory_load_mdn):
simplify code (and reduce linecount) using Mimefactory::new
2019-09-20 22:49:33 +02:00
4b45be7cda
cargo fmt only
2019-09-20 22:43:20 +02:00
497ffd86fa
make logic and comments more like C (early returns instead of nestedness)
...
next commit: cargo fmt
2019-09-20 22:43:20 +02:00
0bdcc4269f
refactor(mimeparser): split and cleanup parse_mime_recursive
2019-09-20 21:42:23 +02:00
e583c99f94
Make return type of Image::mv an enum ( #548 )
...
Make return type of Image::mv an enum
2019-09-20 20:56:27 +02:00
e22e50c3fa
Rename dc_mimefactory_t -> MimeFactory ( #563 )
...
Rename dc_mimefactory_t -> MimeFactory
2019-09-20 20:56:12 +02:00
e9c9a3e1ce
Change type of MimeFactory.loaded to enum
...
* src/dc_mimefactory.rs(MimeFactory): change type of `loaded` field
* src/dc_mimefactory.rs(Loaded): new enum, describing possible
values of `loaded` field of `MimeFactory` structure
* src/dc_mimefactory.rs(dc_mimefactory_loaded_t): remove unused type alias
* src/job.rs(add_smtp_job): adjust call site by removing multiple casts
* src/dc_mimefactory.rs(dc_mimefactory_render): ditto
2019-09-20 18:02:57 +00:00
fa7bb71f3f
Change type of MimeFactory.out_{gossip,encrypted} to bool
2019-09-20 18:02:57 +00:00
34a3ad82e0
Rename dc_mimefactory_t -> MimeFactory
...
CamelCase naming convention is more natural for Rust.
https://rust-lang-nursery.github.io/api-guidelines/naming.html
2019-09-20 18:02:57 +00:00
2f5d74dbf4
Remove unused constants from src/imap.rs
2019-09-20 17:35:26 +00:00
4bf5ba594c
Make Imap::set_mdnseen return enum, not int
2019-09-20 17:35:26 +00:00
6e2da27f45
Change return type of Imap::set_seen to enum
2019-09-20 17:35:26 +00:00
6ee9465d43
Make return type of Image::mv an enum
...
Replace named constants with enum to improve type-safety and make
exhausiveness checks possible.
Note, that since this enum never pass FFI border, its numeric values
does not need to be specified explicitly and can be left on compiler's
discretion.
2019-09-20 17:35:25 +00:00
391a6bf422
Replace numbers with named constants
2019-09-20 17:35:25 +00:00
holger krekel