awesome-bookmarks/arcanechat-android
3
0
Fork 0
mirror of https://github.com/ArcaneChat/android.git synced 2026-07-03 14:05:24 +02:00
Code Issues Packages Projects Releases 3 Wiki Activity

QrActivity: replace fragile fragment tag lookups with direct references

Browse Source 
Agent-Logs-Url: https://github.com/ArcaneChat/android/sessions/2ccd1bbb-e291-4d2d-b541-964679f4188e

Co-authored-by: adbenitez <24558636+adbenitez@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-05-11 17:20:41 +00:00
committed by GitHub
parent ee3dcd38a6
commit 88f528e8b8
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/org/thoughtcrime/securesms/qr/QrActivity.java
+9 -10
View File
@@ -51,6 +51,7 @@ public class QrActivity extends BaseActionBarActivity implements View.OnClickLis
private TabLayout tabLayout;
private ViewPager2 viewPager;
private QrShowFragment qrShowFragment;
private ProfilePagerAdapter adapter;
private boolean scanRelay;
@Override
@@ -69,7 +70,7 @@ public class QrActivity extends BaseActionBarActivity implements View.OnClickLis
qrShowFragment = new QrShowFragment(this);
tabLayout = ViewUtil.findById(this, R.id.tab_layout);
viewPager = ViewUtil.findById(this, R.id.pager);
ProfilePagerAdapter adapter = new ProfilePagerAdapter(this);
adapter = new ProfilePagerAdapter(this);
viewPager.setAdapter(adapter);
setSupportActionBar(ViewUtil.findById(this, R.id.toolbar));
@@ -104,11 +105,8 @@ public class QrActivity extends BaseActionBarActivity implements View.OnClickLis
.withPermanentDenialDialog(getString(R.string.perm_explain_access_to_camera_denied))
.onAllGranted(
() -> {
Fragment qrScanFrag =
getSupportFragmentManager().findFragmentByTag("f" + TAB_SCAN);
if (qrScanFrag instanceof QrScanFragment) {
((QrScanFragment) qrScanFrag).handleQrScanWithPermissions(QrActivity.this);
}
QrScanFragment qrScanFrag = adapter.getQrScanFragment();
qrScanFrag.handleQrScanWithPermissions(QrActivity.this);
})
.onAnyDenied(
() -> {
@@ -150,10 +148,7 @@ public class QrActivity extends BaseActionBarActivity implements View.OnClickLis
} else if (itemId == R.id.new_classic_contact) {
this.startActivity(new Intent(this, NewContactActivity.class));
} else if (itemId == R.id.withdraw) {
Fragment frag = getSupportFragmentManager().findFragmentByTag("f" + TAB_SHOW);
if (frag instanceof QrShowFragment) {
((QrShowFragment) frag).withdrawQr();
}
qrShowFragment.withdrawQr();
} else if (itemId == R.id.load_from_image) {
AttachmentManager.selectImage(this, REQUEST_CODE_IMAGE);
} else if (itemId == R.id.paste) {
@@ -241,6 +236,10 @@ public class QrActivity extends BaseActionBarActivity implements View.OnClickLis
super(activity);
}
QrScanFragment getQrScanFragment() {
return qrScanFragment;
}
@NonNull
@Override
public Fragment createFragment(int position) {