mirror of
https://github.com/newliver666/apk-reverse.git
synced 2026-09-28 21:56:59 +02:00
inliver233
a1ada96cc3
PR #3 proposed adding mypy and flake8 to CI, with configurations for both. The idea is right and the configurations are kept. Three things about the PR itself needed correcting, and all three were found by running the gate rather than reading the diff: 1. It was written against an older tree. Its own edits reference code that no longer exists there (`unknown, positions, warnings = ...`, a `struct` import at line 857 that is used 600 lines later), so merging it as-is would have removed a live import. The fixes were re-derived against the current tree instead, and the PR is superseded. 2. It added a `paths:` filter to the workflow, watching only `*.py` plus the two lint configs. That would stop `check_refs.py` and `check_routing.py` -- documentation gates -- from running on a documentation-only commit, which is exactly the change they exist to catch. The workflow keeps the PR's `actions/*@v7` bump and gains no filter; the reason is written next to the trigger. 3. `pip install --upgrade pip pytest` was dropped to just the packages, because upgrading pip in CI is not a goal and can fail for reasons unrelated to this repository. What the gate found on the current tree, and what was done about it -- 70 flake8 findings and 3 mypy errors, none of which were cosmetic-only: F401 (23) unused imports, removed. These were safe to delete because the import statement itself cannot have a side effect that matters here. F841 (12) unused bindings, handled three ways rather than one. Dead code was deleted (`mt_mcp_probe.print_waiting_help`'s `host`, `repack.py`'s `signer_jar`); a computed value that was then forgotten was **wired up** (`rasc_build.py` now names the linker target in its build-failure hint instead of discarding it); and a binding that is intentional kept its place with `# noqa: F841` and the reason -- `java2c_probe` reads dex header fields one by one against the format spec, and deleting three of them to please a linter would have made the parser stop lining up with the format it implements. E741 (14) the ambiguous loop name `l`, renamed with an AST pass that resolves each binding to its own scope. A regex rename would have been wrong: several scopes bind their own `l`. That pass had a defect of its own -- it treated a comprehension target as living in the comprehension scope while leaving references to it in the enclosing one -- which produced seven `undefined name 'l'`. Found by running flake8, fixed, and the counting bug is documented in `check_routing.py`, whose own `tables()` had the same class of error in the other direction. style continuation indents, blank lines between top-level definitions, and lines over length. The line limit is 160, not 120, and the number is a **measurement**: this repository's secret-scanner rule table holds raw regex source of 148 and 156 characters, which cannot be split without changing the pattern. mypy (3) two missing annotations on module-level containers, and one optional-dependency rebind (`dexutil = None` after `except ImportError`) that is the repository's own idiom and now says so with a `type: ignore[assignment]` and the reason. No code was reordered to satisfy the checker. Verified on a venv containing only `mypy` and `flake8` -- the poorest environment the configuration must work in, and the one CI uses: **flake8 reports 0, mypy reports "Success: no issues found in 55 source files"**. Behaviour is unchanged: 625 passed / 163 skipped / 25 xfailed, the same five gates green (check_repo 0 problem, check_refs 0 dangling, check_routing coherent, check_budget 0 failure, check_commands 0 drift), and every key script still prints help. .flake8 new, with the line-length and complexity numbers and their reasons mypy.ini new; optional imports declared, nothing excluded from the analysis ci.yml `actions/*@v7`; new `lint` job on one interpreter; no path filter 30 files the findings above
50 lines
1.8 KiB
INI
50 lines
1.8 KiB
INI
# mypy configuration for this repository.
|
|
#
|
|
# The repository is designed to check out and run its gates with only the standard library plus
|
|
# pytest (see pytest.ini and .github/workflows/ci.yml): frida, capstone, tiktoken and PyYAML are
|
|
# optional runtime dependencies that scripts import lazily or behind try/except, with documented
|
|
# fallbacks. Do not require them -- or their stubs -- to be installed for
|
|
# `mypy *.py skills/apk-reverse/scripts/*.py` to pass. When they *are* installed and typed
|
|
# (e.g. types-PyYAML), mypy still uses the real stubs; these overrides only apply where the module is
|
|
# missing or untyped.
|
|
#
|
|
# When installed, capstone ships no py.typed marker; frida and tiktoken are host-side extras.
|
|
# Everything else in the tree is analyzed normally, including every gate script -- which is the point:
|
|
# check_repo/check_refs/check_budget/check_routing/check_commands carry the behaviour of the whole
|
|
# repository, so they are worth type-checking rather than excluding.
|
|
#
|
|
# Enforced in CI: the `lint` job in .github/workflows/ci.yml runs mypy with exactly this
|
|
# configuration, on a bare interpreter (no frida/capstone/tiktoken/PyYAML installed), so the
|
|
# overrides below are exercised rather than skipped.
|
|
#
|
|
# Verified locally on 2026-09-22: `mypy` over 55 files reports no issues with the overrides in place,
|
|
# on a venv containing only mypy and flake8.
|
|
|
|
[mypy]
|
|
python_version = 3.9
|
|
warn_unused_ignores = False
|
|
|
|
[mypy-frida]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-frida.*]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-capstone]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-capstone.*]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-tiktoken]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-tiktoken.*]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-yaml]
|
|
ignore_missing_imports = True
|
|
|
|
[mypy-yaml.*]
|
|
ignore_missing_imports = True
|