ai-space/socraticode
3
0
Fork 0
mirror of https://github.com/giancarloerra/socraticode.git synced 2026-07-03 14:05:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: address CodeRabbit review feedback on tests

Browse Source 
- Refactor git temp repos into initTempRepo() helper using git config
  instead of env vars (resolves Critical finding)
- Restore SOCRATICODE_LINKED_PROJECTS and SOCRATICODE_PROJECT_ID to
  original values in resolveLinkedCollections afterEach
- Fix TypeScript 'never' type errors in query-tools mocks by adding
  explicit SearchResult[] return types
This commit is contained in:
Giancarlo Erra
2026-04-11 17:25:46 +01:00
parent ad2e3b9ea1
commit f09f417c6e
2 changed files with 26 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/config.test.ts
+22 -8
View File
@@ -247,6 +247,8 @@ describe("config", () => {
let tmpDir: string;
let projectDir: string;
let linkedDir: string;
const savedLinkedEnv = process.env.SOCRATICODE_LINKED_PROJECTS;
const savedProjectIdEnv = process.env.SOCRATICODE_PROJECT_ID;
beforeEach(() => {
tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "socraticode-test-"));
@@ -260,7 +262,16 @@ describe("config", () => {
afterEach(() => {
fs.rmSync(tmpDir, { recursive: true, force: true });
delete process.env.SOCRATICODE_LINKED_PROJECTS;
if (savedLinkedEnv === undefined) {
delete process.env.SOCRATICODE_LINKED_PROJECTS;
} else {
process.env.SOCRATICODE_LINKED_PROJECTS = savedLinkedEnv;
}
if (savedProjectIdEnv === undefined) {
delete process.env.SOCRATICODE_PROJECT_ID;
} else {
process.env.SOCRATICODE_PROJECT_ID = savedProjectIdEnv;
}
});
it("returns only current project when no links configured", () => {
@@ -344,14 +355,19 @@ describe("config", () => {
});
});
const gitEnv = { ...process.env, GIT_AUTHOR_NAME: "test", GIT_AUTHOR_EMAIL: "test@test.com", GIT_COMMITTER_NAME: "test", GIT_COMMITTER_EMAIL: "test@test.com" };
/** Create a temporary git repo with a named branch and initial commit. */
function initTempRepo(tmpDir: string, branch: string): void {
execFileSync("git", ["init", "-b", branch, tmpDir]);
execFileSync("git", ["config", "user.name", "test"], { cwd: tmpDir });
execFileSync("git", ["config", "user.email", "test@test.com"], { cwd: tmpDir });
execFileSync("git", ["commit", "--allow-empty", "-m", "init"], { cwd: tmpDir });
}
describe("detectGitBranch", () => {
it("detects a branch in a git repo", () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "socraticode-git-"));
try {
execFileSync("git", ["init", "-b", "test-branch", tmpDir]);
execFileSync("git", ["commit", "--allow-empty", "-m", "init"], { cwd: tmpDir, env: gitEnv });
initTempRepo(tmpDir, "test-branch");
const branch = detectGitBranch(tmpDir);
expect(branch).toBe("test-branch");
} finally {
@@ -379,8 +395,7 @@ describe("config", () => {
it("appends branch suffix when SOCRATICODE_BRANCH_AWARE=true", () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "socraticode-braware-"));
try {
execFileSync("git", ["init", "-b", "my-feature", tmpDir]);
execFileSync("git", ["commit", "--allow-empty", "-m", "init"], { cwd: tmpDir, env: gitEnv });
initTempRepo(tmpDir, "my-feature");
process.env.SOCRATICODE_BRANCH_AWARE = "true";
const id = projectIdFromPath(tmpDir);
expect(id).toContain("__");
@@ -395,8 +410,7 @@ describe("config", () => {
it("produces valid Qdrant collection names with branch suffix", () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "socraticode-braware-"));
try {
execFileSync("git", ["init", "-b", "feat/some-branch", tmpDir]);
execFileSync("git", ["commit", "--allow-empty", "-m", "init"], { cwd: tmpDir, env: gitEnv });
initTempRepo(tmpDir, "feat/some-branch");
process.env.SOCRATICODE_BRANCH_AWARE = "true";
const id = projectIdFromPath(tmpDir);
const coll = collectionName(id);
tests/unit/query-tools.test.ts
+4 -2
View File
@@ -64,8 +64,10 @@ vi.mock("../../src/services/docker.js", () => ({
// ── qdrant.js mock ───────────────────────────────────────────────────────
const mockSearchChunks = vi.fn(async (_collection: string, _query: string, _limit: number) => []);
const mockSearchMultipleCollections = vi.fn(async () => []);
import type { SearchResult } from "../../src/types.js";
const mockSearchChunks = vi.fn(async (_collection: string, _query: string, _limit: number): Promise<SearchResult[]> => []);
const mockSearchMultipleCollections = vi.fn(async (): Promise<SearchResult[]> => []);
vi.mock("../../src/services/qdrant.js", () => ({
searchChunks: (...args: unknown[]) => mockSearchChunks(...(args as [string, string, number])),