ai-space/goose
3
0
Fork 0
mirror of https://github.com/aaif-goose/goose.git synced 2026-07-03 14:10:03 +02:00
Code Issues Packages Projects Releases Wiki Activity
4,912 Commits 603 Branches 222 Tags
micn/duplicated-thinking
Commit Graph

4912 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Neale af8df7c727 addressing feedback 2026-06-30 13:27:42 +10:00
Michael Neale 70fecc999a don't persist thinking stand alone redundantly 2026-06-30 12:55:09 +10:00
Michael Neale 4d049d7f1e Merge remote-tracking branch 'origin/main' into micn/duplicated-thinking 
* origin/main:
  chore: Remove legacy MCP-UI proxy support (#10086)
  Remove session_id from provider streaming trait methods (#9984)
  fix(cli): update help text for --session-id (#10077)
 2026-06-30 10:09:48 +10:00
Lifei Zhou f81a0e2471 chore: Remove legacy MCP-UI proxy support (#10086) 2026-06-29 22:58:40 +00:00
Jack Amadeo fe7f16b727 Remove session_id from provider streaming trait methods (#9984) 2026-06-29 22:04:58 +00:00
vvaswani 84d02d6d47 fix(cli): update help text for --session-id (#10077) 
Signed-off-by: Vikram Vaswani <2571660+vvaswani@users.noreply.github.com>
 2026-06-29 15:30:27 +00:00
Michael Neale 4a1567c939 Tighten dedupe comments to match house style 2026-06-29 17:47:13 +10:00
Michael Neale dba4c72620 Address PR feedback: restrict dedupe to signed thinking, drop agent.rs change 
P2 #1: dedupe_signed_thinking now only collapses signed thinking blocks
(non-empty signature) and redacted thinking, leaving duplicate unsigned
reasoning summaries (from non-Anthropic providers) untouched.

P2 #2: reverted the agent.rs change that stripped signed thinking from all
split tool-call messages, which would have left later split messages in a
multi-tool turn without their thinking. The dedupe pass alone now handles
the fix at a single layer: each split assistant message keeps its own
single signed thinking block, and within-message duplicates are collapsed.

Adds a test that duplicate unsigned thinking is preserved.
 2026-06-29 16:15:29 +10:00
Michael Neale a33e76d857 Merge remote-tracking branch 'origin/main' into micn/duplicated-thinking 
* origin/main:
  task(acp): upgrade SDK and use new HTTP/WS crate (#10082)
  fix(providers): reject non-object tool-call arguments instead of panicking (#9832)

# Conflicts:
#	crates/goose/src/agents/agent.rs
 2026-06-29 16:02:06 +10:00
Michael Neale 4091fe68c9 Don't echo signed thinking onto split tool-call messages (#10080) 
Implements the source-side fix: when persisting an assistant turn that
emitted thinking + tool calls, only unsigned thinking (Kimi/DeepSeek/
Gemini) is echoed onto each split tool-call message. Signed thinking
(Anthropic) already lives on the standalone thinking message, so echoing
it again produced duplicate signed blocks that merge_consecutive_messages
collapsed into one assistant turn, which Anthropic rejects with a 400.

Adds is_signed_thinking helper and a unit test. The dedupe pass from the
prior commit remains as a guardrail and to repair existing sessions.
 2026-06-29 15:51:32 +10:00
Alex Hancock 2cc1140dc1 task(acp): upgrade SDK and use new HTTP/WS crate (#10082) 2026-06-29 05:27:11 +00:00
Michael Neale d065bb2378 Dedupe duplicate signed thinking blocks to fix Anthropic 400 (#10080) 
Add a dedupe_signed_thinking pass to the conversation fixer that removes
duplicate signed thinking/redacted_thinking blocks within an assistant
message. This repairs both new and existing sessions where a standalone
thinking message and a tool-call message that re-embeds the same signed
thinking get merged into a single turn with adjacent duplicate thinking
blocks, which Anthropic rejects with a 400.
 2026-06-29 14:12:17 +10:00
lunchboxfortwo a1711e75e2 fix(providers): reject non-object tool-call arguments instead of panicking (#9832) 
Signed-off-by: Lunchbox <lunchboxfortwo@gmail.com>
Signed-off-by: Douwe M Osinga <douwe@sidewalklabs.com>
Signed-off-by: Goose <goose@aaif.dev>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
Co-authored-by: Goose <goose@aaif.dev>
Co-authored-by: Michael Neale <michael.neale@gmail.com>
 2026-06-29 04:08:19 +00:00
Ken Jo ec0ae7e12c docs: name the message field in the hooks payload guide (#9913) 
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-28 20:24:32 +00:00
Adam Miller 71280996d4 fix(cli): save /edit prompts to history (#10011) 
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-28 16:44:01 +00:00
Yixuan Zhong 9ff7376338 feat(i18n): add fr, de, it, pt, id, ms, vi, zh-TW desktop locales (#10072) 
Co-authored-by: Yixuan Zhong <Yixuan.Zhong@aecom.com>
 2026-06-28 16:33:11 +00:00
Lifei Zhou 52291e64a7 feat (acp+): Use ACP permission manager for tool permissions (#10066) 2026-06-28 09:54:51 +00:00
Lifei Zhou 8878452785 feat (ui): Remove ACP chat feature flag and turn on chat using ACP (#10062) 2026-06-27 23:13:34 +00:00
石岳峰 d2687643da fix(schedule): use session.message_count for schedule sessions listing (#10026) 
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
 2026-06-27 16:24:54 +00:00
Abhijay Jain b3c086e47a feat(acp): migrate getDictationConfig and transcribeDictation to ACP (#10048) 2026-06-27 16:23:44 +00:00
Lifei Zhou 4f7bf8c1e2 fix: sync the sesion store after session provider and model update and also update thinking effort (#10060) 2026-06-27 07:45:19 +00:00
Lifei Zhou e2a2a64d3c feat: handling platform event mcp notification for acp (#10038) 2026-06-27 04:32:26 +00:00
Alex Hancock 98a13fff4b feat(acp+): config in desktop on ACP+ (#10057) 2026-06-27 03:45:14 +00:00
Alex Hancock 2fda760641 feat(acp+): models/providers in desktop on ACP+ (#9987) 2026-06-26 17:04:24 +00:00
Bradley Axen d1d2166190 Support streamed tool calls without indexes (#10023) 2026-06-26 16:09:11 +00:00
Jack Amadeo 35999d49f3 add ACP+ handlers for prompt editing (#10031) 2026-06-26 16:03:31 +00:00
Abhijay Jain f0a3ed3a55 refactor: replace getTunnelStatus with GOOSE_DISABLE_NOSTR_SHARING config flag (#10044) 2026-06-26 15:57:58 +00:00
Douwe Osinga d9cf383711 chore: ignore Zed settings (#10043) 
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-26 14:44:26 +00:00
Lifei Zhou ec450a630e fix: removed fallback rest api call in ACP mode for edit in place (#10034) 2026-06-26 14:11:46 +00:00
Abhijay Jain 22883e3704 feat(acp): migrate upsertPermissions to setToolPermissions ACP method (#9999) 2026-06-26 12:16:18 +00:00
Lifei Zhou 59b28e455f Apply ACP recipe state during session load and fork (#9998) 2026-06-25 23:13:57 +00:00
Lifei Zhou 3c62892d1d feat: used acp agent capabilities for local Inference support check (#9996) 2026-06-25 23:12:22 +00:00
Jack Amadeo 854fed5e5d move anthropic provider into goose-providers (#9985) 2026-06-25 23:00:08 +00:00
Douwe Osinga d1af10c5ad Migrate Nostr session sharing to ACP (#10022) 
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-25 22:30:42 +00:00
Jack Amadeo 789717b94a run all builds on the release branch, before tagging (#10017) 2026-06-25 20:27:27 +00:00
SynthLuvr 37d93ceaca Add GLM-5.2 support (#9967) 
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-25 16:59:16 +00:00
Jack Amadeo 9c96bd7ebc ignore unused on windows (#10009) 2026-06-25 16:59:14 +00:00
Jack Amadeo 8ab0320a7b Revert "mcp(win): full Windows Job Object cleanup wiring (patch draft… (#10013) 2026-06-25 16:59:12 +00:00
Lifei Zhou bb4a9a7920 removed unnecessary call setRecipeParams for acp enabled path (#10003) 2026-06-25 16:30:20 +00:00
Douwe Osinga dc8aedfd6a ACP Migration: MCP/Goose Apps (#9988) 
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-25 14:06:49 +00:00
dependabot[bot] f1bf611a22 chore(deps): bump docker/setup-buildx-action from 3.12.0 to 4.1.0 (#9895) 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2026-06-25 13:45:22 +00:00
Lifei Zhou 24166fc344 chore: Remove share session via base url (#9994) 2026-06-25 03:01:08 +00:00
Lifei Zhou db26fb79c9 suppress telemetry event on ui (#9991) 2026-06-25 00:50:27 +00:00
Abhijay Jain 416aad8136 chore: remove gateway REST API and UI (#9989) 
Co-authored-by: Lifei Zhou <lifei@squareup.com>
 2026-06-25 00:44:18 +00:00
Lifei Zhou eea698945c feat (acp): custom methods for managing scheduler (#9972) 2026-06-24 23:11:35 +00:00
Lifei Zhou 09998b12cf chore: removed the too many tools warning (#9974) 2026-06-24 22:15:47 +00:00
Lifei Zhou d97d07fe17 chore: clean up ui as we don't have session based permission setting on ui (#9975) 2026-06-24 20:53:41 +00:00
Lifei Zhou 274e9521c6 chore: removed mesh on ui (#9982) 2026-06-24 20:52:47 +00:00
filip 6d7e2da8c4 perf: disable extended thinking for fast-model operations (#9815) 
Signed-off-by: Filip Kujawa <filip.j.kujawa@gmail.com>
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
 2026-06-24 19:40:50 +00:00
Theofanis Petkos 0c9acc33c9 fix(providers): Buffer thinking across stream chunks for DeepSeek/Kimi tool calls (#9704) 
Signed-off-by: thepetk <thepetk@gmail.com>
 2026-06-24 18:46:02 +00:00