From e842cfa7eb98c61c83d8f9d4ac34b3e7742b8a74 Mon Sep 17 00:00:00 2001 From: silentrald Date: Sun, 20 Apr 2025 01:28:43 +0800 Subject: [PATCH] [bugfix] allow env overriding with launch options (#854) --- .../services/bs-launcher/abstract-launcher.service.ts | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/main/services/bs-launcher/abstract-launcher.service.ts b/src/main/services/bs-launcher/abstract-launcher.service.ts index b1622d65..223869a1 100644 --- a/src/main/services/bs-launcher/abstract-launcher.service.ts +++ b/src/main/services/bs-launcher/abstract-launcher.service.ts @@ -137,12 +137,11 @@ export abstract class AbstractLauncherService { const envString = command.substring(0, index); log.info("Parsing env string ", `"${envString}"`) for (const [ key, value ] of Object.entries(parseEnvString(envString))) { - if (key in env) { - log.warn("Ignoring", `${key}=${value}`, "already set env launch command"); - continue; - } - - log.info("Injecting", `${key}="${value}"`, "to the env launch command"); + log.info( + key in env ? "Overriding" : "Injecting", + `${key}="${value}"`, + "to the env launch command" + ); env[key] = value; }