From b9359d6b9c6716a920b425e5dc0a2530bffbf1d8 Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Sun, 21 May 2023 01:38:48 +0200 Subject: [PATCH] [feature-136] add models in shared contents + open download models on click "download models" when no models + fix version undefined when go in shared maps --- assets/jsons/translations/de.json | 10 +++++-- assets/jsons/translations/en.json | 10 +++++-- assets/jsons/translations/es.json | 10 +++++-- assets/jsons/translations/fr.json | 10 +++++-- .../services/version-folder-linker.service.ts | 1 + .../maps-playlists-panel.component.tsx | 6 ++-- .../models-grid.component.tsx | 14 ++++++--- .../models-panel.component.tsx | 28 +++++++++--------- .../models-tabs-navbar.component.tsx | 2 +- .../bs-version-item.component.tsx | 2 +- .../maps-nav-bar-item.component.tsx | 24 --------------- .../shared-nav-bar-item.component.tsx | 29 +++++++++++++++++++ .../components/nav-bar/nav-bar.component.tsx | 8 ++--- src/renderer/pages/maps-page.component.tsx | 18 ------------ .../pages/shared-contents-page.component.tsx | 28 ++++++++++++++++++ .../pages/version-viewer.component.tsx | 6 ++-- .../models-manager.service.ts | 1 + .../services/version-folder-linker.service.ts | 4 +-- src/renderer/windows/App.tsx | 4 +-- 19 files changed, 129 insertions(+), 86 deletions(-) delete mode 100644 src/renderer/components/nav-bar/nav-bar-items/maps-nav-bar-item.component.tsx create mode 100644 src/renderer/components/nav-bar/nav-bar-items/shared-nav-bar-item.component.tsx delete mode 100644 src/renderer/pages/maps-page.component.tsx create mode 100644 src/renderer/pages/shared-contents-page.component.tsx diff --git a/assets/jsons/translations/de.json b/assets/jsons/translations/de.json index edcc9f99..61c45b37 100644 --- a/assets/jsons/translations/de.json +++ b/assets/jsons/translations/de.json @@ -16,7 +16,11 @@ }, "nav-bar":{ "add-version": "Version Hinzufügen", - "settings": "Einstellungen" + "settings": "Einstellungen", + "shared": { + "text": "Geteilt", + "tooltip": "Geteilte Inhalte" + } }, "pages": { "shared-maps":{ @@ -674,7 +678,6 @@ } }, "models":{ - "models": "Modelle", "types": { "singular": { "avatar": "Avatar", @@ -825,7 +828,8 @@ "prevent-for-mods": { "title": "Erforderliche Mods", "desc": "Stellen Sie sicher, dass Sie die notwendigen Mods installiert haben, um Modelle in BeatSaber zu verwenden", - "go-to-mods": "Gehe zu Mods" + "go-to-mods": "Gehe zu Mods", + "not-remind": "Erinnere mich nicht" }, "export-success": { "title": "Export abgeschlossen 🎉" diff --git a/assets/jsons/translations/en.json b/assets/jsons/translations/en.json index cb82159b..bf6856d2 100644 --- a/assets/jsons/translations/en.json +++ b/assets/jsons/translations/en.json @@ -16,7 +16,11 @@ }, "nav-bar":{ "add-version": "Add a version", - "settings": "Settings" + "settings": "Settings", + "shared": { + "text": "Shared", + "tooltip": "Shared contents" + } }, "pages": { "shared-maps":{ @@ -674,7 +678,6 @@ } }, "models":{ - "models": "Models", "types": { "singular": { "avatar": "avatar", @@ -825,7 +828,8 @@ "prevent-for-mods": { "title": "Required mods", "desc": "Make sure you've installed the necessary mods to use models in BeatSaber", - "go-to-mods": "Go to mods" + "go-to-mods": "Go to mods", + "not-remind": "Do not remind me" }, "export-success": { "title": "Export completed 🎉" diff --git a/assets/jsons/translations/es.json b/assets/jsons/translations/es.json index 2ddd9a5b..0eed1939 100644 --- a/assets/jsons/translations/es.json +++ b/assets/jsons/translations/es.json @@ -16,7 +16,11 @@ }, "nav-bar":{ "add-version": "Agregar una versión", - "settings": "Ajustes" + "settings": "Ajustes", + "shared": { + "text": "Compartidos", + "tooltip": "Contenidos compartidos" + } }, "pages": { "shared-maps":{ @@ -673,7 +677,6 @@ } }, "models":{ - "models": "Modelos", "types": { "singular": { "avatar": "avatar", @@ -824,7 +827,8 @@ "prevent-for-mods": { "title": "Mods necesarios", "desc": "Asegúrate de haber instalado los mods necesarios para usar modelos en BeatSaber", - "go-to-mods": "Ir a mods" + "go-to-mods": "Ir a mods", + "not-remind": "No volver a recordarme" }, "export-success": { "title": "Exportación completada 🎉" diff --git a/assets/jsons/translations/fr.json b/assets/jsons/translations/fr.json index f94fd63e..c3b92924 100644 --- a/assets/jsons/translations/fr.json +++ b/assets/jsons/translations/fr.json @@ -18,7 +18,11 @@ }, "nav-bar":{ "add-version": "Ajouter une version", - "settings": "Paramètres" + "settings": "Paramètres", + "shared": { + "text": "Partagés", + "tooltip": "Contenus partagés" + } }, "pages": { "shared-maps":{ @@ -675,7 +679,6 @@ } }, "models":{ - "models": "Modèles", "types": { "singular": { "avatar": "avatar", @@ -826,7 +829,8 @@ "prevent-for-mods": { "title": "Mods nécessaires", "desc": "Assurez-toi d'avoir installé les mods nécessaires pour utiliser des modèles dans BeatSaber", - "go-to-mods": "Aller aux mods" + "go-to-mods": "Aller aux mods", + "not-remind": "Ne plus me rappeler" }, "export-success": { "title": "Export terminé 🎉" diff --git a/src/main/services/version-folder-linker.service.ts b/src/main/services/version-folder-linker.service.ts index cb24a279..7023feb6 100644 --- a/src/main/services/version-folder-linker.service.ts +++ b/src/main/services/version-folder-linker.service.ts @@ -80,6 +80,7 @@ export class VersionFolderLinkerService { } public async isFolderLinked(version: BSVersion, relativeFolder: string): Promise{ + if(!version){ return Promise.reject("no version provided") } const versionPath = await this.localVersion.getVersionPath(version); const folderPath = this.relativeToFullPath(versionPath, relativeFolder); return this.folderLinker.isFolderSymlink(folderPath); diff --git a/src/renderer/components/maps-mangement-components/maps-playlists-panel.component.tsx b/src/renderer/components/maps-mangement-components/maps-playlists-panel.component.tsx index 21d802b4..cd847b2d 100644 --- a/src/renderer/components/maps-mangement-components/maps-playlists-panel.component.tsx +++ b/src/renderer/components/maps-mangement-components/maps-playlists-panel.component.tsx @@ -43,6 +43,8 @@ export function MapsPlaylistsPanel({version}: Props) { const mapsRef = useRef(); useEffect(() => { + if(!version){ return; } + loadMapIsLinked(); const sub = mapsService.$mapsLinkingPending(version).pipe(debounceTime(50)).subscribe(setLinkingPending); @@ -145,8 +147,8 @@ export function MapsPlaylistsPanel({version}: Props) { })() return ( -
-