From a4c7ee04dbc3217a5be6cf1c81b0b7c3bc67a0a4 Mon Sep 17 00:00:00 2001 From: RedlineTriad <39059512+RedlineTriad@users.noreply.github.com> Date: Thu, 29 Jun 2023 21:48:27 +0200 Subject: [PATCH] refactor: use find instead of filter for nicer code and perf --- .../additional-content/local-maps-manager.service.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/services/additional-content/local-maps-manager.service.ts b/src/main/services/additional-content/local-maps-manager.service.ts index e40c06a0..2f73915f 100644 --- a/src/main/services/additional-content/local-maps-manager.service.ts +++ b/src/main/services/additional-content/local-maps-manager.service.ts @@ -96,12 +96,12 @@ export class LocalMapsManagerService { private async loadMapInfoFromPath(mapPath: string): Promise{ const files = await getFilesInFolder(mapPath); - const infoFilePaths = files - .filter(file => (path.basename(file).toLowerCase() === "info.dat")) + const infoFile = files + .find(file => (path.basename(file).toLowerCase() === "info.dat")) - if(infoFilePaths.length === 0){ return null; } + if(infoFile === null){ return null; } - const rawInfoString = await readFile(infoFilePaths[0], {encoding: "utf-8"}); + const rawInfoString = await readFile(infoFile, {encoding: "utf-8"}); const rawInfo: RawMapInfoData = JSON.parse(rawInfoString); const coverUrl = new URL(`file:///${path.join(mapPath, rawInfo._coverImageFilename)}`).href;