From 9e60dc4e0ea853b51ed0337ee19db38a9b4b5420 Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Tue, 5 Nov 2024 20:34:26 +0100 Subject: [PATCH] [bugfix] prevent bug with special chars when using "preferContentDisposition" --- src/main/services/request.service.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/services/request.service.ts b/src/main/services/request.service.ts index 9f5f7164..ef3777e3 100644 --- a/src/main/services/request.service.ts +++ b/src/main/services/request.service.ts @@ -8,6 +8,7 @@ import { unlinkSync } from "fs-extra"; import { tryit } from "shared/helpers/error.helpers"; import path from "path"; import { pipeline } from "stream/promises"; +import sanitize from "sanitize-filename"; export class RequestService { private static instance: RequestService; @@ -66,7 +67,7 @@ export class RequestService { const filename = opt?.preferContentDisposition ? this.getFilenameFromContentDisposition(response.headers["content-disposition"]) : null; if (filename) { - dest = path.join(path.dirname(dest), filename); + dest = path.join(path.dirname(dest), sanitize(filename)); } progress.data = dest;