From 95688b9d33f04c2f84a3405b03438ddaa5d2f3a3 Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Sun, 17 Dec 2023 14:47:51 +0100 Subject: [PATCH] Just move the recommeded version at first insteam of swap versions --- .../available-versions-slide.component.tsx | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/renderer/components/available-versions/available-versions-slide.component.tsx b/src/renderer/components/available-versions/available-versions-slide.component.tsx index 693bb6b9..89f9b3c4 100644 --- a/src/renderer/components/available-versions/available-versions-slide.component.tsx +++ b/src/renderer/components/available-versions/available-versions-slide.component.tsx @@ -3,7 +3,6 @@ import { AvailableVersionItem } from "./available-version-item.component"; import { BSVersion } from "shared/bs-version.interface"; import { AvailableVersionsContext } from "renderer/pages/available-versions-list.components"; import equal from "fast-deep-equal"; -import { swapElements } from "shared/helpers/array.helpers"; type Props = { versions: BSVersion[] @@ -21,10 +20,12 @@ export function AvailableVersionsSlide({ versions }: Props) { } const getVersions = () => { - if(!versions?.length) { return []; } - const recommendedIndex = versions.findIndex(v => v.recommended); - if(recommendedIndex === -1) { return versions; } - return swapElements(recommendedIndex, 0, [...versions]); + const copy = [...(versions ?? [])]; + const recommendedVersion = copy.find(v => v.recommended); + if(!recommendedVersion) { return copy; } + copy.splice(copy.indexOf(recommendedVersion), 1); + copy.unshift(recommendedVersion); + return copy; } return (