From 8e8d6081206f3feb0641d8f09a43015a28dbf473 Mon Sep 17 00:00:00 2001 From: Shidorien Date: Mon, 8 Jan 2024 10:15:21 +0100 Subject: [PATCH] Refactor handleVersionClick function in SettingsPage component --- .../pages/settings-page.component.tsx | 23 +++++++++---------- 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/src/renderer/pages/settings-page.component.tsx b/src/renderer/pages/settings-page.component.tsx index 2cdb449f..f76edab1 100644 --- a/src/renderer/pages/settings-page.component.tsx +++ b/src/renderer/pages/settings-page.component.tsx @@ -147,20 +147,19 @@ export function SettingsPage() { const handleVersionClick = async () => { let isChangelogResolved = false; - const changelogPromise = autoUpdater.showChangelog(await lastValueFrom(autoUpdater.getAppVersion())) - .then(() => { - setIsChangelogAvailable(() => true); - }) - .catch(() => { - setIsChangelogAvailable(() => false); - }) - .finally(() => { isChangelogResolved = true; }); - const timeoutId = setTimeout(() => { - setChanglogsLoading(() => !isChangelogResolved); - }, 100); + await autoUpdater.showChangelog(await lastValueFrom(autoUpdater.getAppVersion())) + .then(() => { + setIsChangelogAvailable(() => true); + }) + .catch(() => { + setIsChangelogAvailable(() => false); + }) + .finally(() => { isChangelogResolved = true; }); - await changelogPromise; + const timeoutId = setTimeout(() => { + setChanglogsLoading(() => !isChangelogResolved); + }, 100); setChanglogsLoading(() => false); clearTimeout(timeoutId); };