From 87c37b18d3544a6bf670814aaba57ecfa734d74e Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Sat, 10 Dec 2022 15:39:26 +0100 Subject: [PATCH] fix observable never complete if error --- src/renderer/services/maps-manager.service.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/renderer/services/maps-manager.service.ts b/src/renderer/services/maps-manager.service.ts index cbb9e94c..8026c816 100644 --- a/src/renderer/services/maps-manager.service.ts +++ b/src/renderer/services/maps-manager.service.ts @@ -25,7 +25,7 @@ export class MapsManagerService { private readonly bsaver: BeatSaverService; private readonly modal: ModalService; private readonly progressBar: ProgressBarService; - private readonly notifications: NotificationService + private readonly notifications: NotificationService; private readonly lastLinkedVersion$: Subject = new Subject(); private readonly lastUnlinkedVersion$: Subject = new Subject(); @@ -41,7 +41,8 @@ export class MapsManagerService { public getMaps(version?: BSVersion, withDetails = true): Observable{ return new Observable(obs => { this.ipcService.send("get-version-maps", {args: version}).then(res => { - if(!res.success){ return obs.next(null);} + if(!res.success){ return obs.complete();} + obs.next(res.data); if(!withDetails){ return obs.complete(); }