From d378aea1e74dd84c4f70b99f815a7668d904150b Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Mon, 4 Nov 2024 20:07:13 +0100 Subject: [PATCH 1/2] [chore] remove "models broken" notification --- assets/jsons/translations/de.json | 4 ---- assets/jsons/translations/en.json | 4 ---- assets/jsons/translations/es.json | 4 ---- assets/jsons/translations/fr.json | 4 ---- assets/jsons/translations/ja.json | 4 ---- assets/jsons/translations/ru.json | 4 ---- assets/jsons/translations/zh-tw.json | 4 ---- assets/jsons/translations/zh.json | 4 ---- .../models-management/models-panel.component.tsx | 14 -------------- 9 files changed, 46 deletions(-) diff --git a/assets/jsons/translations/de.json b/assets/jsons/translations/de.json index d280acd0..f581d489 100644 --- a/assets/jsons/translations/de.json +++ b/assets/jsons/translations/de.json @@ -1064,10 +1064,6 @@ "go-to-mods": "Zu den Mods", "not-remind": "Nicht mehr erinnern" }, - "prevent-for-models-breaks": { - "title": "Gebrochene Modelle", - "desc": "Seit dem Update der Beat Saber Engine sind alle benutzerdefinierten Modellmods defekt und müssen aktualisiert werden. Sie wurden noch nicht aktualisiert." - }, "export-success": { "title": "Export abgeschlossen 🎉" } diff --git a/assets/jsons/translations/en.json b/assets/jsons/translations/en.json index 6bf60e2f..1bd2f7b3 100644 --- a/assets/jsons/translations/en.json +++ b/assets/jsons/translations/en.json @@ -1071,10 +1071,6 @@ "go-to-mods": "Go to mods", "not-remind": "Don't remind me" }, - "prevent-for-models-breaks": { - "title": "Broken models", - "desc": "Since the Beat Saber engine update, all custom model mods have broken and need to be updated. They have not been updated yet." - }, "export-success": { "title": "Export completed 🎉" } diff --git a/assets/jsons/translations/es.json b/assets/jsons/translations/es.json index 0ea57cbb..bd8b16af 100644 --- a/assets/jsons/translations/es.json +++ b/assets/jsons/translations/es.json @@ -1064,10 +1064,6 @@ "go-to-mods": "Ir a mods", "not-remind": "No volver a recordarme" }, - "prevent-for-models-breaks": { - "title": "Modelos rotos", - "desc": "Desde la actualización del motor de Beat Saber, todos los mods de modelos personalizados se han roto y necesitan ser actualizados. Todavía no han sido actualizados." - }, "export-success": { "title": "Exportación completada 🎉" } diff --git a/assets/jsons/translations/fr.json b/assets/jsons/translations/fr.json index 0695a01a..e6401cf0 100644 --- a/assets/jsons/translations/fr.json +++ b/assets/jsons/translations/fr.json @@ -1065,10 +1065,6 @@ "go-to-mods": "Aller aux mods", "not-remind": "Ne plus me rappeler" }, - "prevent-for-models-breaks": { - "title": "Modèles cassés", - "desc": "Depuis la mise à jour du moteur Beat Saber, tous les mods de modèles personnalisés ne sont plus fonctionnels et doivent être mis à jour. Ils n'ont pas encore été mis à jour." - }, "export-success": { "title": "Export terminé 🎉" } diff --git a/assets/jsons/translations/ja.json b/assets/jsons/translations/ja.json index eb259009..b6580a18 100644 --- a/assets/jsons/translations/ja.json +++ b/assets/jsons/translations/ja.json @@ -1064,10 +1064,6 @@ "go-to-mods": "Modインストーラーに移動", "not-remind": "二度と表示しないで" }, - "prevent-for-models-breaks": { - "title": "モデルが壊れています!", - "desc": "Beat Saberのエンジンアップデート以来、すべてのカスタムモデルのMODが壊れており、更新が必要です。まだ更新されていません。" - }, "export-success": { "title": "エクスポート完了🎉" } diff --git a/assets/jsons/translations/ru.json b/assets/jsons/translations/ru.json index 7e4c1a13..54bb3b08 100644 --- a/assets/jsons/translations/ru.json +++ b/assets/jsons/translations/ru.json @@ -1063,10 +1063,6 @@ "go-to-mods": "Перейти к модам", "not-remind": "Больше не напоминать" }, - "prevent-for-models-breaks": { - "title": "Сломанные модели", - "desc": "С момента обновления движка Beat Saber, все пользовательские модификации моделей сломались и требуют обновления. Они еще не были обновлены." - }, "export-success": { "title": "Экспорт завершен 🎉" } diff --git a/assets/jsons/translations/zh-tw.json b/assets/jsons/translations/zh-tw.json index 598bd6f1..7b4889b0 100644 --- a/assets/jsons/translations/zh-tw.json +++ b/assets/jsons/translations/zh-tw.json @@ -1064,10 +1064,6 @@ "go-to-mods": "前往 Mod 頁", "not-remind": "不再提醒我" }, - "prevent-for-models-breaks": { - "title": "已損壞的模型", - "desc": "自從Beat Saber引擎更新以來，所有自定義模型的MOD都已損壞，需要更新。它們還沒有被更新。" - }, "export-success": { "title": "導出成功 🎉" } diff --git a/assets/jsons/translations/zh.json b/assets/jsons/translations/zh.json index 3e0f263b..9f135e35 100644 --- a/assets/jsons/translations/zh.json +++ b/assets/jsons/translations/zh.json @@ -1064,10 +1064,6 @@ "go-to-mods": "前往 Mod 页", "not-remind": "不再提醒我" }, - "prevent-for-models-breaks": { - "title": "已损坏的模型", - "desc": "自从Beat Saber引擎更新以来，所有自定义模型的MOD都已损坏，需要更新。它们还没有被更新。" - }, "export-success": { "title": "导出成功 🎉" } diff --git a/src/renderer/components/models-management/models-panel.component.tsx b/src/renderer/components/models-management/models-panel.component.tsx index 1b1f96fe..32d93e4d 100644 --- a/src/renderer/components/models-management/models-panel.component.tsx +++ b/src/renderer/components/models-management/models-panel.component.tsx @@ -74,20 +74,6 @@ export function ModelsPanel({ version, isActive, goToMods }: { version?: BSVersi }); }, [isActive]); - useOnUpdate(() => { - if (!isActive || !version || lt(version.BSVersion, "1.29.4")) { - return; - } - if (config.get("not-remind-models-breaks")) { - return; - } - notification.notifyInfo({ title: "models.notifications.prevent-for-models-breaks.title", desc: "models.notifications.prevent-for-models-breaks.desc", actions: [{ id: "0", title: "models.notifications.prevent-for-mods.not-remind", cancel: true }], duration: 12_000 }).then(res => { - if (res === "0") { - config.set("not-remind-models-breaks", true); - } - }); - }, [isActive, version]); - const exportModels = () => { const selectedModels = modelsGridRefs.map(ref => ref.current?.getSelectedModels() as BsmLocalModel[]).flat(); modelsManager.exportModels(selectedModels, version); From ec09ee257c20a82646dd607ba18ebb23727c45ba Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Mon, 4 Nov 2024 20:09:31 +0100 Subject: [PATCH 2/2] [chore-640] remove unused import --- .../components/models-management/models-panel.component.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/renderer/components/models-management/models-panel.component.tsx b/src/renderer/components/models-management/models-panel.component.tsx index 32d93e4d..c43331c3 100644 --- a/src/renderer/components/models-management/models-panel.component.tsx +++ b/src/renderer/components/models-management/models-panel.component.tsx @@ -12,7 +12,6 @@ import { useOnUpdate } from "renderer/hooks/use-on-update.hook"; import { NotificationService } from "renderer/services/notification.service"; import { ConfigurationService } from "renderer/services/configuration.service"; import { useTranslation } from "renderer/hooks/use-translation.hook"; -import { lt } from "semver"; import { lastValueFrom, of, take } from "rxjs"; import { FolderLinkState } from "renderer/services/version-folder-linker.service"; import { BsContentTabItemProps } from "../shared/bs-content-tab-panel/bs-content-tab-item.component";