From 0539b0da8d648fc1625ccc0a86b852cf3181fbf6 Mon Sep 17 00:00:00 2001 From: MathieuG-P <40181755+Zagrios@users.noreply.github.com> Date: Mon, 25 Dec 2023 17:44:22 +0100 Subject: [PATCH] Revert "Handle already chosen Oculus as default download platform" This reverts commit 14036b9269284fc1aa188ea7337de9dc96181db2. --- .../components/settings/setting-radio-array.component.tsx | 8 +------- src/renderer/pages/settings-page.component.tsx | 2 +- .../services/bs-version-download/bs-downloader.service.ts | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/renderer/components/settings/setting-radio-array.component.tsx b/src/renderer/components/settings/setting-radio-array.component.tsx index c6607760..60eb44a1 100644 --- a/src/renderer/components/settings/setting-radio-array.component.tsx +++ b/src/renderer/components/settings/setting-radio-array.component.tsx @@ -18,15 +18,10 @@ export function SettingRadioArray({ id, items, selectedItemId, selectedItemVa return item.id === selectedItemId || item.value === selectedItemValue; } - const selectItem = (item: RadioItem) => { - if(item.disabled){ return; } - onItemSelected?.(item); - } - return (
{items.map(i => ( -
selectItem(i)} key={i.id} className={`py-3 w-full flex ${i.disabled ? "cursor-not-allowed" : "cursor-pointer"} ${i.disabled && "brightness-75"} justify-between items-center rounded-md px-2 transition-colors duration-200 ${isSelected(i) ? "bg-light-main-color-3 dark:bg-main-color-3" : "bg-light-main-color-1 dark:bg-main-color-1"} ${i.className}`}> +
onItemSelected(i)} key={i.id} className={`py-3 w-full flex cursor-pointer justify-between items-center rounded-md px-2 transition-colors duration-200 ${isSelected(i) ? "bg-light-main-color-3 dark:bg-main-color-3" : "bg-light-main-color-1 dark:bg-main-color-1"} ${i.className}`}>
@@ -52,5 +47,4 @@ export interface RadioItem { textIcon?: string; className?: string; value?: T; - disabled?: boolean; } diff --git a/src/renderer/pages/settings-page.component.tsx b/src/renderer/pages/settings-page.component.tsx index f813fd9a..bccd2bf6 100644 --- a/src/renderer/pages/settings-page.component.tsx +++ b/src/renderer/pages/settings-page.component.tsx @@ -235,7 +235,7 @@ export function SettingsPage() { }, - { id: 2, text: "Oculus Store (PC)", value: BsStore.OCULUS, icon: , disabled: true}, + { id: 2, text: "Oculus Store (PC)", value: BsStore.OCULUS, icon: }, { id: 0, text: t("pages.settings.steam-and-oculus.download-platform.always-ask"), value: undefined, }, ]} selectedItemValue={downloadStore} onItemSelected={handleChangeBsStore}/> diff --git a/src/renderer/services/bs-version-download/bs-downloader.service.ts b/src/renderer/services/bs-version-download/bs-downloader.service.ts index f36d1876..200a5df8 100644 --- a/src/renderer/services/bs-version-download/bs-downloader.service.ts +++ b/src/renderer/services/bs-version-download/bs-downloader.service.ts @@ -75,7 +75,7 @@ export class BsDownloaderService extends AbstractBsDownloaderService { public async downloadVersion(version: BSVersion, from?: BsStore): Promise { if(!from){ - from = this.defaultStore === BsStore.STEAM ? BsStore.STEAM : await this.chooseStoreToDownloadFrom(); + from = this.defaultStore ?? await this.chooseStoreToDownloadFrom(); } return this.getStoreDownloader(from).downloadBsVersion(version).then(() => {