mirror of
https://github.com/block/goose.git
synced 2026-07-17 12:56:20 +02:00
3b6bf2b5e5
The crossfire review (Codex + Gemini) confirmed 4 P1/P2 bugs from automated PR comments plus identified two additional gaps. Fix 1 (P1): apply_to_config fell back to the current active provider's model when switching GOOSE_PROVIDER without GOOSE_MODEL, cross- contaminating provider entries. Now reads the target provider's saved model via get_provider_entry. Fix 2 (P2): ANTHROPIC_THINKING_BUDGET was missing from GooseConfigSchema despite being the primary key read by Anthropic request construction. Fix 3 (P2): GooseConfigUpdate wrote non-secrets to config.yaml before attempting keyring secret writes. Reordered to write secrets first so a keyring failure leaves no partial config.yaml state. Fix 4 (P2): set_goose_model was a silent no-op when no active provider existed. Now falls back to writing the legacy flat GOOSE_MODEL key. Fix 5: check-config-schema now uses the --check flag instead of regenerating and diffing, avoiding workspace mutation during CI checks. Fix 6: GET/PATCH /config/typed responses now filter hidden extensions, matching the existing GET /config/extensions behavior. Signed-off-by: Will Pfleger <wpfleger@block.xyz>