From c1bd2b32e503b886e6cc7ee2c8ee78379786a097 Mon Sep 17 00:00:00 2001 From: Douwe Osinga Date: Thu, 19 Feb 2026 09:05:33 +0000 Subject: [PATCH] fix: remove redundant urlencoding::decode calls (Axum already decodes), revert config.yaml --- crates/goose-server/src/routes/local_inference.rs | 15 --------------- evals/open-model-gym/config.yaml | 4 ---- 2 files changed, 19 deletions(-) diff --git a/crates/goose-server/src/routes/local_inference.rs b/crates/goose-server/src/routes/local_inference.rs index 4bad8bbd99..5b0615e8ea 100644 --- a/crates/goose-server/src/routes/local_inference.rs +++ b/crates/goose-server/src/routes/local_inference.rs @@ -339,9 +339,6 @@ pub struct DownloadProgressResponse { pub async fn get_local_model_download_progress( Path(model_id): Path, ) -> Result, ErrorResponse> { - let model_id = urlencoding::decode(&model_id) - .map_err(|_| ErrorResponse::bad_request("Invalid model_id encoding"))? - .into_owned(); let download_id = format!("{}-model", model_id); debug!( @@ -399,9 +396,6 @@ pub async fn get_local_model_download_progress( pub async fn cancel_local_model_download( Path(model_id): Path, ) -> Result { - let model_id = urlencoding::decode(&model_id) - .map_err(|_| ErrorResponse::bad_request("Invalid model_id encoding"))? - .into_owned(); let download_id = format!("{}-model", model_id); let dm = goose::dictation::download_manager::get_download_manager(); @@ -420,9 +414,6 @@ pub async fn cancel_local_model_download( ) )] pub async fn delete_local_model(Path(model_id): Path) -> Result { - let model_id = urlencoding::decode(&model_id) - .map_err(|_| ErrorResponse::bad_request("Invalid model_id encoding"))? - .into_owned(); let local_path = { let registry = get_registry() @@ -464,9 +455,6 @@ pub async fn delete_local_model(Path(model_id): Path) -> Result, ) -> Result, ErrorResponse> { - let model_id = urlencoding::decode(&model_id) - .map_err(|_| ErrorResponse::bad_request("Invalid model_id encoding"))? - .into_owned(); let registry = get_registry() .lock() @@ -494,9 +482,6 @@ pub async fn update_model_settings( Path(model_id): Path, Json(settings): Json, ) -> Result, ErrorResponse> { - let model_id = urlencoding::decode(&model_id) - .map_err(|_| ErrorResponse::bad_request("Invalid model_id encoding"))? - .into_owned(); let mut registry = get_registry() .lock() diff --git a/evals/open-model-gym/config.yaml b/evals/open-model-gym/config.yaml index b42890a405..65b9f59cb4 100644 --- a/evals/open-model-gym/config.yaml +++ b/evals/open-model-gym/config.yaml @@ -96,8 +96,4 @@ matrix: # Multi-turn: goose and pi only (opencode doesn't support session continuation) - scenario: multi-turn-edit -<<<<<<< Updated upstream runners: [pi, goose] -======= - runners: [goose-full] ->>>>>>> Stashed changes