mirror of
https://github.com/block/goose.git
synced 2026-07-17 12:56:20 +02:00
Remove clippy too_many_lines lint and decompose long functions (#7064)
This commit is contained in:
@@ -56,7 +56,7 @@
|
||||
**Rust checks:**
|
||||
- `cargo fmt --check` - Code formatting (rustfmt)
|
||||
- `cargo test --jobs 2` - All tests
|
||||
- `./scripts/clippy-lint.sh` - Linting (clippy)
|
||||
- `cargo clippy --all-targets -- -D warnings` - Linting (clippy)
|
||||
- `just check-openapi-schema` - OpenAPI schema validation
|
||||
|
||||
**Desktop app checks:**
|
||||
@@ -76,7 +76,7 @@
|
||||
|
||||
Do not comment on:
|
||||
- **Style/formatting** - CI handles this (rustfmt, prettier)
|
||||
- **Clippy warnings** - CI handles this (clippy-lint.sh)
|
||||
- **Clippy warnings** - CI handles this (clippy)
|
||||
- **Test failures** - CI handles this (full test suite)
|
||||
- **Missing dependencies** - CI handles this (npm ci will fail)
|
||||
- **Minor naming suggestions** - unless truly confusing
|
||||
|
||||
@@ -95,7 +95,10 @@ jobs:
|
||||
# play nicely with hermit-managed rust
|
||||
hermit uninstall rustup
|
||||
export CARGO_INCREMENTAL=0
|
||||
./scripts/clippy-lint.sh
|
||||
cargo clippy --all-targets -- -D warnings
|
||||
|
||||
- name: Check for banned TLS crates
|
||||
run: ./scripts/check-no-native-tls.sh
|
||||
|
||||
openapi-schema-check:
|
||||
name: Check OpenAPI Schema is Up-to-Date
|
||||
|
||||
@@ -95,7 +95,7 @@ env:
|
||||
- [ ] cargo check
|
||||
- [ ] cargo test (affected crates)
|
||||
- [ ] cargo fmt
|
||||
- [ ] ./scripts/clippy-lint.sh
|
||||
- [ ] cargo clippy --all-targets -- -D warnings
|
||||
- [ ] Fix failures, retry up to 3 times
|
||||
|
||||
## Phase 6: Confirm (MANDATORY)
|
||||
|
||||
Reference in New Issue
Block a user