From 6879b5e5022a326d900f6628a110ee185aaa2cea Mon Sep 17 00:00:00 2001 From: Tyler Longwell Date: Fri, 26 Sep 2025 09:52:42 -0400 Subject: [PATCH] comments around why serial is required --- crates/goose/tests/moim_tests.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crates/goose/tests/moim_tests.rs b/crates/goose/tests/moim_tests.rs index 2b1e3f41a7..12a221f979 100644 --- a/crates/goose/tests/moim_tests.rs +++ b/crates/goose/tests/moim_tests.rs @@ -5,6 +5,8 @@ use mcp_core::ToolCall; use rmcp::model::Content; use serial_test::serial; +// All async tests that call inject_moim_if_enabled need #[serial] because +// that function accesses Config::global() to check if MOIM is enabled #[tokio::test] #[serial] async fn test_moim_basic_injection() { @@ -84,6 +86,7 @@ async fn test_moim_respects_tool_pairs() { } } +// This test doesn't use inject_moim_if_enabled, so doesn't need #[serial] #[test] fn test_find_safe_insertion_point_ending_with_tool_response() { // Critical test: when conversation ends with tool response, don't break the pair