From 53fdf87750d84f19428acc3a502c4e3557053433 Mon Sep 17 00:00:00 2001
From: James Loope <cronus@stolenshoe.com>
Date: Mon, 26 Jan 2026 16:48:07 -0800
Subject: [PATCH] Revert "Add SessionStorage pool tests"

This reverts commit db3d537bb0bcd70357d26dd2cc7e9dce2a0bc3cf.

Signed-off-by: James Loope <cronus@stolenshoe.com>
---
 crates/goose/src/session/session_manager.rs | 115 --------------------
 1 file changed, 115 deletions(-)

diff --git a/crates/goose/src/session/session_manager.rs b/crates/goose/src/session/session_manager.rs
index ccf02b1bb8..9bc9720afb 100644
--- a/crates/goose/src/session/session_manager.rs
+++ b/crates/goose/src/session/session_manager.rs
@@ -1557,121 +1557,6 @@ mod tests {
 
     const NUM_CONCURRENT_SESSIONS: i32 = 10;
 
-    #[tokio::test]
-    async fn session_storage_pool_uses_single_connection() {
-        let temp_dir = TempDir::new().unwrap();
-        let storage = SessionStorage::new(temp_dir.path().to_path_buf());
-        let pool = storage.pool.clone();
-
-        let mut handles = Vec::new();
-        for _ in 0..NUM_CONCURRENT_SESSIONS {
-            let pool = pool.clone();
-            handles.push(tokio::spawn(async move {
-                sqlx::query("SELECT 1").execute(&pool).await.unwrap();
-            }));
-        }
-
-        for handle in handles {
-            handle.await.unwrap();
-        }
-
-        assert_eq!(pool.size(), 1);
-    }
-
-    #[tokio::test]
-    async fn session_storage_sets_busy_timeout_to_5_seconds() {
-        let temp_dir = TempDir::new().unwrap();
-        let storage = SessionStorage::new(temp_dir.path().to_path_buf());
-
-        let pool = storage.pool().await.unwrap();
-        let timeout: i64 = sqlx::query_scalar("PRAGMA busy_timeout;")
-            .fetch_one(pool)
-            .await
-            .unwrap();
-
-        assert_eq!(timeout, 5000);
-    }
-
-    #[tokio::test]
-    async fn session_storage_sets_journal_mode_to_wal() {
-        let temp_dir = TempDir::new().unwrap();
-        let storage = SessionStorage::new(temp_dir.path().to_path_buf());
-
-        let pool = storage.pool().await.unwrap();
-        let mode: String = sqlx::query_scalar("PRAGMA journal_mode;")
-            .fetch_one(pool)
-            .await
-            .unwrap();
-
-        assert_eq!(mode.to_lowercase(), "wal");
-    }
-
-    #[tokio::test]
-    async fn session_storage_connects_lazily_with_configured_options() {
-        let temp_dir = TempDir::new().unwrap();
-        let data_dir = temp_dir.path().to_path_buf();
-        let session_dir = data_dir.join(SESSIONS_FOLDER);
-        let db_path = session_dir.join(DB_NAME);
-
-        assert!(!session_dir.exists());
-        assert!(!db_path.exists());
-
-        let storage = SessionStorage::new(data_dir);
-
-        assert!(session_dir.exists());
-        assert!(!db_path.exists());
-
-        let pool = storage.pool().await.unwrap();
-        sqlx::query("SELECT 1").execute(pool).await.unwrap();
-
-        assert!(db_path.exists());
-    }
-
-    #[tokio::test]
-    async fn session_storage_serializes_writes_avoiding_database_locked_errors() {
-        let temp_dir = TempDir::new().unwrap();
-        let storage = Arc::new(SessionStorage::create(temp_dir.path()).await.unwrap());
-
-        let session = storage
-            .create_session(
-                PathBuf::from("/tmp/test"),
-                "Lock test".to_string(),
-                SessionType::User,
-            )
-            .await
-            .unwrap();
-
-        let mut handles = Vec::new();
-        for i in 0..NUM_CONCURRENT_SESSIONS {
-            let storage = Arc::clone(&storage);
-            let session_id = session.id.clone();
-            handles.push(tokio::spawn(async move {
-                storage
-                    .add_message(
-                        &session_id,
-                        &Message {
-                            id: None,
-                            role: Role::User,
-                            created: chrono::Utc::now().timestamp_millis(),
-                            content: vec![MessageContent::text(format!("msg {}", i))],
-                            metadata: Default::default(),
-                        },
-                    )
-                    .await
-            }));
-        }
-
-        for handle in handles {
-            handle.await.unwrap().unwrap();
-        }
-
-        let session_with_messages = storage.get_session(&session.id, true).await.unwrap();
-        assert_eq!(
-            session_with_messages.message_count,
-            NUM_CONCURRENT_SESSIONS as usize
-        );
-    }
-
     #[tokio::test]
     async fn test_concurrent_session_creation() {
         let temp_dir = TempDir::new().unwrap();