From 1593b73b0a58c054668f630d5bf2dc5d0e577d9e Mon Sep 17 00:00:00 2001 From: Matt Yaple Date: Sat, 11 Oct 2025 23:11:19 +0100 Subject: [PATCH] fix: modifies openai request logic for reasoning models (#4221) (#4294) Signed-off-by: Matt Yaple --- crates/goose/src/providers/formats/openai.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/crates/goose/src/providers/formats/openai.rs b/crates/goose/src/providers/formats/openai.rs index ce9f3eb81e..cd47f4e516 100644 --- a/crates/goose/src/providers/formats/openai.rs +++ b/crates/goose/src/providers/formats/openai.rs @@ -606,10 +606,13 @@ pub fn create_request( )); } - let is_ox_model = - model_config.model_name.starts_with("o") || model_config.model_name.starts_with("gpt-5"); + let is_ox_model = model_config.model_name.starts_with("o1") + || model_config.model_name.starts_with("o2") + || model_config.model_name.starts_with("o3") + || model_config.model_name.starts_with("o4") + || model_config.model_name.starts_with("gpt-5"); - // Only extract reasoning effort for O1/O3 models + // Only extract reasoning effort for O-series models let (model_name, reasoning_effort) = if is_ox_model { let parts: Vec<&str> = model_config.model_name.split('-').collect(); let last_part = parts.last().unwrap();