Commit Graph

1701 Commits

Author SHA1 Message Date
B. Petersen f593f27d98 harden WebView settings 2021-01-29 15:25:23 +01:00
B. Petersen 74cdd85815 add pinch-to-zoom options to message-html-view 2021-01-29 15:25:23 +01:00
bjoern 8d9c02dd7a add option to view full (html) message (#1763)
* add get-mime-original apis

* remove unused control

* add 'Show full message' buttons

* split reusable WebViewActivity from LocalHelpActivity

* add FullMsgActivity

* load html via AsyncTask

* adapt to changed api

* handle mailto:-links in WebView

* block loading remote images by default, add user setting always/once/never

* do not hide 'Once' button in always-mode, playing around a day with hidden 'Once' that looks more like a bug :)

* wording: as 'Always' affects all messages, it is better to speak of multiple senders

* wording: use 'Load remote images'

this makes it easier for the user to find the option
if one sees, images are missing in the document.

* wording: shorten text.

* wording: change 'may' to 'can'. 'may' sounds a bit as if someone allows this.

* Don't use AsyncTask

* check 'once' if appropriate

* use lite-colored checkbox-emoji in dark-theme

* add comment about missing error logging

Co-authored-by: Hocuri <hocuri@gmx.de>
2021-01-28 22:53:15 +01:00
B. Petersen 3914bf7ff4 adapt to removed dc_contact_get_first_name() api
use dc_contact_get_display_name() instead
2021-01-23 19:52:23 +01:00
B. Petersen 5371f312ac remove unused isIoRunning() api
the api is about to be removed from core as well,
see https://github.com/deltachat/deltachat-core-rust/pull/2139
2021-01-15 06:49:39 +03:00
Hocuri a96aa2ff48 Show controls on small screens
Using both `setMessage()` and `setView()` on the same AlertDialog,
on small screens the "OK" and "Cancel" buttons were not be show. So, put the
message into our custom view.
2021-01-03 12:25:53 +01:00
Hocuri 1ff6a3a18d Dark theme / DayNight: Add option to follow system
fix maybe #1748. Maybe not, because actually I don't understand why
issue #1748 even happened because we don't use the system background for
the bubble but an own one (see conversation_item_sent.xml:50). Probably
the system is somehow trying to forcefully create a dark mode.

So, let's see whether this PR fixes the issue, if not, I'll try again.
2020-12-19 19:51:55 +01:00
Hocuri cfea049418 Always release the media player before setting it to 0
I can't tell if it helps, I personally was able to both play a 60min
audio and to play 32 voice messages after each other. Shouldn't hurt to
release them, though.

I tested my change, and at least it seems not to worsen anything.
2020-12-19 12:07:06 +01:00
B. Petersen f608fe0766 add missing button to new error-dialog
following common ui expectations,
there must always be at least one "ok" button
in a dialog or alert.
2020-12-14 13:16:24 +01:00
Hocuri 45aa3e5b82 Directly show error on msg tap
fix #1749
2020-12-13 18:06:44 +01:00
Hocuri 8736ac8fa9 Reset the tint if the message is not failed
Seems like in the first commit I was not careful enough: The color was
set to red, but then the view was reused in a RecyclerView and the color
stayed red. Therefore, after scrolling, more and more of the status icons got
red.
2020-12-12 17:40:44 +01:00
Hocuri 161e1d350b Red and more visible error icon
IIRC some time ago we talked about making the error icon red and make it
an exclamation mark to make it more visible.

Today someone complained to me that they thought the "x" looks like one
can close something and that it shouldn't be green, so I went ahead and
made it red :) (it's also a little bit bigger now)

- the image file is a vector (xml) file now, previously it was a png file.
Might this be a problem?
2020-12-12 16:44:52 +01:00
Hocuri 26c8497509 Fix crash on some device of some friend of Holger 2020-12-04 17:40:32 +01:00
bjoern 1cc0c9d0c1 Merge pull request #1688 from deltachat/fix-tall-images-message-width
Wider messages for tall images
2020-12-01 13:29:43 +01:00
bjoern 321e4c4dab Merge pull request #1732 from deltachat/show-in-chat
add 'show in chat' function, fix enlarge-view-menu-issues
2020-11-28 23:39:59 +01:00
bjoern 7f37d93916 Merge pull request #1744 from deltachat/quote-forwarded-msgs
display forwarded messages also in quotes as such
2020-11-27 13:05:19 +01:00
B. Petersen 12e4d6b30e introduce color 'unknown_sender' and use it for forwarded messages, forwarded quotes, quotes with unknown sender 2020-11-25 20:57:46 +01:00
B. Petersen d4ef19b9cf remove dead code 2020-11-25 10:45:41 +01:00
B. Petersen b284a70ef7 reword no-blocked-contats-hint 2020-11-22 23:06:00 +01:00
B. Petersen ed9921f40e show hint when there are no blocked contacts 2020-11-22 23:06:00 +01:00
B. Petersen 68961fdcd7 remove unused SwipeRefreshLayout and use self-explaining default for contact-list-empty-hint 2020-11-22 22:16:13 +01:00
Hocuri 0f2c3f4791 Remove rounded corners if the message has a quote 2020-11-21 17:19:20 +01:00
B. Petersen 783168549a open correct tab 2020-11-20 13:20:39 +01:00
B. Petersen f8dba0f2d5 fix backstack for 'all media' option
- when called from gallery, this is just the same as 'back'

- otherwise, do not forget to remove self
2020-11-20 13:20:38 +01:00
B. Petersen 658c3af66b add 'show in chat' function 2020-11-20 13:20:38 +01:00
B. Petersen 8853e320c0 remove 'forward' from gallery
- it forwards media together with the text,
  this is unexpected
- if forward is available, reply and reply-privately
  should be available as well, however, this seems to be a bit much.
- the function had issues which would need fixing.

instead, we will add a 'Show in chat' function that is more powerful
and fixes all of the things above.
2020-11-20 13:19:54 +01:00
B. Petersen 8e185e4f26 show permanent hint about server-delete impact
when server-deletion is enabled,
always show a hint about the impact below the option.

the hint is a summary of the conformation-dialog
so that the user is more aware of the impact
if enabling was some time ago
or the option was even enabled by the provider-db.
2020-11-18 21:54:39 +01:00
Hocuri 9beff06fb1 Fix #1726 2020-11-12 14:28:04 +01:00
bjoern 710f0195f4 Merge pull request #1720 from deltachat/quotes-add-on-3
Quotes add on 3
2020-11-09 12:55:53 +01:00
B. Petersen 0cbf31b18a do not use cached value to check for notifications
the 'inboxes' value contains the last lines of notification,
however, if the app is restarted for whatever reasons,
but notifications are persisted,
they do not contain all lines.

for the notification display, this is no big deal,
however, this cached value is not suitable
to check if there is a notification or not for a chat.

even if there is a notification, 'inboxes' may be empty,
this 'speed up' check was introduced
for a workaround of notification removal that requires lots of calls.
meanwhile, however, we have DC_EVENT_MSGS_NOTICED,
so we also remove this workaround.
2020-11-09 01:04:08 +01:00
Hocuri 778718c7b2 Don't cut the document icon in quotes
I also deleted an unnecessary LinearLayout, so you should look at the
diff with --ignore-all-space

Firstly, I lifted quote_attachment_container out of the FrameLayout with
the thumbnail so that quote_attachment_container can be wrap_content
(and enlarge the quote if necessary) while the thumbnail still always
matches the size of the quote.

Then I made the document view itself a little smaller so it does not
enlarge the quote all the times.
2020-11-08 12:55:38 +01:00
Hocuri 90af180ce4 Make the quote animation faster
IIRC it was complained about this in the Testing group and I agree
2020-11-08 12:29:38 +01:00
Hocuri 09e890f443 Keyboard correctly closes when it is open and a quote to another chat is clicked
Reported by Treefit
2020-11-08 11:43:23 +01:00
B. Petersen 488d25a97b add link to upcoming blogpost 2020-11-05 23:58:41 +01:00
bjoern 4f58a4986f device-message translations (#1713)
* update translations, esp. device message translations

* update translations
2020-11-05 20:42:17 +01:00
bjoern 3a50bf05d1 Merge pull request #1710 from deltachat/fix-another-crash
Fix crash in ImageEditor
2020-11-05 19:41:17 +01:00
Hocuri ab77b61d35 Do not display milliseconds when recording a voice message fix #1711 2020-11-04 09:34:54 +01:00
Hocuri 485bfce7b4 Fix crash
For some reason it is not possible to remove `setUri`, when I tried, I
got crashes each time I tried to edit an image.
2020-11-03 19:25:50 +01:00
B. Petersen a1e7388f95 disable forwarding info-messages
i cannot see a usecase for forwarding info-messages as "member added",
so it might also confuse users when the option is offered at all.

as all selected messages are loaded into memory anyway,
this was easy to implement.

tbh, if we would track the selection by message-ids only and
this would have require a larger refactoring or performace issues
(imaging 100 messages to be checked on each new selected message),
i would not have implemented that now :)

i do not think, that sensitive information can be send accidentially this way,
even if Bob can forward an info-message as "Alice invited Claire" -
it is pretty clear to Bob that he forwards exactly that text.
(this is different from adding "Honey" to the group -
where "Honey" is an only locally given name for "Dr. Someone" ;)
2020-11-03 11:04:02 +01:00
B. Petersen 8e724e8a76 update changelog, add device message for 1.14 2020-11-01 01:24:58 +01:00
Hocuri eaa891c8e7 Properly fix the problem 2020-10-31 18:34:50 +01:00
Hocuri 766d50e602 Prevent exception (would be caught but is annoying) 2020-10-31 18:31:14 +01:00
Hocuri 582836bf9a show portrait images cutted to landscape (as now), use square only if the whole device is in portrait mode
that's waaaay less difficult to implement
2020-10-28 17:19:35 +01:00
Hocuri 8a1174b1cf try to do not use the full width for the bubbles (for the text) in device-landscape-mode - this way, also the squares will maybe be small enough. at a first glance this is what whatsapp is doing
Not working as sometimes the ConversationItem would have to determine
the width (i.e. the screen width), sometimes the
ConversationItemThumbnail. Not sure if it's worth it fixing this.
2020-10-28 17:09:20 +01:00
Hocuri 4d6fcf6d46 First half of Björn's review 2020-10-26 20:16:45 +01:00
Hocuri df0196a7cf Wider messages for tall images 2020-10-26 17:21:04 +01:00
B. Petersen 5cbfd8cdb8 disallow muting saved-messages, there are no notifications for saved-messages 2020-10-26 13:38:30 +01:00
B. Petersen 2f68096b22 hide settings-tab in device-chat 2020-10-26 13:38:30 +01:00
B. Petersen 93de0032e4 hide 'edit', 'block' and 'encrytion info' for device-chat and 'edit' for saved-messages 2020-10-26 13:38:29 +01:00
B. Petersen 7773f2ac79 disable 'disappearing messages' when a chat is not sendable; this is currently the device-chat, but may be others in the future 2020-10-25 01:09:56 +02:00