Commit Graph

1877 Commits

Author SHA1 Message Date
bjoern beb601bc06 do not download large messages automatically (#2045)
* add download-ffi methods

* add 'Download' button for incomplete messages

* show 'downloading' animation

* make download_limit configurable

* set button to 'disabled' and text to 'Downloading...' on downloading; color does not really reflect that yet, but that can probably be tweaked by xml

* make 'download message body' translatable
2021-09-13 23:07:49 +02:00
Asiel Díaz Benítez c4f7a72493 allow to export all selected attachments (#2048)
* allow to export more than one attachment

* tweak strings
2021-09-06 23:31:52 +02:00
bjoern 5b937b5653 profile: show tab containing 'status' for device chat (#2039)
the device chat's status contains some useful information
since https://github.com/deltachat/deltachat-core-rust/pull/2613 -
unfortunately, the whole tab was hidden on android.

ios and desktop should be fine in this regard.
2021-08-20 22:56:28 +02:00
bjoern ed1b363d70 add device message for 1.22 (#2036)
* add device message for 1.22

* adapt 1.22 device message for ios, for desktop, update_1_22 could fit (or we can add another later)
2021-08-20 17:58:27 +02:00
Hocuri 1222e6fc90 Remove RequiresApi(19) annotation on ScribbleActivity (#2033)
These annotations don't actually have an effect, but they lead to an
error (not a warning) being shown in Android Studio. It still compiles
fine, though.

The line `case ScribbleActivity.SCRIBBLE_REQUEST_CODE:` in
ConversationActivity was therefore shown as an error all the time, which
was really annoying.

The alternative would be to suppress the error in ConversationActivity.
2021-08-17 23:15:11 +02:00
bjoern a08f8ed527 hide 'search' option in connectivity view (#2035)
it is currently just not needed for a dialog-style html-page,
but raises the question what can be searched here.

if it turns out a search function becomes useful,
we can easily re-add it.
2021-08-17 23:12:53 +02:00
Hocuri e2b2d6bea4 [WIP] Fix "Can't edit shared image" (#2034)
Fix #2032

The problem was that after returning from the image editor, `doReinitializeDraft` was true and therefore we the draft was reinitialized to the originally shared, unedited image.

This was introduced in
https://github.com/deltachat/deltachat-android/pull/1770. I im pretty
sure that what I changed is fine, but we had so many regressions in the
past in this area that we should thoroughly test this change before
merging.

I extended
https://github.com/deltachat/interface/edit/master/user-testing/mailto-links.md
a bit; before merging this PR we should test that everything there still
works.
2021-08-16 12:39:58 +02:00
Asiel Díaz Benítez ffd58739ed Merge pull request #2027 from deltachat/adb-issue-1992
reload adapter's dcChat when chat is modified
2021-08-12 15:05:30 -04:00
Hocuri b8cbc6d3b0 Add some @NonNull annotations, remove unused method (#2028)
This was in an attempt to find the cause for #2026. I didn't succeed,
but this is an improvement, anyway.
2021-08-11 23:13:12 +02:00
Hocuri f7b74e4963 Add simple benchmark & a test framework (#2022)
See #2019, #2020 and #2021 for failed attempts at using a benchmark framework. So, for now I'll just go with timing the results manually. 

For trying this out:
- Backup your current account first, maybe there are some bugs in switching accounts.
- You can run benchmarks on either an emulated device or a real device. For better benchmark results, you should run the benchmark on a real device and make sure that the core is compiled in release mode.
- Disable animations on your device, otherwise the test may fail. (Developer options -> Window animation scale, Transition animation scale & Animatior duration scale -> set all three of them to 0x)
- In Android Studio: File -> Sync project with gradle files
- In Android Studio: Run -> Edit configurations -> `+` -> Android Instrumented test -> Either select a specific class or select "All in Module" -> OK -> Select your configuration in the toolbar -> Click on the green "run" button in the toolbar to run the tests

When the benchmark is done, you will get a result like `MEASURED RESULTS (Benchmark) - Going thorough all 10 chats: 11635,11207,11363,11352,11279,11183,11137,11145,11032,11057`, Paste `11635,11207,11363,11352,11279,11183,11137,11145,11032,11057` into a cell in a LibreOffice spreadsheet, do `Data -> Text to columns`, choose `,` as a separator, hit `OK`, and create a diagram.
2021-08-11 14:01:15 +02:00
adbenitez 3327812628 reload adapter's dcChat when chat is modified 2021-08-10 23:08:12 -04:00
Hocuri 44ffbdbb58 Fix: When searching, entering an archived chat, and going back, go back to search (#2025)
Steps to reproduce the bug:
- Search and select an archived chat
- Press back

Expected: Go back to the search activity.
Actual: Go to the Archived chats list activity. The user has to press
"back" again to get to the search.
2021-08-10 17:06:05 +02:00
Hocuri 5952f30334 Fix: When returning to chat after blocking it, hide request buttons (#2023)
Steps to reproduce the bug:

- Go to a contact request
- Go to the profile
- Block the contact
- Press back

Expected behavior: Only the compose panel is shown, not the request
buttons.
Actual behavior: Both the panel and the request buttons are shown
because the panel visibility is updated, but not the request button's.

I fixed this by always calling `initializeContactRequest()` after
`setComposePanelVisibility()`.
2021-08-10 17:05:43 +02:00
Hocuri 93d9a84cae Fix: When blocking a contact from the profile, update the chatlist (#2024)
Steps to reproduce:

- Go to the profile of a contact
- Block the contact
- Press back twice

Expected behavior: The chat is not shown in the list anymore.
Actual behavior: The chat is shown in the list until the app is
restarted (or if you wait some time)
2021-08-10 17:05:30 +02:00
bjoern 1c36190c87 validate email-addresses in core (#2015)
successor of #1980,
allowing to add contacts with dotless email-domains to groups;
that is needed eg. for @yggmail
2021-08-08 22:05:34 +02:00
bjoern 726f751cac keep selection when migrating several accounts (#2011)
postpone selection after the last migration
as migrateAccount() currently selects the migrated account.

before, the selectAccount() call was useless
if another migrateAccount() call follows.
2021-08-04 15:05:45 +02:00
Asiel Díaz Benítez 9be90a589e avoid NullPointerException (#2013) 2021-08-04 15:05:33 +02:00
Asiel Díaz Benítez 099f76a90b set dynamic theme in welcome activity (#2008) 2021-08-02 00:20:34 +02:00
Asiel Díaz Benítez 13dbb3f87c avoid showing compose panel when pressing block button (#2004)
* stop observing DC_EVENT_CONTACTS_CHANGED events before blocking chat so the input bar is not made visible in handleEvent()

* add comment about removing DC_EVENT_CONTACTS_CHANGED observer on blocking

Co-authored-by: B. Petersen <r10s@b44t.com>
2021-08-01 23:29:22 +02:00
Asiel Díaz Benítez 464c30129f update archived chatlist when contact request is blocked, set intent so conversationListFragment can find RELOAD_LIST in extras (#2003) 2021-08-01 22:26:19 +02:00
Asiel Díaz Benítez 6bd46a8532 Merge pull request #1985 from deltachat/use-accounts-api
use dc_accounts_t
2021-07-31 16:19:33 -04:00
bjoern 06353ef64d fix potential race condition in chatlist loading (#2001)
this should fix the race condition mentioned at #2000
and in the source code by synchronizing getters/setters of the booleans.
2021-07-31 21:24:20 +02:00
bjoern 6de566ac11 fix chatlist anr (#2000)
* revert unneeded changed introduced at #1975 - the timer is to update relative timestamps, data reloading is not needed and driven by events

* load chatlist async

* debounce chatlist loading

* add comment to the code
2021-07-31 13:56:39 +02:00
Asiel Díaz Benítez 72acc5fffc separate request and archive badges (#1997) 2021-07-30 12:43:10 +02:00
bjoern a7d6dda1a3 hide question from request panel for now (#1996)
* hide question from request panel for now, if needed we can do something more specific in the future

* remove 'Done' toast to avoid problems with lost activity

for whatever reason,
i just got a crash related to the toast that could not find its activity,
probably we should have used the app context and not the activity.

however, the toast was annoying me already,
there is no point in adding it, the change is visible instantly to the user
on the screen.
2021-07-29 23:36:16 +02:00
bjoern 2e9f7e58f2 tweak 'Archived Chats' and 'Requests' (#1991)
* add 'Archived Chats' menu entry

the menu entry is at the place where the 'Contact Requests' were before -
that way, ppl may find existing contact requests easier.

moreover, it is now possible to access 'Archived Chats'
without endless scrolling ;)

* for archived requests, show both tags

* show a hint when 'Archived Chats' is empty

* contact requests do not display unread count; do not retrieve it and do not show text in bold
2021-07-29 10:18:51 +02:00
bjoern 6d8da07409 Update src/org/thoughtcrime/securesms/connect/AccountManager.java
Co-authored-by: Hocuri <hocuri@gmx.de>
2021-07-28 16:53:03 +02:00
bjoern a6490bf4cb Update src/org/thoughtcrime/securesms/connect/AccountManager.java
Co-authored-by: Hocuri <hocuri@gmx.de>
2021-07-28 16:52:54 +02:00
B. Petersen 1c4b06c501 int can't be @Nullable 2021-07-28 16:44:28 +02:00
B. Petersen c94ec36814 remove superfluous string (that change was lost during rebase) 2021-07-27 00:17:16 +02:00
B. Petersen 7959053429 process events belonging to current context only 2021-07-26 21:37:33 +02:00
B. Petersen 0f7984442a adapt AccountsManager to DcAccounts 2021-07-26 21:37:32 +02:00
B. Petersen 634c8d1e49 use accounts event emitter 2021-07-26 21:37:32 +02:00
B. Petersen 78cd6cd8e8 create DcAccounts object on startup, migrate existing accounts 2021-07-26 21:37:32 +02:00
B. Petersen c661cc8385 remove unneeded declarations of ApplicationDcContext 2021-07-26 21:37:32 +02:00
B. Petersen 1d9a6375be always get DcContext via DcHelper 2021-07-26 18:41:42 +02:00
B. Petersen b28a62a1ea remove functions from subclassed DcContext
the functions were part of ApplicationDcContext for no special reason,
however, now standing in the way of avoiding subclassing DcContext
(to use the DcContext objects returned from DcAccounts directly).
2021-07-26 18:41:42 +02:00
B. Petersen 4c679053b9 add dc_accounts_t api to JNI 2021-07-26 18:37:49 +02:00
Hocuri f941fd3c53 Remove Deaddrop chat (Android UI) (#1975)
See deltachat/deltachat-core-rust#2514

Fixes #1963
Fixes #1890

Before deleting a chat the user is asked for confirmation. Before blocking not, because blocking is not "destructive" (i.e. can be completely reverted by unblocking the contact). I'm wondering whether we should show a snackbar with an Undo button though, but we can probably wait for user feedback on this.

* Start removing deaddrop chat

* Generally works

* Fix the buttons

(it's not easy to not show one of the buttons in
ConstraintLayout; if problems turn up, we should probably
just not use ConstraintLayout)

* fix more things

* restartLoader() instead of notifyDataSetChanged() because the latter didn't do anything

* Archived badge

* Rename "Contact request" to "Request"

* oops

* Remove setStockTranslation(8, context.getString(R.string.chat_contact_request));

* Remove commented-out code, we probably won't need it

* Don't show "Delete" button for 1:1 chats

* Get rid of short flickering when declining a request

* Set the app's night mode to match the preference

This added 6ms to startup time, but I think that's OK, as
we will also be able to use more `-night` views in the future

* Make "Accept" text a bit brighter and easier to read in dark mode

* Check if the chattype is Group instead of members.length == 1
2021-07-26 13:01:59 +02:00
Hocuri 79cad60b8f Speedup first-time app load a bit (#1988)
I couldn't measure whether the app actually loads faster, as it varies a
lot (3.5s-4.5s on my device), but I could see that `getInstance()`
doesn't need 100ms-300ms on the main thread anymore.
2021-07-26 10:44:07 +02:00
Hocuri b1db770f5f Speedup returning to chatlist a bit (#1987)
When working on
https://github.com/deltachat/deltachat-android/pull/1975, I noticed that
synchronisation takes quite some time here
2021-07-25 09:17:24 +02:00
bjoern 3cbaafb437 use 'Updating…' instead of 'Getting new messages…' (#1984)
- 'Getting new messages…' is not always fitting,
  the messages may be old or they are not visible as messags at all
  (read receipts, setup-contact, sync).
  'Updating…' is better fitting here.

- 'Getting new messages…' is a bit too long and results in
  linebreaks on smaller devices.
2021-07-23 08:27:57 +02:00
adbenitez 5e93b89ff4 add yggmail support: allow dotless email address and localhost domain 2021-07-21 02:09:56 -04:00
Asiel Díaz Benítez 1f23a5ad1b Merge pull request #1970 from deltachat/set-clipboard-with-utils
avoid code duplication, use Utils.writeTextToClipboard() everywhere
2021-07-19 12:43:50 -04:00
Asiel Díaz Benítez 214f11a62f Merge pull request #1968 from deltachat/adb-issue-1967
avoid NullPointerException in DcMsg.msgSetToIds()
2021-07-15 18:02:57 -04:00
Asiel Díaz Benítez f0290649f4 Update src/com/b44t/messenger/DcMsg.java
Co-authored-by: bjoern <r10s@b44t.com>
2021-07-15 17:56:10 -04:00
Asiel Díaz Benítez 4dce3734ff apply app/system theme to WebView (#1972) 2021-07-15 16:46:09 +02:00
Hocuri 7ad227f789 Hide unnecessary controls if you can't send (#1951)
- Imediately hide the compose panel when you left the group and
EVENT_CHAT_CHANGED was sent
- Hide the "Leave" button if you are not a member of a group. I solved
this by checking `canSend()`; I could also have checked
`dc_is_contact_in_chat(CONTACT_ID_SELF)`, but this would be more
complexity for now.

  When we add the possibility to leave mailing lists, the core will have
  to explicitly tell the UI whether it's possible to leave a chat, but
  that's not for now.
2021-07-15 13:25:11 +02:00
bjoern 466697c976 allow withdrawing and reviving qr codes, add corresponding strings (#1965)
the code-part of this pr is pretty simple, most work was already done in core at deltachat/deltachat-core-rust#2512

* add DC_QR_{WITHDRAW|REVIVE}_VERIFY{CONTACT|GROUP} constants

* ask to withdraw/revive qr codes

* reword redraw hints, fix typos

* reword revive statement

* Update res/values/strings.xml: Add "by others"

* Apply suggestions from comradekingu's code review

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
Co-authored-by: Hocuri <hocuri@gmx.de>
Co-authored-by: Allan Nordhøy <epost@anotheragency.no>
2021-07-14 17:46:20 +02:00
adbenitez d455526ca4 avoid code duplication, use Utils.writeTextToClipboard() everywhere 2021-07-08 20:25:17 -04:00