Commit Graph

1750 Commits

Author SHA1 Message Date
B. Petersen 65e3d85c9e show show_emails state in settings summary 2021-04-06 02:05:56 +02:00
B. Petersen 6dac8c4989 remove device message for now, we will add a fresh one for the final release 2021-04-04 21:17:30 +02:00
Hocuri 3ec78953fa Bugfix: open images in the media preview again
Since #1834, images were not opened in the media preview again but
opened with an external app.

This was because since #1834, only slides that return true on
`hasImage()` are shown in the media preview, i.e. gifs, images and
videos.

Now, the problem was that images were shown as DocumentSlides under
some circumstances, which return `false` for `hasImage()` (naturally).
2021-03-16 17:50:12 +01:00
Hocuri 4c0d03772d Better profile and group picture selection by using attachment selector (#1837)
fix #1836

AvatarSelector is mostly copied from AttachmentTypeSelector. I first started to make it a subclass, but there were so many functions that had to be changed that I decided against it (esp. also the constructor, so I would have had to create another constructor to allow AvatarSelector to bypass the "normal" constructor). Could still be done though, of course.

I think (hope joy) that the commits are clear enough that this can be reviewed commit-by-commit. In the first commit, commenting out code means "Moved somewhere else"

I found it easier to look at the first commit using gitk than GitHub as GitHub doesn't show it as copied from AttachmentTypeSelector but as a new file. (of course you can also just review normally, going throug it file-by-file :)

* Don't show remove button if there is no image yet

* Remove unnecessary animation that just made things look worse

* Delete now-unused ClearProfileAvatarActivity

* For groups, also use the attachment-chooser-dialog

* Remove confirmation dialog for removing avatar (The user has to confirm anyway, and this was not correctly translated)
2021-03-16 11:58:44 +01:00
Hocuri ce8ff61a37 Don't open media preview for attachments with file viewtype (#1834)
fix #1816

The problem was:
- as @link2xt already wrote, the onclick listener only checks if the mime type is `image/` or `video/`.
- then `PagingMediaLoader` loads all images and videos of the current chat with `context.getChatMedia(msg.getChatId(), DcMsg.DC_MSG_IMAGE, DcMsg.DC_MSG_GIF, DcMsg.DC_MSG_VIDEO)`. We need _all_ images so that the user can swipe back and forth.
- The correct image to be shown can't be found, the MediaPreview is opened anyway. As the correct image can't be shown, the first image in the chat is shown.
2021-03-14 19:23:51 +01:00
adbenitez 7b6f1bd507 add lock recording feature 2021-03-14 15:28:23 +01:00
Hocuri c1b4e57b9e Don't open media preview for attachments with file viewtype
fix #1816
2021-03-14 14:48:05 +01:00
Hocuri 6b3adf4831 Don't use the diskette icon for export attachment at all 2021-03-13 18:56:26 +01:00
Hocuri bf86badb1c Allow to share media from Delta Chat 2021-03-13 18:56:26 +01:00
Asiel Díaz Benítez beee60d6a7 implement sticker visualization (#1823)
Sticker picker is not implemented, just receiving(from DC Desktop, bots or future DC versions) and forwarding stickers
(code adapted from Signal)
2021-03-10 10:55:50 +01:00
B. Petersen 8589f8652b pass through unused clicks 2021-03-09 01:59:17 +01:00
B. Petersen df7e0aaa2e make links work 2021-03-09 01:59:17 +01:00
B. Petersen e54d07fd15 linkify status messages, move linkify to EmojiTextView for that purpose 2021-03-09 01:59:17 +01:00
B. Petersen dde3a49db3 add status field to profile 2021-03-09 01:59:17 +01:00
B. Petersen 2c8bd39cd2 move email-address to subtitle, this is a unique element also used at other places; copy-to-clipboard goes to the menu 2021-03-09 01:59:17 +01:00
B. Petersen 4901d7c68f add getStatus() api 2021-03-09 01:59:17 +01:00
B. Petersen 0390d845e5 cleanup 2021-03-09 01:59:17 +01:00
Hocuri 720f553717 Make the upper back button return to conversation list even if the keyboard is open
As discussed in the Testing group
2021-03-08 14:21:22 +01:00
Hocuri f6a5a24165 Use the message subject as the full-msg-view title
For long subject it's ellipsized (`…`) now, but I think that there is no need to show the full subject somewhere, it usually doesn't contain _that_ important information and can be seen in full in the normal chat view
2021-03-07 17:40:22 +01:00
B. Petersen 6b3caad278 add selected language and rtl to log 2021-03-05 17:30:00 +01:00
B. Petersen c99a1809a1 mark overridden senders in quotes
if the original author of a quote is shown
and known to be overridden,
that should be marked with the character '~'
as for the normal names,
esp. as they are look very similar otherwise,
eg. also bold, also colored.
the missing '~' looks like a bug here.

successor of #1808
2021-03-05 16:46:58 +01:00
Hocuri 5b877ff82a Delete lots of unused code 2021-03-05 16:27:33 +01:00
Hocuri bb4272de9f Fix the image-is-cropped-too-much-bug
fix  #1797

Apparently, we ran into a bug similar to the one described in
https://github.com/bumptech/glide/issues/613#issuecomment-144762087 as
we cropped twice (in addition to the cropping I removed, we also set
`android:scaleType="centerCrop"` in `thumbnail_view.xml`)
2021-03-05 16:27:33 +01:00
B. Petersen 23dedb5a24 remove Android-specific DcContact.getArgbColor() from bindings 2021-03-05 11:28:33 +01:00
B. Petersen 113a6c8f75 remove DcEventCenter from wrapper as it belongs to *.connect 2021-03-05 11:28:33 +01:00
B. Petersen 76ae58a6b3 remove Android references from wrapper and make it standalone usable 2021-03-05 11:28:33 +01:00
Hocuri 84313bdf4f Call stop_io()/start_io() before/after backup export
should ideally be merged before https://github.com/deltachat/deltachat-core-rust/pull/2255, but that's not too important

I tested key import/export and backup import/export, all work fine.
2021-03-01 14:10:53 +01:00
bjoern 05287b50bf remove dead code (#1820)
the number of blocked contacts is just the size of the array returned by getBlockedContacts()
2021-02-22 16:24:49 +01:00
cyBerta 997040d5d6 Merge pull request #1792 from deltachat/emojis_on_map
show emojis on map
2021-02-17 21:27:14 +01:00
cyberta 80ca47fb91 emoji bitmap size depends on passed scale parameter 2021-02-16 13:13:47 +01:00
cyberta 5a5abaffe4 adapt indentation 2021-02-15 22:32:31 +01:00
cyberta 4064f3a30b Don't use AsyncTask class to generate emoji bitmaps, it's deprecated now. Pass emoji scaling factor instead of hard-coding it 2021-02-15 20:04:40 +01:00
cyberta cae1c82a7f avoid that POI emoji icon disappears if info window appears 2021-02-15 16:03:35 +01:00
cyberta ac88aa2419 rename parameter to contextualize input in DataCollectionTask 2021-02-15 14:40:31 +01:00
cyberta 363d92cedb make reference to running collection tasks thread safe 2021-02-15 14:40:31 +01:00
cyberta d68095eca7 show emojis on map 2021-02-15 14:40:31 +01:00
cyberta 9b42940dea handle null location more gracefully 2021-02-15 12:08:13 +01:00
cyberta c17e7f87a7 don't use cached first location fixes that are older than 2 minutes 2021-02-15 12:02:01 +01:00
B. Petersen 95b605e331 mark overridden names by a "~" in the bubbles
this is just a very simple approach to move forward.

to mark overridden names, a "~" is prefixed.

the idea with using a dedicated color for these names:
as we do not really know
if the address is a generic sender address or belongs to the user,
it makes sense to keep the color used for the name and do not use a
dedicated grey or so.

i think, it is not even worth to detect that better:
it is pretty nice to have senders in mailinglist marked nicely,
all the time.

currently, the "~" is only added to the bubbles - it is not there
in the chatlist-summary (that would needed to be done in core)
and also not in forwarded by, notifications, clipboard etc. i'd say currently,
this is not needed, however, with the current approach it would be doable
(if we mark possible impersonation by colors or icons that may be
much more complicated)

adaption on other uis would also be pretty simple with this approach,
and imho, this `~Max Mustermann` looks pretty nicely
and even intuitive in a way.

drawback of the approach is that user may user `~`
as the first character of their names, we could target that by
adapting dc_msg_get_displayname() in the core, if we want to keep this approach,
however, maybe it is also not worth, the "~" is more a flaw than a feature,
also that would result to "~~Name" in the bubbles.
i do not see how that can be used to trick users when beeing added.
names as "foo 🔒" might be more dangerous here, when it comes to trick users.
2021-02-14 22:52:33 +01:00
Hocuri 3b8f3e7628 Show the correct sender name in mailing list messages 2021-02-10 21:33:18 +01:00
B. Petersen 097da7c165 show name of forwarded in groups, keep title of forwarded messages in grey 2021-02-10 15:50:10 +01:00
bjoern c814885f5c mailinglists3 (#1781)
* Adapt to mailing lists

* Change the question if this is a mailing list (untested)

* rm unused fn

* Adapt to getSenderName -> getOverrideSenderName (untested)

* Use dc_msg_get_sender_first_name() because sometimes the first name was not correctly shown in mailing lists

* Don't let the user modify mailing list groups

* Fix crash

* Make Unnamed newsletter translatable, make the subtitle of mailing lists "Mailing list"

* tweak and hide some controls for mailing lists

* Update src/com/b44t/messenger/DcChat.java

Co-authored-by: bjoern <r10s@b44t.com>

* adapt to new dc_msg_get_real_chat() api, remove dc_msg_get_sender_first_name()

* remove now dead code

* add mailing list name to contact-request-question

move question-creation to a helper class
to avoid duplicated code.

* fix DcMsg.getOverrideSenderName()

* adapt to new dc_decide_on_contact_request() api

* re-allow changing name+image for mailinglists, see recent discussions on PRs

* remove memberlist- and settings-tab from mailinglist profile until there is some use for them

* adapt to new DC_CHAT_TYPE_MAILINGLIST type

Co-authored-by: Hocuri <hocuri@gmx.de>
2021-02-07 23:39:48 +01:00
B. Petersen 9f2be9c56c use dc_get_chat_encr_info() where useful 2021-02-07 20:32:51 +01:00
B. Petersen 44b0739f6c make profile-menu easier editable, show 'Encryption' item also in groups 2021-02-07 20:32:51 +01:00
Hocuri b645dc60a0 Improve performance and make sure that there is no race condition
add a static boolean doReinitializeDraft that is set to true in onPause() if this activity was started using startActivityForResult(). in onResume(), do if(doReinitializeDraft) { initializeDraft(); }.
2021-02-05 22:32:50 +01:00
Hocuri cd5f0c212c Fix disappearing drafts
Some people reported that drafts were disappearing, and I found a way to
reproduce it (my interpretation in brackets):
- Open Saved Messages chat, could be any other chat too
- Go to another app and share to DC
- In DC select Saved Messages
  - (as sharing is done using startActivityForResult(), a second
  ConversationActivity is created without affecting the existing one)
- Leave DC. (The second ConversationActivity will correctly save its
draft to the db)
- Open DC again from the "Recent apps". (The first ConversationActivity
will be loaded. It will not know that there is a newer draft and still
show the old draft, or nothing if there was none. When it's closed, it
will overwrite the draft)

I came to this conclusion by logging all writes to the draft in the db.
Also, when I set `REQUEST_RELAY` to -1 (`startActivityForResult(intent,
-1) will behave the same as `startActivity(intent)`) (but that's not a
solution, sometimes we need startActivityForResult(), see e.g.
https://github.com/deltachat/deltachat-android/pull/1412)

What's still a little weird: I tried replacing all calls to
`startActivityForResult(-intent for ConversationActivity-)` with
startActivity(), and the issue didn't go away. Apparently it's only
enough if all calls are replaced, which is the same as setting
`REQUEST_RELAY` to -1. Maybe it's enough if one activity in the call
chain is called using startActivityForResult().

The call to `initializeDraft()` makes the activity start & resume 2-3ms
slower, which is probably acceptable.

While going back and forth with activities & sharing, I also encountered
some more bugs (without trying to reproduce them), but they are not too
annoying (as opposed to losing your draft) and I'm hesitant to changing
the activity-switching logic too much as it is so easy to just break
things again.
2021-02-05 22:32:50 +01:00
link2xt 9e610e5d4b Replace 4 weeks option with 5 weeks option
While 4 weeks always fits in a month,
5 weeks (35 days) always covers at least a month,
so it can be used in a situation where messages are required to
be stored for a month.
2021-02-03 13:34:05 +03:00
B. Petersen 90bb1eb559 add comments on ephemeral-timer-indexes 2021-01-31 00:45:13 +03:00
link2xt f155757cee Change list of ephemeral message options
Also match unknown options to some known option, not "disabled".
2021-01-31 00:45:13 +03:00
B. Petersen f593f27d98 harden WebView settings 2021-01-29 15:25:23 +01:00