Commit Graph

1226 Commits

Author SHA1 Message Date
B. Petersen b0641a49c3 change default for 'reliable background service' to false
reason is that ppl are pretty annoyed by the
permanant notification, that might have been expected and that would be okay.
but, more worse, for whatever reasons, this drains more battery on some systems
than having just "allow consuming battery" enabled,
maybe some system do not go to doze mode because of the permantent-notification.

anyway, to avoid initial annoyances, we switch back to
- asking the user to "allow consuming battery"
- having a 15 mintues or so polling interval (as on iOS)

but, in contrast to 1.3, we now still have the _option_ to
enable a permantent-notification that user can enabled if everything else
described at https://dontkillmyapp.com does not work.

the "smart" permantent notification from 1.3,
that are only shown under some circumstances, however, are gone.
they are not realiable, eg. we did not use them when "consume battery"
was enabled - which is not sufficient on various "modern" systems.
but the main reason is that _if_ the user enables a permantent notification,
this can also be regarded as a hint that things are up and running.
2020-05-11 01:11:22 +02:00
cyberta 7941fb8172 remove comment 2020-05-06 14:04:14 +02:00
Hocuri 51a443a184 Fix #1305 An object (image), "shared" to Delta Chat once, appears again forever in Chat editors until app is closed
The problem was that the intent still had the share flag and data.

A draft is now initialized (and stays) so that the user can return to sending later.
2020-05-06 13:58:16 +02:00
cyBerta 4b200fab63 Merge pull request #1339 from deltachat/media-quality
use media-quality-option from core
2020-05-06 12:50:34 +02:00
cyBerta 4f7236268d Merge pull request #1277 from deltachat/notifyswipednotread
Fix #999 swiping a notification away should not mark things as "noticed"
2020-05-05 18:46:43 +02:00
B. Petersen ea0653e89a use string-constant 2020-05-04 18:08:14 +02:00
B. Petersen eee1f35b99 migrate pref_compression to media_quality 2020-05-04 17:24:19 +02:00
B. Petersen 8659a23a11 use new media_quality core-config-value 2020-05-04 17:24:19 +02:00
B. Petersen f4cc86055c make sure, dc_add_address_book() does not get names or mail addresses with lineends 2020-05-03 14:43:51 +02:00
B. Petersen a011dccfe3 reorder device messages 2020-05-02 15:52:48 +02:00
B. Petersen c60cff2259 simplify casting, add comment 2020-05-02 15:08:24 +02:00
Hocuri 27a87775d3 Code style: Handle DC_EVENT_INCOMING_MSG directly in handleEvent().
sendToObservers() made sure not to execute it on a background thread but updateNotification() does this, too, so everything is fine.
2020-05-02 14:00:57 +02:00
Hocuri 16dfd9f98c Fix #1328 Missing notifications: initializeIncomingMessageNotifier() in ApplicationDcContext, not ApplicationContext 2020-05-02 13:45:54 +02:00
B. Petersen 1203df4daf do not recreate/restart ForegroundDetector, NetworkStateReceiver, KeepAliveService on switching account 2020-05-02 11:14:26 +02:00
B. Petersen dc81fa60d4 typo (make sure, the message is only shown once) 2020-05-02 11:06:02 +02:00
B. Petersen 938dc404f7 update translations 2020-05-02 11:04:57 +02:00
B. Petersen 6f0d8c730d reword device message text 2020-04-30 10:54:31 +02:00
B. Petersen 687693bdf8 add device message wrt permantent notification 2020-04-29 21:49:41 +02:00
cyBerta 0c3ff54b79 Merge pull request #1323 from deltachat/reliable-notifications
show permanent notification unconditionally and add a switch to override this
2020-04-28 18:23:13 +02:00
B. Petersen 2fa348a8ea show a warning when database deletion fails 2020-04-28 18:13:14 +02:00
B. Petersen efe6c9e4df also delete files in the blobdir 2020-04-28 17:59:34 +02:00
B. Petersen 37d05f394a rename handleSwitDeleteAccount() to showDeleteAccountMenu() 2020-04-28 17:47:32 +02:00
B. Petersen 328b368f70 rename handleSwitchAccount() to showSwitchAccountMenu() 2020-04-28 17:45:40 +02:00
B. Petersen 95cb121fe0 show disabled permantent-notification in summary 2020-04-28 15:17:39 +02:00
B. Petersen 69d05ae0c7 show permantent-notification unconditionally and add a switch to disable it 2020-04-28 15:16:50 +02:00
B. Petersen 1e345a40c4 simplify translations 2020-04-28 11:02:01 +02:00
bjoern 65e44cc9db Merge pull request #1309 from deltachat/less-html
avoid superfluous html-parsing
2020-04-27 20:51:14 +02:00
B. Petersen 8461c13f65 wording 2020-04-24 18:29:28 +02:00
B. Petersen d0feb55a8d tune down switch-dialog 2020-04-24 18:22:53 +02:00
B. Petersen 587123c3ae add margin between progress-bar and dialog when there are not buttons 2020-04-24 16:30:14 +02:00
B. Petersen 61192e90e4 use SwitchAccountAsyncTask also for aborting account-creation 2020-04-24 14:49:10 +02:00
B. Petersen 2eae56a415 do account switching in async task 2020-04-24 13:49:47 +02:00
B. Petersen 6c8d6a804d continue interrupting running threads 2020-04-24 12:34:23 +02:00
B. Petersen 36c4f7ae2b tweak deletion of not-created-accounts 2020-04-24 02:03:47 +02:00
B. Petersen 0f4bd6347f stop threads and call close() on switching account
the imap-/mvbox-/sentbox-/smtp-threads needs to be terminated
before dc_close() can be called successfully.

if this is not done, they are hanging around, and, even worse,
if an account is opened _again_, there are now two threads
working on the database which lead to duplicated messages.

note, that this issue is only related to duplicated messages
if ever an account was selected, which, however, might be the same as the current.
2020-04-24 01:56:07 +02:00
bjoern a81bfcf40d Merge pull request #1304 from deltachat/fix-selfavatar
Ask the core for the selfavatar directory, fix "backup export/import loses self-avatar"
2020-04-24 00:38:27 +02:00
B. Petersen 1c0df2eff0 avoid superfluous html-parsing 2020-04-24 00:36:02 +02:00
bjoern 76ec6bfd7d Merge pull request #1308 from deltachat/fix-npe
Fix Null-Pointer-Exception
2020-04-24 00:35:27 +02:00
Hocuri faff17e1f1 Fix Null-Pointer-Exception 2020-04-23 20:55:48 +02:00
Hocuri 7f49746f53 fix compile error & name of temp file 2020-04-23 20:09:28 +02:00
Hocuri 80133f82ee Also let the core care about group avatars 2020-04-23 16:03:10 +02:00
B. Petersen b2ed3d1775 in the account switcher, do nothing if switching no new account was selected
prevent switching accounts if the currently selected account was tapped,
just close the dialog in this case.
(ux wise, it is better to show the current account - to get some overview
and also to easily see what the current account is)
2020-04-23 13:38:18 +02:00
Hocuri d98a509779 Inline getInputStreamFor 2020-04-22 15:45:46 +02:00
Hocuri bf6cfc552f Write self avatar to temp file when changing it 2020-04-22 15:23:59 +02:00
Hocuri c8351d1dd2 Code style 2020-04-22 15:05:38 +02:00
Hocuri d7d5faaf64 Ask the core for the selfavatar directory, fix #1381 backup export/import loses self-avatar 2020-04-22 14:36:21 +02:00
bjoern 27c9de0df1 Merge pull request #1298 from deltachat/multi-account
multi account
2020-04-21 19:06:04 +02:00
cyBerta 1807af277a Merge pull request #1301 from deltachat/fix-autodel-cancel
discard (accidental) taps outside the autodel-confirmation dialog
2020-04-21 18:48:37 +02:00
B. Petersen 9d9fbb6e98 remove now unneeded ScreenReceiver 2020-04-21 12:34:10 +02:00
B. Petersen d1d8e3def6 show foreground notification unconditionally
the foreground notification is an important element
that avoids the system from killing the app.

in the past, we added the foreground notification when the screen turns off
and removed it when the screen turns on again -
the reason was that the notification does not annoy users this way.

meanwhile, however, it seems that this approach is no longer as reliable
as in the past. might be that we are killed before the screen turns off -
or that some handlers are not executed by some systems.

also meanwhile, even the "allow to run in background" resp.
"allow battery consumption" seems to be unreliable on various systems,
there are several reports eg. on stackoverflow that apps are killed anyway -
but a foreground notification is not known to be killed yet -
also as the api contract is about to avoid exactly that.

finally, this notification is also a good methor for users
to notice if the app gets killed -
so that they can blame the system then.

therefore, the annoying of the permanent notification
is probably the smaller drawback compared to
received messages delayed.
2020-04-21 12:19:21 +02:00