Commit Graph

1722 Commits

Author SHA1 Message Date
cyBerta 997040d5d6 Merge pull request #1792 from deltachat/emojis_on_map
show emojis on map
2021-02-17 21:27:14 +01:00
cyberta 80ca47fb91 emoji bitmap size depends on passed scale parameter 2021-02-16 13:13:47 +01:00
cyberta 5a5abaffe4 adapt indentation 2021-02-15 22:32:31 +01:00
cyberta 4064f3a30b Don't use AsyncTask class to generate emoji bitmaps, it's deprecated now. Pass emoji scaling factor instead of hard-coding it 2021-02-15 20:04:40 +01:00
cyberta cae1c82a7f avoid that POI emoji icon disappears if info window appears 2021-02-15 16:03:35 +01:00
cyberta ac88aa2419 rename parameter to contextualize input in DataCollectionTask 2021-02-15 14:40:31 +01:00
cyberta 363d92cedb make reference to running collection tasks thread safe 2021-02-15 14:40:31 +01:00
cyberta d68095eca7 show emojis on map 2021-02-15 14:40:31 +01:00
cyberta 9b42940dea handle null location more gracefully 2021-02-15 12:08:13 +01:00
cyberta c17e7f87a7 don't use cached first location fixes that are older than 2 minutes 2021-02-15 12:02:01 +01:00
B. Petersen 95b605e331 mark overridden names by a "~" in the bubbles
this is just a very simple approach to move forward.

to mark overridden names, a "~" is prefixed.

the idea with using a dedicated color for these names:
as we do not really know
if the address is a generic sender address or belongs to the user,
it makes sense to keep the color used for the name and do not use a
dedicated grey or so.

i think, it is not even worth to detect that better:
it is pretty nice to have senders in mailinglist marked nicely,
all the time.

currently, the "~" is only added to the bubbles - it is not there
in the chatlist-summary (that would needed to be done in core)
and also not in forwarded by, notifications, clipboard etc. i'd say currently,
this is not needed, however, with the current approach it would be doable
(if we mark possible impersonation by colors or icons that may be
much more complicated)

adaption on other uis would also be pretty simple with this approach,
and imho, this `~Max Mustermann` looks pretty nicely
and even intuitive in a way.

drawback of the approach is that user may user `~`
as the first character of their names, we could target that by
adapting dc_msg_get_displayname() in the core, if we want to keep this approach,
however, maybe it is also not worth, the "~" is more a flaw than a feature,
also that would result to "~~Name" in the bubbles.
i do not see how that can be used to trick users when beeing added.
names as "foo 🔒" might be more dangerous here, when it comes to trick users.
2021-02-14 22:52:33 +01:00
Hocuri 3b8f3e7628 Show the correct sender name in mailing list messages 2021-02-10 21:33:18 +01:00
B. Petersen 097da7c165 show name of forwarded in groups, keep title of forwarded messages in grey 2021-02-10 15:50:10 +01:00
bjoern c814885f5c mailinglists3 (#1781)
* Adapt to mailing lists

* Change the question if this is a mailing list (untested)

* rm unused fn

* Adapt to getSenderName -> getOverrideSenderName (untested)

* Use dc_msg_get_sender_first_name() because sometimes the first name was not correctly shown in mailing lists

* Don't let the user modify mailing list groups

* Fix crash

* Make Unnamed newsletter translatable, make the subtitle of mailing lists "Mailing list"

* tweak and hide some controls for mailing lists

* Update src/com/b44t/messenger/DcChat.java

Co-authored-by: bjoern <r10s@b44t.com>

* adapt to new dc_msg_get_real_chat() api, remove dc_msg_get_sender_first_name()

* remove now dead code

* add mailing list name to contact-request-question

move question-creation to a helper class
to avoid duplicated code.

* fix DcMsg.getOverrideSenderName()

* adapt to new dc_decide_on_contact_request() api

* re-allow changing name+image for mailinglists, see recent discussions on PRs

* remove memberlist- and settings-tab from mailinglist profile until there is some use for them

* adapt to new DC_CHAT_TYPE_MAILINGLIST type

Co-authored-by: Hocuri <hocuri@gmx.de>
2021-02-07 23:39:48 +01:00
B. Petersen 9f2be9c56c use dc_get_chat_encr_info() where useful 2021-02-07 20:32:51 +01:00
B. Petersen 44b0739f6c make profile-menu easier editable, show 'Encryption' item also in groups 2021-02-07 20:32:51 +01:00
Hocuri b645dc60a0 Improve performance and make sure that there is no race condition
add a static boolean doReinitializeDraft that is set to true in onPause() if this activity was started using startActivityForResult(). in onResume(), do if(doReinitializeDraft) { initializeDraft(); }.
2021-02-05 22:32:50 +01:00
Hocuri cd5f0c212c Fix disappearing drafts
Some people reported that drafts were disappearing, and I found a way to
reproduce it (my interpretation in brackets):
- Open Saved Messages chat, could be any other chat too
- Go to another app and share to DC
- In DC select Saved Messages
  - (as sharing is done using startActivityForResult(), a second
  ConversationActivity is created without affecting the existing one)
- Leave DC. (The second ConversationActivity will correctly save its
draft to the db)
- Open DC again from the "Recent apps". (The first ConversationActivity
will be loaded. It will not know that there is a newer draft and still
show the old draft, or nothing if there was none. When it's closed, it
will overwrite the draft)

I came to this conclusion by logging all writes to the draft in the db.
Also, when I set `REQUEST_RELAY` to -1 (`startActivityForResult(intent,
-1) will behave the same as `startActivity(intent)`) (but that's not a
solution, sometimes we need startActivityForResult(), see e.g.
https://github.com/deltachat/deltachat-android/pull/1412)

What's still a little weird: I tried replacing all calls to
`startActivityForResult(-intent for ConversationActivity-)` with
startActivity(), and the issue didn't go away. Apparently it's only
enough if all calls are replaced, which is the same as setting
`REQUEST_RELAY` to -1. Maybe it's enough if one activity in the call
chain is called using startActivityForResult().

The call to `initializeDraft()` makes the activity start & resume 2-3ms
slower, which is probably acceptable.

While going back and forth with activities & sharing, I also encountered
some more bugs (without trying to reproduce them), but they are not too
annoying (as opposed to losing your draft) and I'm hesitant to changing
the activity-switching logic too much as it is so easy to just break
things again.
2021-02-05 22:32:50 +01:00
link2xt 9e610e5d4b Replace 4 weeks option with 5 weeks option
While 4 weeks always fits in a month,
5 weeks (35 days) always covers at least a month,
so it can be used in a situation where messages are required to
be stored for a month.
2021-02-03 13:34:05 +03:00
B. Petersen 90bb1eb559 add comments on ephemeral-timer-indexes 2021-01-31 00:45:13 +03:00
link2xt f155757cee Change list of ephemeral message options
Also match unknown options to some known option, not "disabled".
2021-01-31 00:45:13 +03:00
B. Petersen f593f27d98 harden WebView settings 2021-01-29 15:25:23 +01:00
B. Petersen 74cdd85815 add pinch-to-zoom options to message-html-view 2021-01-29 15:25:23 +01:00
bjoern 8d9c02dd7a add option to view full (html) message (#1763)
* add get-mime-original apis

* remove unused control

* add 'Show full message' buttons

* split reusable WebViewActivity from LocalHelpActivity

* add FullMsgActivity

* load html via AsyncTask

* adapt to changed api

* handle mailto:-links in WebView

* block loading remote images by default, add user setting always/once/never

* do not hide 'Once' button in always-mode, playing around a day with hidden 'Once' that looks more like a bug :)

* wording: as 'Always' affects all messages, it is better to speak of multiple senders

* wording: use 'Load remote images'

this makes it easier for the user to find the option
if one sees, images are missing in the document.

* wording: shorten text.

* wording: change 'may' to 'can'. 'may' sounds a bit as if someone allows this.

* Don't use AsyncTask

* check 'once' if appropriate

* use lite-colored checkbox-emoji in dark-theme

* add comment about missing error logging

Co-authored-by: Hocuri <hocuri@gmx.de>
2021-01-28 22:53:15 +01:00
B. Petersen 3914bf7ff4 adapt to removed dc_contact_get_first_name() api
use dc_contact_get_display_name() instead
2021-01-23 19:52:23 +01:00
B. Petersen 5371f312ac remove unused isIoRunning() api
the api is about to be removed from core as well,
see https://github.com/deltachat/deltachat-core-rust/pull/2139
2021-01-15 06:49:39 +03:00
Hocuri a96aa2ff48 Show controls on small screens
Using both `setMessage()` and `setView()` on the same AlertDialog,
on small screens the "OK" and "Cancel" buttons were not be show. So, put the
message into our custom view.
2021-01-03 12:25:53 +01:00
Hocuri 1ff6a3a18d Dark theme / DayNight: Add option to follow system
fix maybe #1748. Maybe not, because actually I don't understand why
issue #1748 even happened because we don't use the system background for
the bubble but an own one (see conversation_item_sent.xml:50). Probably
the system is somehow trying to forcefully create a dark mode.

So, let's see whether this PR fixes the issue, if not, I'll try again.
2020-12-19 19:51:55 +01:00
Hocuri cfea049418 Always release the media player before setting it to 0
I can't tell if it helps, I personally was able to both play a 60min
audio and to play 32 voice messages after each other. Shouldn't hurt to
release them, though.

I tested my change, and at least it seems not to worsen anything.
2020-12-19 12:07:06 +01:00
B. Petersen f608fe0766 add missing button to new error-dialog
following common ui expectations,
there must always be at least one "ok" button
in a dialog or alert.
2020-12-14 13:16:24 +01:00
Hocuri 45aa3e5b82 Directly show error on msg tap
fix #1749
2020-12-13 18:06:44 +01:00
Hocuri 8736ac8fa9 Reset the tint if the message is not failed
Seems like in the first commit I was not careful enough: The color was
set to red, but then the view was reused in a RecyclerView and the color
stayed red. Therefore, after scrolling, more and more of the status icons got
red.
2020-12-12 17:40:44 +01:00
Hocuri 161e1d350b Red and more visible error icon
IIRC some time ago we talked about making the error icon red and make it
an exclamation mark to make it more visible.

Today someone complained to me that they thought the "x" looks like one
can close something and that it shouldn't be green, so I went ahead and
made it red :) (it's also a little bit bigger now)

- the image file is a vector (xml) file now, previously it was a png file.
Might this be a problem?
2020-12-12 16:44:52 +01:00
Hocuri 26c8497509 Fix crash on some device of some friend of Holger 2020-12-04 17:40:32 +01:00
bjoern 1cc0c9d0c1 Merge pull request #1688 from deltachat/fix-tall-images-message-width
Wider messages for tall images
2020-12-01 13:29:43 +01:00
bjoern 321e4c4dab Merge pull request #1732 from deltachat/show-in-chat
add 'show in chat' function, fix enlarge-view-menu-issues
2020-11-28 23:39:59 +01:00
bjoern 7f37d93916 Merge pull request #1744 from deltachat/quote-forwarded-msgs
display forwarded messages also in quotes as such
2020-11-27 13:05:19 +01:00
B. Petersen 12e4d6b30e introduce color 'unknown_sender' and use it for forwarded messages, forwarded quotes, quotes with unknown sender 2020-11-25 20:57:46 +01:00
B. Petersen d4ef19b9cf remove dead code 2020-11-25 10:45:41 +01:00
B. Petersen b284a70ef7 reword no-blocked-contats-hint 2020-11-22 23:06:00 +01:00
B. Petersen ed9921f40e show hint when there are no blocked contacts 2020-11-22 23:06:00 +01:00
B. Petersen 68961fdcd7 remove unused SwipeRefreshLayout and use self-explaining default for contact-list-empty-hint 2020-11-22 22:16:13 +01:00
Hocuri 0f2c3f4791 Remove rounded corners if the message has a quote 2020-11-21 17:19:20 +01:00
B. Petersen 783168549a open correct tab 2020-11-20 13:20:39 +01:00
B. Petersen f8dba0f2d5 fix backstack for 'all media' option
- when called from gallery, this is just the same as 'back'

- otherwise, do not forget to remove self
2020-11-20 13:20:38 +01:00
B. Petersen 658c3af66b add 'show in chat' function 2020-11-20 13:20:38 +01:00
B. Petersen 8853e320c0 remove 'forward' from gallery
- it forwards media together with the text,
  this is unexpected
- if forward is available, reply and reply-privately
  should be available as well, however, this seems to be a bit much.
- the function had issues which would need fixing.

instead, we will add a 'Show in chat' function that is more powerful
and fixes all of the things above.
2020-11-20 13:19:54 +01:00
B. Petersen 8e185e4f26 show permanent hint about server-delete impact
when server-deletion is enabled,
always show a hint about the impact below the option.

the hint is a summary of the conformation-dialog
so that the user is more aware of the impact
if enabling was some time ago
or the option was even enabled by the provider-db.
2020-11-18 21:54:39 +01:00
Hocuri 9beff06fb1 Fix #1726 2020-11-12 14:28:04 +01:00
bjoern 710f0195f4 Merge pull request #1720 from deltachat/quotes-add-on-3
Quotes add on 3
2020-11-09 12:55:53 +01:00