- it forwards media together with the text,
this is unexpected
- if forward is available, reply and reply-privately
should be available as well, however, this seems to be a bit much.
- the function had issues which would need fixing.
instead, we will add a 'Show in chat' function that is more powerful
and fixes all of the things above.
when server-deletion is enabled,
always show a hint about the impact below the option.
the hint is a summary of the conformation-dialog
so that the user is more aware of the impact
if enabling was some time ago
or the option was even enabled by the provider-db.
the 'inboxes' value contains the last lines of notification,
however, if the app is restarted for whatever reasons,
but notifications are persisted,
they do not contain all lines.
for the notification display, this is no big deal,
however, this cached value is not suitable
to check if there is a notification or not for a chat.
even if there is a notification, 'inboxes' may be empty,
this 'speed up' check was introduced
for a workaround of notification removal that requires lots of calls.
meanwhile, however, we have DC_EVENT_MSGS_NOTICED,
so we also remove this workaround.
I also deleted an unnecessary LinearLayout, so you should look at the
diff with --ignore-all-space
Firstly, I lifted quote_attachment_container out of the FrameLayout with
the thumbnail so that quote_attachment_container can be wrap_content
(and enlarge the quote if necessary) while the thumbnail still always
matches the size of the quote.
Then I made the document view itself a little smaller so it does not
enlarge the quote all the times.
i cannot see a usecase for forwarding info-messages as "member added",
so it might also confuse users when the option is offered at all.
as all selected messages are loaded into memory anyway,
this was easy to implement.
tbh, if we would track the selection by message-ids only and
this would have require a larger refactoring or performace issues
(imaging 100 messages to be checked on each new selected message),
i would not have implemented that now :)
i do not think, that sensitive information can be send accidentially this way,
even if Bob can forward an info-message as "Alice invited Claire" -
it is pretty clear to Bob that he forwards exactly that text.
(this is different from adding "Honey" to the group -
where "Honey" is an only locally given name for "Dr. Someone" ;)
Not working as sometimes the ConversationItem would have to determine
the width (i.e. the screen width), sometimes the
ConversationItemThumbnail. Not sure if it's worth it fixing this.
adbenitez