Counterpart of https://github.com/chatmail/core/pull/6851
* Make sending of statistics into a setting
* feat: Count securejoin sources and UI paths
* feat: Rename self_reporting to send_statistics
* Adapt core's API change
* WIP, untested: Adapt to a rename on the core side
* Adapt to generated jsonrpc
* New strings and a new dialog
* Adapt to the API change
* Rewording: `...and support research`
* "More Info" button rather than link
* Small fixes
* Open the correct survey (though it doesn't work yet)
* Changelog
* Update help
* Fix compile error
* Fix compilation
* Revert submodule change
* Don't show a device message yet
* Move "Send Statistics" setting
* Fix compilation error
* Remove unused constant
---------
Co-authored-by: adb <adb@merlinux.eu>
it was renamed first on iOS from 'Chats and Media' to 'Chats'
to not confuse with 'All Apps and Media' -
however, that point is also valid for android,
but even if not, it is good for inner consistency and simpler documentation.
moreover, the settings are in reality also about contacts and more,
so just a broad chats is fine.
but also for outer consistency,
this seems better - also in quite some other apps,
it is just called 'chats'
this removes the addendum 'on all your devices'
from the 'really delete?' questions.
- after polls, and looking at what other apps are doing,
it is just the default expectation, that a message is deleted from all devices,
also, we do not have an option (nor do not want to have)
- so, at that point - fresh user, one device -
there is no need to clutter with other convepts and relativation.
also, most user will never have more devices.
- ppl anyway do not read -
but if they do, it is good to have things as much on point as possible :)
- the question fits better to the "delete for everyone" option
- simplify code and strings,
as device message deletion is no longer special
(there, we never said "on all your devices")
the addendum 'from your devices' was added as
one year ago, for technical limitations, deletion was really on one device.
when we removed that limitation, we added to addendum,
so ppl used to old apps have a chance to get the change.
meanwhile, the new default is clear and settled and the addendum
does more harm and raise questions than doing good.
adbenitez