From 87ae0e9d377bcd89915de6ab00691382f2c4fd9f Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Wed, 22 May 2019 22:45:44 +0200 Subject: [PATCH 01/11] fix redraw error --- src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java | 1 + .../securesms/contacts/ContactSelectionListItem.java | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index d4ff029df..737111f24 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -180,6 +180,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter addr = dcContact.getAddr(); } + contactItem.unbind(glideRequests); contactItem.set(glideRequests, id, dcContact, name, addr, label, false, true); } else if (holder.itemView instanceof ConversationListItem) { diff --git a/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java b/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java index 742955498..f3f823dc3 100644 --- a/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java +++ b/src/org/thoughtcrime/securesms/contacts/ContactSelectionListItem.java @@ -68,7 +68,6 @@ public class ContactSelectionListItem extends LinearLayout implements RecipientM if (specialId==DcContact.DC_CONTACT_ID_NEW_CONTACT || specialId==DcContact.DC_CONTACT_ID_NEW_GROUP || specialId==DcContact.DC_CONTACT_ID_NEW_VERIFIED_GROUP || specialId==DcContact.DC_CONTACT_ID_ADD_MEMBER || specialId==DcContact.DC_CONTACT_ID_QR_INVITE) { this.recipient = null; - this.contactPhotoImage.setAvatar(glideRequests, Recipient.from(getContext(), Address.UNKNOWN), false); } else { this.recipient = DcHelper.getContext(getContext()).getRecipient(contact); From ecbbe30259945b2912e5b32dadb3f980218ed748 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Wed, 22 May 2019 22:51:01 +0200 Subject: [PATCH 02/11] remove unused inverted-avatars --- .../securesms/components/AvatarImageView.java | 2 +- .../avatars/FallbackContactPhoto.java | 1 - .../avatars/GeneratedContactPhoto.java | 9 ++---- .../avatars/ResourceContactPhoto.java | 11 +------ .../avatars/TransparentContactPhoto.java | 30 ------------------- .../securesms/recipients/Recipient.java | 2 +- 6 files changed, 5 insertions(+), 50 deletions(-) delete mode 100644 src/org/thoughtcrime/securesms/contacts/avatars/TransparentContactPhoto.java diff --git a/src/org/thoughtcrime/securesms/components/AvatarImageView.java b/src/org/thoughtcrime/securesms/components/AvatarImageView.java index 03c7a622a..0757b25b3 100644 --- a/src/org/thoughtcrime/securesms/components/AvatarImageView.java +++ b/src/org/thoughtcrime/securesms/components/AvatarImageView.java @@ -59,7 +59,7 @@ public class AvatarImageView extends AppCompatImageView { setAvatarClickHandler(recipient, quickContactEnabled); } } else { - setImageDrawable(new GeneratedContactPhoto("+").asDrawable(getContext(), ThemeUtil.getDummyContactColor(getContext()), false)); + setImageDrawable(new GeneratedContactPhoto("+").asDrawable(getContext(), ThemeUtil.getDummyContactColor(getContext()))); super.setOnClickListener(listener); } } diff --git a/src/org/thoughtcrime/securesms/contacts/avatars/FallbackContactPhoto.java b/src/org/thoughtcrime/securesms/contacts/avatars/FallbackContactPhoto.java index 8d8bf0ed8..d33323098 100644 --- a/src/org/thoughtcrime/securesms/contacts/avatars/FallbackContactPhoto.java +++ b/src/org/thoughtcrime/securesms/contacts/avatars/FallbackContactPhoto.java @@ -6,7 +6,6 @@ import android.graphics.drawable.Drawable; public interface FallbackContactPhoto { public Drawable asDrawable(Context context, int color); - public Drawable asDrawable(Context context, int color, boolean inverted); public Drawable asCallCard(Context context); } diff --git a/src/org/thoughtcrime/securesms/contacts/avatars/GeneratedContactPhoto.java b/src/org/thoughtcrime/securesms/contacts/avatars/GeneratedContactPhoto.java index 61e6f06f6..374711074 100644 --- a/src/org/thoughtcrime/securesms/contacts/avatars/GeneratedContactPhoto.java +++ b/src/org/thoughtcrime/securesms/contacts/avatars/GeneratedContactPhoto.java @@ -25,20 +25,15 @@ public class GeneratedContactPhoto implements FallbackContactPhoto { @Override public Drawable asDrawable(Context context, int color) { - return asDrawable(context, color, false); - } - - @Override - public Drawable asDrawable(Context context, int color, boolean inverted) { int targetSize = context.getResources().getDimensionPixelSize(R.dimen.contact_photo_target_size); return TextDrawable.builder() .beginConfig() .width(targetSize) .height(targetSize) - .textColor(inverted ? color : Color.WHITE) + .textColor(Color.WHITE) .endConfig() - .buildRound(getCharacter(name), inverted ? Color.WHITE : color); + .buildRound(getCharacter(name), color); } private String getCharacter(String name) { diff --git a/src/org/thoughtcrime/securesms/contacts/avatars/ResourceContactPhoto.java b/src/org/thoughtcrime/securesms/contacts/avatars/ResourceContactPhoto.java index edb902c35..690b24d49 100644 --- a/src/org/thoughtcrime/securesms/contacts/avatars/ResourceContactPhoto.java +++ b/src/org/thoughtcrime/securesms/contacts/avatars/ResourceContactPhoto.java @@ -28,20 +28,11 @@ public class ResourceContactPhoto implements FallbackContactPhoto { @Override public Drawable asDrawable(Context context, int color) { - return asDrawable(context, color, false); - } - - @Override - public Drawable asDrawable(Context context, int color, boolean inverted) { - Drawable background = TextDrawable.builder().buildRound(" ", inverted ? Color.WHITE : color); + Drawable background = TextDrawable.builder().buildRound(" ", color); RoundedDrawable foreground = (RoundedDrawable) RoundedDrawable.fromDrawable(context.getResources().getDrawable(resourceId)); foreground.setScaleType(ImageView.ScaleType.CENTER); - if (inverted) { - foreground.setColorFilter(color, PorterDuff.Mode.SRC_ATOP); - } - return new ExpandingLayerDrawable(new Drawable[] {background, foreground}); } diff --git a/src/org/thoughtcrime/securesms/contacts/avatars/TransparentContactPhoto.java b/src/org/thoughtcrime/securesms/contacts/avatars/TransparentContactPhoto.java deleted file mode 100644 index 33c2064b1..000000000 --- a/src/org/thoughtcrime/securesms/contacts/avatars/TransparentContactPhoto.java +++ /dev/null @@ -1,30 +0,0 @@ -package org.thoughtcrime.securesms.contacts.avatars; - -import android.content.Context; -import android.graphics.drawable.Drawable; -import android.support.v4.content.ContextCompat; - -import com.makeramen.roundedimageview.RoundedDrawable; - -import org.thoughtcrime.securesms.R; - -public class TransparentContactPhoto implements FallbackContactPhoto { - - public TransparentContactPhoto() {} - - @Override - public Drawable asDrawable(Context context, int color) { - return asDrawable(context, color, false); - } - - @Override - public Drawable asDrawable(Context context, int color, boolean inverted) { - return RoundedDrawable.fromDrawable(context.getResources().getDrawable(android.R.color.transparent)); - } - - @Override - public Drawable asCallCard(Context context) { - return ContextCompat.getDrawable(context, R.drawable.ic_contact_picture_large); - } - -} diff --git a/src/org/thoughtcrime/securesms/recipients/Recipient.java b/src/org/thoughtcrime/securesms/recipients/Recipient.java index ce2a402fc..4eaa4d89e 100644 --- a/src/org/thoughtcrime/securesms/recipients/Recipient.java +++ b/src/org/thoughtcrime/securesms/recipients/Recipient.java @@ -203,7 +203,7 @@ public class Recipient { } public synchronized @NonNull Drawable getFallbackAvatarDrawable(Context context) { - return getFallbackContactPhoto().asDrawable(context, getFallbackAvatarColor(context), false); + return getFallbackContactPhoto().asDrawable(context, getFallbackAvatarColor(context)); } public synchronized @NonNull FallbackContactPhoto getFallbackContactPhoto() { From 4988f94f76850e4dbd3d920812a91eecef92bfd9 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 00:43:11 +0200 Subject: [PATCH 03/11] update profile on changes --- .../securesms/ProfileActivity.java | 69 +++++++++---------- .../securesms/ProfileDocumentsFragment.java | 28 ++++++-- .../securesms/ProfileGalleryFragment.java | 26 +++++-- .../securesms/ProfileSettingsAdapter.java | 28 +------- .../securesms/ProfileSettingsFragment.java | 34 ++++++--- 5 files changed, 104 insertions(+), 81 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ProfileActivity.java b/src/org/thoughtcrime/securesms/ProfileActivity.java index bd89813c9..97c133566 100644 --- a/src/org/thoughtcrime/securesms/ProfileActivity.java +++ b/src/org/thoughtcrime/securesms/ProfileActivity.java @@ -1,7 +1,6 @@ package org.thoughtcrime.securesms; import android.os.Bundle; -import android.support.annotation.Nullable; import android.support.design.widget.TabLayout; import android.support.v4.app.Fragment; import android.support.v4.app.FragmentManager; @@ -12,10 +11,11 @@ import android.view.MenuItem; import com.b44t.messenger.DcChat; import com.b44t.messenger.DcContact; +import com.b44t.messenger.DcContext; +import com.b44t.messenger.DcEventCenter; import org.thoughtcrime.securesms.connect.ApplicationDcContext; import org.thoughtcrime.securesms.connect.DcHelper; -import org.thoughtcrime.securesms.recipients.Recipient; import org.thoughtcrime.securesms.util.DynamicLanguage; import org.thoughtcrime.securesms.util.DynamicNoActionBarTheme; import org.thoughtcrime.securesms.util.DynamicTheme; @@ -23,7 +23,9 @@ import org.thoughtcrime.securesms.util.ViewUtil; import java.util.ArrayList; -public class ProfileActivity extends PassphraseRequiredActionBarActivity { +public class ProfileActivity extends PassphraseRequiredActionBarActivity + implements DcEventCenter.DcEventDelegate +{ @SuppressWarnings("unused") private final static String TAG = ProfileActivity.class.getSimpleName(); @@ -43,9 +45,8 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { private ApplicationDcContext dcContext; private int chatId; - private @Nullable DcChat dcChat; + private boolean chatIsGroup; private int contactId; - private @Nullable DcContact dcContact; private ArrayList tabs = new ArrayList<>(); private Toolbar toolbar; @@ -68,6 +69,8 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { this.tabLayout.setupWithViewPager(viewPager); this.viewPager.setAdapter(new ProfilePagerAdapter(getSupportFragmentManager())); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_CHAT_MODIFIED, this); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_CONTACTS_CHANGED, this); } @Override @@ -77,6 +80,12 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { dynamicLanguage.onResume(this); } + @Override + public void onDestroy() { + dcContext.eventCenter.removeObservers(this); + super.onDestroy(); + } + @Override public boolean onOptionsItemSelected(MenuItem item) { super.onOptionsItemSelected(item); @@ -88,25 +97,25 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { return false; } + @Override + public void handleEvent(int eventId, Object data1, Object data2) { + updateToolbar(); + } + private void initializeResources() { - chatId = getIntent().getIntExtra(CHAT_ID_EXTRA, 0); - contactId = getIntent().getIntExtra(CONTACT_ID_EXTRA, 0); + chatId = getIntent().getIntExtra(CHAT_ID_EXTRA, 0); + contactId = getIntent().getIntExtra(CONTACT_ID_EXTRA, 0); + chatIsGroup = false; if (contactId!=0) { - dcContact = dcContext.getContact(contactId); chatId = dcContext.getChatIdByContactId(contactId); - if (chatId!=0) { - dcChat = dcContext.getChat(chatId); - } } else if(chatId!=0) { - dcChat = dcContext.getChat(chatId); - if(!dcChat.isGroup()) { + DcChat dcChat = dcContext.getChat(chatId); + chatIsGroup = dcChat.isGroup(); + if(!chatIsGroup) { final int[] members = dcContext.getChatContacts(chatId); contactId = members.length>=1? members[0] : 0; - if (contactId!=0) { - dcContact = dcContext.getContact(contactId); - } } } @@ -137,10 +146,10 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { getSupportActionBar().setTitle(R.string.menu_all_media); } else if (isContactProfile()){ - getSupportActionBar().setTitle(dcContact.getName()); + getSupportActionBar().setTitle(dcContext.getContact(contactId).getName()); } - else if (dcChat != null) { - getSupportActionBar().setTitle(dcChat.getName()); + else if (chatId >= 0) { + getSupportActionBar().setTitle(dcContext.getChat(chatId).getName()); } } @@ -150,25 +159,13 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { private boolean isContactProfile() { // there may still be a single-chat lined to the contact profile - return dcContact!=null && (dcChat==null || !dcChat.isGroup()); + return contactId!=0 && (chatId==0 || !chatIsGroup); } private boolean isSelfProfile() { return isContactProfile() && contactId==DcContact.DC_CONTACT_ID_SELF; } - private Recipient getRecipient() { - if(dcChat!=null) { - return dcContext.getRecipient(dcChat); - } - else if(dcContact!=null) { - return dcContext.getRecipient(dcContact); - } - else { - return dcContext.getRecipient(dcContext.getContact(0)); - } - } - private class ProfilePagerAdapter extends FragmentStatePagerAdapter { ProfilePagerAdapter(FragmentManager fragmentManager) { @@ -184,20 +181,20 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity { switch(tabId) { case TAB_SETTINGS: fragment = new ProfileSettingsFragment(); - args.putInt(ProfileSettingsFragment.CHAT_ID_EXTRA, dcChat==null? -1 : chatId); - args.putInt(ProfileSettingsFragment.CONTACT_ID_EXTRA, dcContact==null? -1 : contactId); + args.putInt(ProfileSettingsFragment.CHAT_ID_EXTRA, (chatId==0&&!isGlobalProfile())? -1 : chatId); + args.putInt(ProfileSettingsFragment.CONTACT_ID_EXTRA, (contactId==0&&!isGlobalProfile())? -1 : contactId); args.putSerializable(ProfileSettingsFragment.LOCALE_EXTRA, dynamicLanguage.getCurrentLocale()); break; case TAB_GALLERY: fragment = new ProfileGalleryFragment(); - args.putInt(ProfileGalleryFragment.CHAT_ID_EXTRA, dcChat==null? -1 : chatId); + args.putInt(ProfileGalleryFragment.CHAT_ID_EXTRA, (chatId==0&&!isGlobalProfile())? -1 : chatId); args.putSerializable(ProfileGalleryFragment.LOCALE_EXTRA, dynamicLanguage.getCurrentLocale()); break; default: fragment = new ProfileDocumentsFragment(); - args.putInt(ProfileGalleryFragment.CHAT_ID_EXTRA, dcChat==null? -1 : chatId); + args.putInt(ProfileGalleryFragment.CHAT_ID_EXTRA, (chatId==0&&!isGlobalProfile())? -1 : chatId); args.putSerializable(ProfileDocumentsFragment.LOCALE_EXTRA, dynamicLanguage.getCurrentLocale()); break; } diff --git a/src/org/thoughtcrime/securesms/ProfileDocumentsFragment.java b/src/org/thoughtcrime/securesms/ProfileDocumentsFragment.java index 1414c233b..3aef6f5b4 100644 --- a/src/org/thoughtcrime/securesms/ProfileDocumentsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileDocumentsFragment.java @@ -24,6 +24,7 @@ import android.view.Window; import android.widget.TextView; import com.b44t.messenger.DcContext; +import com.b44t.messenger.DcEventCenter; import com.b44t.messenger.DcMsg; import com.codewaves.stickyheadergrid.StickyHeaderGridLayoutManager; @@ -37,7 +38,9 @@ import java.util.Collection; import java.util.Locale; public class ProfileDocumentsFragment - extends Fragment implements LoaderManager.LoaderCallbacks, ProfileDocumentsAdapter.ItemClickListener + extends Fragment + implements LoaderManager.LoaderCallbacks, + ProfileDocumentsAdapter.ItemClickListener, DcEventCenter.DcEventDelegate { public static final String LOCALE_EXTRA = "locale_extra"; public static final String CHAT_ID_EXTRA = "chat_id"; @@ -48,13 +51,15 @@ public class ProfileDocumentsFragment private ActionMode actionMode; private ActionModeCallback actionModeCallback = new ActionModeCallback(); - protected int chatId; - protected Locale locale; + private ApplicationDcContext dcContext; + protected int chatId; + protected Locale locale; @Override public void onCreate(Bundle bundle) { super.onCreate(bundle); + dcContext = DcHelper.getContext(getContext()); chatId = getArguments().getInt(CHAT_ID_EXTRA, -1); locale = (Locale)getArguments().getSerializable(LOCALE_EXTRA); if (locale == null) throw new AssertionError(); @@ -77,9 +82,22 @@ public class ProfileDocumentsFragment this.recyclerView.setLayoutManager(gridManager); this.recyclerView.setHasFixedSize(true); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_MSGS_CHANGED, this); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_INCOMING_MSG, this); return view; } + @Override + public void onDestroyView() { + dcContext.eventCenter.removeObservers(this); + super.onDestroyView(); + } + + @Override + public void handleEvent(int eventId, Object data1, Object data2) { + getLoaderManager().restartLoader(0, null, this); + } + @Override public void onConfigurationChanged(Configuration newConfig) { super.onConfigurationChanged(newConfig); @@ -130,7 +148,7 @@ public class ProfileDocumentsFragment } private void handleMediaPreviewClick(@NonNull DcMsg dcMsg) { - // audio is stated by the play-button + // audio is started by the play-button if (dcMsg.getType()==DcMsg.DC_MSG_AUDIO || dcMsg.getType()==DcMsg.DC_MSG_VOICE) { return; } @@ -140,7 +158,6 @@ public class ProfileDocumentsFragment return; } - ApplicationDcContext dcContext = DcHelper.getContext(context); dcContext.openForViewOrShare(dcMsg.getId(), Intent.ACTION_VIEW); } @@ -165,7 +182,6 @@ public class ProfileDocumentsFragment AlertDialog.Builder builder = new AlertDialog.Builder(getContext()); builder.setMessage(confirmMessage); builder.setCancelable(true); - final DcContext dcContext = DcHelper.getContext(getContext()); builder.setPositiveButton(R.string.delete, (dialogInterface, i) -> { new ProgressDialogAsyncTask(getContext(), diff --git a/src/org/thoughtcrime/securesms/ProfileGalleryFragment.java b/src/org/thoughtcrime/securesms/ProfileGalleryFragment.java index 04b19b68d..0529557c4 100644 --- a/src/org/thoughtcrime/securesms/ProfileGalleryFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileGalleryFragment.java @@ -24,9 +24,11 @@ import android.view.Window; import android.widget.TextView; import com.b44t.messenger.DcContext; +import com.b44t.messenger.DcEventCenter; import com.b44t.messenger.DcMsg; import com.codewaves.stickyheadergrid.StickyHeaderGridLayoutManager; +import org.thoughtcrime.securesms.connect.ApplicationDcContext; import org.thoughtcrime.securesms.connect.DcHelper; import org.thoughtcrime.securesms.database.Address; import org.thoughtcrime.securesms.database.loaders.BucketedThreadMediaLoader; @@ -38,7 +40,9 @@ import java.util.Collection; import java.util.Locale; public class ProfileGalleryFragment - extends Fragment implements LoaderManager.LoaderCallbacks, ProfileGalleryAdapter.ItemClickListener + extends Fragment + implements LoaderManager.LoaderCallbacks, + ProfileGalleryAdapter.ItemClickListener, DcEventCenter.DcEventDelegate { public static final String LOCALE_EXTRA = "locale_extra"; public static final String CHAT_ID_EXTRA = "chat_id"; @@ -49,13 +53,15 @@ public class ProfileGalleryFragment private ActionMode actionMode; private ActionModeCallback actionModeCallback = new ActionModeCallback(); - protected int chatId; - protected Locale locale; + private ApplicationDcContext dcContext; + private int chatId; + private Locale locale; @Override public void onCreate(Bundle bundle) { super.onCreate(bundle); + dcContext = DcHelper.getContext(getContext()); chatId = getArguments().getInt(CHAT_ID_EXTRA, -1); locale = (Locale)getArguments().getSerializable(LOCALE_EXTRA); if (locale == null) throw new AssertionError(); @@ -79,9 +85,22 @@ public class ProfileGalleryFragment this.recyclerView.setLayoutManager(gridManager); this.recyclerView.setHasFixedSize(true); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_MSGS_CHANGED, this); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_INCOMING_MSG, this); return view; } + @Override + public void onDestroyView() { + dcContext.eventCenter.removeObservers(this); + super.onDestroyView(); + } + + @Override + public void handleEvent(int eventId, Object data1, Object data2) { + getLoaderManager().restartLoader(0, null, this); + } + private int getCols() { return getResources().getConfiguration().orientation == Configuration.ORIENTATION_LANDSCAPE? 5 : 3; } @@ -174,7 +193,6 @@ public class ProfileGalleryFragment AlertDialog.Builder builder = new AlertDialog.Builder(getContext()); builder.setMessage(confirmMessage); builder.setCancelable(true); - final DcContext dcContext = DcHelper.getContext(getContext()); builder.setPositiveButton(R.string.delete, (dialogInterface, i) -> { new ProgressDialogAsyncTask(getContext(), diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index 737111f24..5b1694fef 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -18,14 +18,11 @@ import org.thoughtcrime.securesms.connect.ApplicationDcContext; import org.thoughtcrime.securesms.connect.DcHelper; import org.thoughtcrime.securesms.contacts.ContactSelectionListItem; import org.thoughtcrime.securesms.mms.GlideRequests; -import org.thoughtcrime.securesms.util.LRUCache; import org.thoughtcrime.securesms.util.StickyHeaderDecoration.StickyHeaderAdapter; -import java.lang.ref.SoftReference; import java.util.ArrayList; import java.util.Collections; import java.util.Locale; -import java.util.Map; public class ProfileSettingsAdapter extends RecyclerView.Adapter implements StickyHeaderAdapter @@ -42,10 +39,6 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter public static final int SETTING_SOUND = 320; public static final int SETTING_VIBRATE = 330; - private static final int MAX_CACHE_SIZE = 100; - private final Map> recordCache = - Collections.synchronizedMap(new LRUCache<>(MAX_CACHE_SIZE)); - private final @NonNull Context context; private final @NonNull Locale locale; private final @NonNull ApplicationDcContext dcContext; @@ -106,24 +99,6 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter return itemData.size(); } - private @NonNull DcContact getContact(int position) { - if(position<0 || position>=itemData.size() || itemData.get(position).type!=ItemData.TYPE_MEMBER) { - return new DcContact(0); - } - - final SoftReference reference = recordCache.get(position); - if (reference != null) { - final DcContact fromCache = reference.get(); - if (fromCache != null) { - return fromCache; - } - } - - final DcContact fromDb = dcContext.getContact(itemData.get(position).contactId); - recordCache.put(position, new SoftReference<>(fromDb)); - return fromDb; - } - public static class ViewHolder extends RecyclerView.ViewHolder { public ViewHolder(View itemView) { super(itemView); @@ -175,7 +150,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter name = context.getString(R.string.qrshow_title); } else { - dcContact = getContact(i); + dcContact = dcContext.getContact(itemData.get(i).contactId); name = dcContact.getDisplayName(); addr = dcContact.getAddr(); } @@ -285,7 +260,6 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_BLOCK_CONTACT, context.getString(R.string.menu_block_contact))); } - recordCache.clear(); notifyDataSetChanged(); } } diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index 918716602..b6d9f549b 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -15,6 +15,8 @@ import android.widget.Toast; import com.b44t.messenger.DcChat; import com.b44t.messenger.DcChatlist; import com.b44t.messenger.DcContact; +import com.b44t.messenger.DcContext; +import com.b44t.messenger.DcEventCenter; import org.thoughtcrime.securesms.connect.ApplicationDcContext; import org.thoughtcrime.securesms.connect.DcHelper; @@ -25,7 +27,8 @@ import org.thoughtcrime.securesms.util.ViewUtil; import java.util.Locale; -public class ProfileSettingsFragment extends Fragment implements ProfileSettingsAdapter.ItemClickListener { +public class ProfileSettingsFragment extends Fragment + implements ProfileSettingsAdapter.ItemClickListener, DcEventCenter.DcEventDelegate { public static final String LOCALE_EXTRA = "locale_extra"; public static final String CHAT_ID_EXTRA = "chat_id"; @@ -37,9 +40,7 @@ public class ProfileSettingsFragment extends Fragment implements ProfileSettings private Locale locale; private ApplicationDcContext dcContext; protected int chatId; - private DcChat dcChat; private int contactId; - private DcContact dcContact; @Override public void onCreate(Bundle bundle) { @@ -50,10 +51,6 @@ public class ProfileSettingsFragment extends Fragment implements ProfileSettings chatId = getArguments().getInt(CHAT_ID_EXTRA, -1); contactId = getArguments().getInt(CONTACT_ID_EXTRA, -1); dcContext = DcHelper.getContext(getContext()); - - // if given, the ids really belong together, this is checked in ProfileActivity - if (contactId>0) { dcContact = dcContext.getContact(contactId); } - if (chatId>0) { dcChat = dcContext.getChat(chatId); } } @Override @@ -68,14 +65,34 @@ public class ProfileSettingsFragment extends Fragment implements ProfileSettings update(); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_CHAT_MODIFIED, this); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_CONTACTS_CHANGED, this); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_MSGS_CHANGED, this); + dcContext.eventCenter.addObserver(DcContext.DC_EVENT_INCOMING_MSG, this); return view; } + @Override + public void onDestroyView() { + dcContext.eventCenter.removeObservers(this); + super.onDestroyView(); + } + + @Override + public void handleEvent(int eventId, Object data1, Object data2) { + update(); + } + private void update() { int[] memberList = null; DcChatlist sharedChats = null; + DcChat dcChat = null; + DcContact dcContact = null; + if (contactId>0) { dcContact = dcContext.getContact(contactId); } + if (chatId>0) { dcChat = dcContext.getChat(chatId); } + if(dcChat!=null && dcChat.isGroup()) { memberList = dcContext.getChatContacts(chatId); } @@ -102,7 +119,7 @@ public class ProfileSettingsFragment extends Fragment implements ProfileSettings } private void onContactAddrClicked() { - String address = dcContact.getAddr(); + String address = dcContext.getContact(contactId).getAddr(); new AlertDialog.Builder(getContext()) .setTitle(address) .setItems(new CharSequence[]{ @@ -125,6 +142,7 @@ public class ProfileSettingsFragment extends Fragment implements ProfileSettings } private void onEditContactName() { + DcContact dcContact = dcContext.getContact(contactId); final EditText txt = new EditText(getActivity()); txt.setText(dcContact.getName()); new AlertDialog.Builder(getActivity()) From 308b92412e6525499dd5132428fb11eb2f8923e0 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 00:55:18 +0200 Subject: [PATCH 04/11] implement profile functions: new-chat, block-contact --- .../securesms/ProfileSettingsAdapter.java | 3 +- .../securesms/ProfileSettingsFragment.java | 46 +++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index 5b1694fef..342deb253 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -257,7 +257,8 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter } if (dcContact!=null) { - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_BLOCK_CONTACT, context.getString(R.string.menu_block_contact))); + itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_BLOCK_CONTACT, + context.getString(dcContact.isBlocked()? R.string.menu_unblock_contact : R.string.menu_block_contact))); } notifyDataSetChanged(); diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index b6d9f549b..6ebfec4e6 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -1,5 +1,6 @@ package org.thoughtcrime.securesms; +import android.content.Intent; import android.os.Bundle; import android.support.annotation.NonNull; import android.support.v4.app.Fragment; @@ -115,6 +116,12 @@ public class ProfileSettingsFragment extends Fragment case ProfileSettingsAdapter.SETTING_ENCRYPTION: onEncrInfo(); break; + case ProfileSettingsAdapter.SETTING_NEW_CHAT: + onNewChat(); + break; + case ProfileSettingsAdapter.SETTING_BLOCK_CONTACT: + onBlockContact(); + break; } } @@ -155,4 +162,43 @@ public class ProfileSettingsFragment extends Fragment .setNegativeButton(android.R.string.cancel, null) .show(); } + + private void onNewChat() { + DcContact dcContact = dcContext.getContact(contactId); + new AlertDialog.Builder(getActivity()) + .setMessage(getActivity().getString(R.string.ask_start_chat_with, dcContact.getNameNAddr())) + .setPositiveButton(android.R.string.ok, (dialog, which) -> { + int chatId = dcContext.createChatByContactId(dcContact.getId()); + if (chatId != 0) { + Intent intent = new Intent(getActivity(), ConversationActivity.class); + intent.putExtra(ConversationActivity.CHAT_ID_EXTRA, chatId); + getActivity().startActivity(intent); + getActivity().finish(); + } + }) + .setNegativeButton(R.string.cancel, null) + .show(); + } + + private void onBlockContact() { + DcContact dcContact = dcContext.getContact(contactId); + if(dcContact.isBlocked()) { + new AlertDialog.Builder(getActivity()) + .setMessage(R.string.ask_unblock_contact) + .setCancelable(true) + .setNegativeButton(android.R.string.cancel, null) + .setPositiveButton(R.string.menu_unblock_contact, (dialog, which) -> { + dcContext.blockContact(contactId, 0); + }).show(); + } + else { + new AlertDialog.Builder(getActivity()) + .setMessage(R.string.ask_block_contact) + .setCancelable(true) + .setNegativeButton(android.R.string.cancel, null) + .setPositiveButton(R.string.menu_block_contact, (dialog, which) -> { + dcContext.blockContact(contactId, 1); + }).show(); + } + } } From 670eeb01e2229858dd568e7629a57302d56dfad7 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 01:22:39 +0200 Subject: [PATCH 05/11] implement profile functions: mute, sound --- .../securesms/ProfileSettingsAdapter.java | 4 +- .../securesms/ProfileSettingsFragment.java | 69 +++++++++++++++++++ 2 files changed, 72 insertions(+), 1 deletion(-) diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index 342deb253..d8794cddf 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -18,6 +18,7 @@ import org.thoughtcrime.securesms.connect.ApplicationDcContext; import org.thoughtcrime.securesms.connect.DcHelper; import org.thoughtcrime.securesms.contacts.ContactSelectionListItem; import org.thoughtcrime.securesms.mms.GlideRequests; +import org.thoughtcrime.securesms.util.Prefs; import org.thoughtcrime.securesms.util.StickyHeaderDecoration.StickyHeaderAdapter; import java.util.ArrayList; @@ -251,7 +252,8 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter } if(dcChat!=null) { - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_NOTIFY, context.getString(R.string.pref_notifications))); + itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_NOTIFY, + context.getString(Prefs.isChatMuted(context, dcChat.getId())? R.string.menu_unmute : R.string.menu_mute))); itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_SOUND, context.getString(R.string.pref_sound))); itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_VIBRATE, context.getString(R.string.pref_vibrate))); } diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index 6ebfec4e6..891613ab2 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -1,7 +1,11 @@ package org.thoughtcrime.securesms; +import android.app.Activity; import android.content.Intent; +import android.media.RingtoneManager; +import android.net.Uri; import android.os.Bundle; +import android.provider.Settings; import android.support.annotation.NonNull; import android.support.v4.app.Fragment; import android.support.v7.app.AlertDialog; @@ -22,6 +26,7 @@ import com.b44t.messenger.DcEventCenter; import org.thoughtcrime.securesms.connect.ApplicationDcContext; import org.thoughtcrime.securesms.connect.DcHelper; import org.thoughtcrime.securesms.mms.GlideApp; +import org.thoughtcrime.securesms.util.Prefs; import org.thoughtcrime.securesms.util.StickyHeaderDecoration; import org.thoughtcrime.securesms.util.Util; import org.thoughtcrime.securesms.util.ViewUtil; @@ -35,6 +40,8 @@ public class ProfileSettingsFragment extends Fragment public static final String CHAT_ID_EXTRA = "chat_id"; public static final String CONTACT_ID_EXTRA = "contact_id"; + private static final int REQUEST_CODE_PICK_RINGTONE = 1; + private RecyclerView recyclerView; private ProfileSettingsAdapter adapter; @@ -122,6 +129,15 @@ public class ProfileSettingsFragment extends Fragment case ProfileSettingsAdapter.SETTING_BLOCK_CONTACT: onBlockContact(); break; + case ProfileSettingsAdapter.SETTING_NOTIFY: + onNotifyOnOff(); + break; + case ProfileSettingsAdapter.SETTING_SOUND: + onSoundSettings(); + break; + case ProfileSettingsAdapter.SETTING_VIBRATE: + onVibrateSettings(); + break; } } @@ -201,4 +217,57 @@ public class ProfileSettingsFragment extends Fragment }).show(); } } + + private void onNotifyOnOff() { + if (Prefs.isChatMuted(getContext(), chatId)) { + setMuted(0); + } + else { + MuteDialog.show(getActivity(), until -> setMuted(until)); + } + } + + private void setMuted(final long until) { + if(chatId!=0) { + Prefs.setChatMutedUntil(getActivity(), chatId, until); + update(); // in contrast to most other settings, muting is handled in the ui and does not result in an DC_EVENT + } + } + + private void onSoundSettings() { + Uri current = dcContext.getRecipient(dcContext.getChat(chatId)).getMessageRingtone(); + Uri defaultUri = Prefs.getNotificationRingtone(getContext()); + + if (current == null) current = Settings.System.DEFAULT_NOTIFICATION_URI; + else if (current.toString().isEmpty()) current = null; + + Intent intent = new Intent(RingtoneManager.ACTION_RINGTONE_PICKER); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_SHOW_SILENT, true); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_SHOW_DEFAULT, true); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_DEFAULT_URI, defaultUri); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_TYPE, RingtoneManager.TYPE_NOTIFICATION); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_EXISTING_URI, current); + + startActivityForResult(intent, REQUEST_CODE_PICK_RINGTONE); + + } + + @Override + public void onActivityResult(int requestCode, int resultCode, Intent data) { + super.onActivityResult(requestCode, resultCode, data); + if (requestCode == REQUEST_CODE_PICK_RINGTONE && resultCode == Activity.RESULT_OK && data != null) { + Uri value = data.getParcelableExtra(RingtoneManager.EXTRA_RINGTONE_PICKED_URI); + + Uri defaultValue = Prefs.getNotificationRingtone(getContext()); + + if (defaultValue.equals(value)) value = null; + else if (value == null) value = Uri.EMPTY; + + Prefs.setChatRingtone(getContext(), chatId, value); + } + } + + private void onVibrateSettings() { + + } } From 43d122fdfe8a43ebbf27bdcdd06f94168c51bb07 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 12:41:33 +0200 Subject: [PATCH 06/11] implement profile functions: open shared-chat, vibrate --- .../securesms/ProfileSettingsAdapter.java | 5 ++++- .../securesms/ProfileSettingsFragment.java | 17 ++++++++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index d8794cddf..1e7d6a82b 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -163,12 +163,14 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter ConversationListItem conversationListItem = (ConversationListItem) holder.itemView; int chatlistIndex = itemData.get(i).chatlistIndex; - DcChat chat = dcContext.getChat(itemDataSharedChats.getChatId(chatlistIndex)); + int chatId = itemDataSharedChats.getChatId(chatlistIndex); + DcChat chat = dcContext.getChat(chatId); DcLot summary = itemDataSharedChats.getSummary(chatlistIndex, chat); conversationListItem.bind(dcContext.getThreadRecord(summary, chat), itemDataSharedChats.getMsgId(chatlistIndex), summary, glideRequests, locale, Collections.emptySet(), false); + conversationListItem.setOnClickListener(view -> clickListener.onSharedChatClicked(chatId)); } else if(holder.itemView instanceof ProfileSettingsItem) { int settingsId = itemData.get(i).settingsId; @@ -185,6 +187,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter public interface ItemClickListener { void onSettingsClicked(int settingsId); + void onSharedChatClicked(int chatId); } @Override diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index 891613ab2..1a45780a6 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -111,6 +111,10 @@ public class ProfileSettingsFragment extends Fragment adapter.changeData(memberList, dcContact, sharedChats, dcChat); } + + // handle the various events + // ========================================================================= + @Override public void onSettingsClicked(int settingsId) { switch(settingsId) { @@ -140,6 +144,12 @@ public class ProfileSettingsFragment extends Fragment break; } } + @Override + public void onSharedChatClicked(int chatId) { + Intent intent = new Intent(getContext(), ConversationActivity.class); + intent.putExtra(ConversationActivity.CHAT_ID_EXTRA, chatId); + getContext().startActivity(intent); + } private void onContactAddrClicked() { String address = dcContext.getContact(contactId).getAddr(); @@ -268,6 +278,11 @@ public class ProfileSettingsFragment extends Fragment } private void onVibrateSettings() { - + new AlertDialog.Builder(getContext()) + .setTitle(R.string.pref_vibrate) + .setItems(R.array.recipient_vibrate_entries, (dialog, which) -> { + Prefs.setChatVibrate(getContext(), chatId, Prefs.VibrateState.fromId(which)); + }) + .show(); } } From 0ea15b738f1359dc22bb5d5fca106596bc3cf04d Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 13:34:57 +0200 Subject: [PATCH 07/11] single-click on a member can be used to start a chat --- .../securesms/ProfileSettingsAdapter.java | 12 +++++++----- .../securesms/ProfileSettingsFragment.java | 19 +++++++++++++++++++ 2 files changed, 26 insertions(+), 5 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index 1e7d6a82b..ed386f81a 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -138,26 +138,27 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter if (holder.itemView instanceof ContactSelectionListItem) { ContactSelectionListItem contactItem = (ContactSelectionListItem) holder.itemView; - int id = itemData.get(i).contactId; + int contactId = itemData.get(i).contactId; DcContact dcContact = null; String label = null; String name; String addr = null; - if (id == DcContact.DC_CONTACT_ID_ADD_MEMBER) { + if (contactId == DcContact.DC_CONTACT_ID_ADD_MEMBER) { name = context.getString(R.string.group_add_members); } - else if (id == DcContact.DC_CONTACT_ID_QR_INVITE) { + else if (contactId == DcContact.DC_CONTACT_ID_QR_INVITE) { name = context.getString(R.string.qrshow_title); } else { - dcContact = dcContext.getContact(itemData.get(i).contactId); + dcContact = dcContext.getContact(contactId); name = dcContact.getDisplayName(); addr = dcContact.getAddr(); } contactItem.unbind(glideRequests); - contactItem.set(glideRequests, id, dcContact, name, addr, label, false, true); + contactItem.set(glideRequests, contactId, dcContact, name, addr, label, false, true); + contactItem.setOnClickListener(view -> clickListener.onMemberClicked(contactId)); } else if (holder.itemView instanceof ConversationListItem) { ConversationListItem conversationListItem = (ConversationListItem) holder.itemView; @@ -188,6 +189,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter public interface ItemClickListener { void onSettingsClicked(int settingsId); void onSharedChatClicked(int chatId); + void onMemberClicked(int contactId); } @Override diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index 1a45780a6..b10e0a207 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -144,6 +144,25 @@ public class ProfileSettingsFragment extends Fragment break; } } + + @Override + public void onMemberClicked(int contactId) { + if(contactId>DcContact.DC_CONTACT_ID_LAST_SPECIAL) { + new AlertDialog.Builder(getContext()) + .setPositiveButton(android.R.string.ok, (dialog, which) -> { + int chatId = dcContext.createChatByContactId(contactId); + if( chatId != 0 ) { + Intent intent = new Intent(getContext(), ConversationActivity.class); + intent.putExtra(ConversationActivity.CHAT_ID_EXTRA, chatId); + getContext().startActivity(intent); + } + }) + .setNegativeButton(android.R.string.cancel, null) + .setMessage(getString(R.string.ask_start_chat_with, dcContext.getContact(contactId).getDisplayName())) + .show(); + } + } + @Override public void onSharedChatClicked(int chatId) { Intent intent = new Intent(getContext(), ConversationActivity.class); From de63f101a2e70e12272dc09b6ea9452b1d878cae Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 14:35:32 +0200 Subject: [PATCH 08/11] implement member-add to new profile --- .../securesms/ProfileSettingsFragment.java | 84 ++++++++++++++----- 1 file changed, 62 insertions(+), 22 deletions(-) diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index b10e0a207..0e66220b7 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -31,6 +31,8 @@ import org.thoughtcrime.securesms.util.StickyHeaderDecoration; import org.thoughtcrime.securesms.util.Util; import org.thoughtcrime.securesms.util.ViewUtil; +import java.util.ArrayList; +import java.util.List; import java.util.Locale; public class ProfileSettingsFragment extends Fragment @@ -41,8 +43,10 @@ public class ProfileSettingsFragment extends Fragment public static final String CONTACT_ID_EXTRA = "contact_id"; private static final int REQUEST_CODE_PICK_RINGTONE = 1; + private static final int REQUEST_CODE_PICK_CONTACT = 2; - private RecyclerView recyclerView; + private RecyclerView list; + private StickyHeaderDecoration listDecoration; private ProfileSettingsAdapter adapter; private Locale locale; @@ -66,10 +70,11 @@ public class ProfileSettingsFragment extends Fragment View view = inflater.inflate(R.layout.profile_settings_fragment, container, false); adapter = new ProfileSettingsAdapter(getContext(), GlideApp.with(this), locale,this); - recyclerView = ViewUtil.findById(view, R.id.recycler_view); - recyclerView.setAdapter(adapter); - recyclerView.setLayoutManager(new LinearLayoutManager(getContext(), LinearLayoutManager.VERTICAL, false)); - recyclerView.addItemDecoration(new StickyHeaderDecoration(adapter, false, true)); + list = ViewUtil.findById(view, R.id.recycler_view); + list.setAdapter(adapter); + list.setLayoutManager(new LinearLayoutManager(getContext(), LinearLayoutManager.VERTICAL, false)); + listDecoration = new StickyHeaderDecoration(adapter, false, true); + list.addItemDecoration(listDecoration); update(); @@ -109,6 +114,7 @@ public class ProfileSettingsFragment extends Fragment } adapter.changeData(memberList, dcContact, sharedChats, dcChat); + listDecoration.invalidateLayouts(); } @@ -147,7 +153,13 @@ public class ProfileSettingsFragment extends Fragment @Override public void onMemberClicked(int contactId) { - if(contactId>DcContact.DC_CONTACT_ID_LAST_SPECIAL) { + if(contactId==DcContact.DC_CONTACT_ID_ADD_MEMBER) { + onAddMember(); + } + if(contactId==DcContact.DC_CONTACT_ID_QR_INVITE) { + onQrInvite(); + } + else if(contactId>DcContact.DC_CONTACT_ID_LAST_SPECIAL) { new AlertDialog.Builder(getContext()) .setPositiveButton(android.R.string.ok, (dialog, which) -> { int chatId = dcContext.createChatByContactId(contactId); @@ -155,6 +167,7 @@ public class ProfileSettingsFragment extends Fragment Intent intent = new Intent(getContext(), ConversationActivity.class); intent.putExtra(ConversationActivity.CHAT_ID_EXTRA, chatId); getContext().startActivity(intent); + getActivity().finish(); } }) .setNegativeButton(android.R.string.cancel, null) @@ -163,11 +176,31 @@ public class ProfileSettingsFragment extends Fragment } } + public void onAddMember() { + DcChat dcChat = dcContext.getChat(chatId); + Intent intent = new Intent(getContext(), ContactMultiSelectionActivity.class); + intent.putExtra(ContactSelectionListFragment.SELECT_VERIFIED_EXTRA, dcChat.isVerified()); + ArrayList preselectedContacts = new ArrayList<>(); + int[] memberIds = dcContext.getChatContacts(chatId); + for (int memberId : memberIds) { + preselectedContacts.add(dcContext.getContact(memberId).getAddr()); + } + intent.putExtra(ContactSelectionListFragment.PRESELECTED_CONTACTS, preselectedContacts); + startActivityForResult(intent, REQUEST_CODE_PICK_CONTACT); + } + + public void onQrInvite() { + Intent qrIntent = new Intent(getContext(), QrShowActivity.class); + qrIntent.putExtra(QrShowActivity.CHAT_ID, chatId); + startActivity(qrIntent); + } + @Override public void onSharedChatClicked(int chatId) { Intent intent = new Intent(getContext(), ConversationActivity.class); intent.putExtra(ConversationActivity.CHAT_ID_EXTRA, chatId); getContext().startActivity(intent); + getActivity().finish(); } private void onContactAddrClicked() { @@ -278,22 +311,6 @@ public class ProfileSettingsFragment extends Fragment intent.putExtra(RingtoneManager.EXTRA_RINGTONE_EXISTING_URI, current); startActivityForResult(intent, REQUEST_CODE_PICK_RINGTONE); - - } - - @Override - public void onActivityResult(int requestCode, int resultCode, Intent data) { - super.onActivityResult(requestCode, resultCode, data); - if (requestCode == REQUEST_CODE_PICK_RINGTONE && resultCode == Activity.RESULT_OK && data != null) { - Uri value = data.getParcelableExtra(RingtoneManager.EXTRA_RINGTONE_PICKED_URI); - - Uri defaultValue = Prefs.getNotificationRingtone(getContext()); - - if (defaultValue.equals(value)) value = null; - else if (value == null) value = Uri.EMPTY; - - Prefs.setChatRingtone(getContext(), chatId, value); - } } private void onVibrateSettings() { @@ -304,4 +321,27 @@ public class ProfileSettingsFragment extends Fragment }) .show(); } + + @Override + public void onActivityResult(int requestCode, int resultCode, Intent data) { + super.onActivityResult(requestCode, resultCode, data); + if (requestCode==REQUEST_CODE_PICK_RINGTONE && resultCode==Activity.RESULT_OK && data!=null) { + Uri value = data.getParcelableExtra(RingtoneManager.EXTRA_RINGTONE_PICKED_URI); + Uri defaultValue = Prefs.getNotificationRingtone(getContext()); + + if (defaultValue.equals(value)) value = null; + else if (value == null) value = Uri.EMPTY; + + Prefs.setChatRingtone(getContext(), chatId, value); + } + else if (requestCode==REQUEST_CODE_PICK_CONTACT && resultCode==Activity.RESULT_OK && data!=null) { + List selected = data.getStringArrayListExtra("contacts"); + for (String addr : selected) { + if (addr!=null) { + int toAddId = dcContext.createContact(null, addr); + dcContext.addContactToChat(chatId, toAddId); + } + } + } + } } From a17cfccba4fce3589594072efd59803adef8fe9f Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 16:05:15 +0200 Subject: [PATCH 09/11] remove members in new profile --- res/values/strings.xml | 2 + .../securesms/ProfileDocumentsAdapter.java | 3 - .../securesms/ProfileSettingsAdapter.java | 28 ++++++ .../securesms/ProfileSettingsFragment.java | 96 ++++++++++++++++++- 4 files changed, 124 insertions(+), 5 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 6e3658612..7319a468a 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -184,6 +184,8 @@ Delete contacts? This will permanently delete the selected contacts.\n\nContacts with ongoing chats and contacts from the system\'s address book cannot be deleted permanently. Cannot delete contacts with ongoing chats. Chat with %1$s? + + Remove %1$s from group? diff --git a/src/org/thoughtcrime/securesms/ProfileDocumentsAdapter.java b/src/org/thoughtcrime/securesms/ProfileDocumentsAdapter.java index 270644ddf..6dea8e7ef 100644 --- a/src/org/thoughtcrime/securesms/ProfileDocumentsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileDocumentsAdapter.java @@ -1,7 +1,6 @@ package org.thoughtcrime.securesms; import android.content.Context; -import android.content.Intent; import android.support.annotation.NonNull; import android.view.LayoutInflater; import android.view.View; @@ -13,8 +12,6 @@ import com.codewaves.stickyheadergrid.StickyHeaderGridAdapter; import org.thoughtcrime.securesms.components.AudioView; import org.thoughtcrime.securesms.components.DocumentView; -import org.thoughtcrime.securesms.connect.ApplicationDcContext; -import org.thoughtcrime.securesms.connect.DcHelper; import org.thoughtcrime.securesms.database.loaders.BucketedThreadMediaLoader.BucketedThreadMedia; import org.thoughtcrime.securesms.mms.AudioSlide; import org.thoughtcrime.securesms.mms.DocumentSlide; diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index ed386f81a..a0e79c76f 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -22,8 +22,11 @@ import org.thoughtcrime.securesms.util.Prefs; import org.thoughtcrime.securesms.util.StickyHeaderDecoration.StickyHeaderAdapter; import java.util.ArrayList; +import java.util.Collection; import java.util.Collections; +import java.util.HashSet; import java.util.Locale; +import java.util.Set; public class ProfileSettingsAdapter extends RecyclerView.Adapter implements StickyHeaderAdapter @@ -48,6 +51,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter private int itemDataMemberCount; private DcChatlist itemDataSharedChats; private DcContact itemDataContact; + private final Set selectedMembers; private final LayoutInflater layoutInflater; private final ItemClickListener clickListener; @@ -93,6 +97,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter this.clickListener = clickListener; this.dcContext = DcHelper.getContext(context); this.layoutInflater = LayoutInflater.from(context); + this.selectedMembers= new HashSet<>(); } @Override @@ -158,7 +163,9 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter contactItem.unbind(glideRequests); contactItem.set(glideRequests, contactId, dcContact, name, addr, label, false, true); + contactItem.setSelected(selectedMembers.contains(contactId)); contactItem.setOnClickListener(view -> clickListener.onMemberClicked(contactId)); + contactItem.setOnLongClickListener(view -> {clickListener.onMemberLongClicked(contactId); return true;}); } else if (holder.itemView instanceof ConversationListItem) { ConversationListItem conversationListItem = (ConversationListItem) holder.itemView; @@ -190,6 +197,7 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter void onSettingsClicked(int settingsId); void onSharedChatClicked(int chatId); void onMemberClicked(int contactId); + void onMemberLongClicked(int contactId); } @Override @@ -227,6 +235,26 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter viewHolder.textView.setText(txt); } + public void toggleMemberSelection(int contactId) { + if (!selectedMembers.remove(contactId)) { + selectedMembers.add(contactId); + } + notifyDataSetChanged(); + } + + @NonNull + public Collection getSelectedMembers() { + return new HashSet<>(selectedMembers); + } + + public int getSelectedMembersCount() { + return selectedMembers.size(); + } + + public void clearSelection() { + selectedMembers.clear(); + notifyDataSetChanged(); + } public void changeData(@Nullable int[] memberList, @Nullable DcContact dcContact, @Nullable DcChatlist sharedChats, @Nullable DcChat dcChat) { itemData.clear(); diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index 0e66220b7..0910e3240 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -4,16 +4,22 @@ import android.app.Activity; import android.content.Intent; import android.media.RingtoneManager; import android.net.Uri; +import android.os.Build; import android.os.Bundle; import android.provider.Settings; import android.support.annotation.NonNull; import android.support.v4.app.Fragment; import android.support.v7.app.AlertDialog; +import android.support.v7.app.AppCompatActivity; +import android.support.v7.view.ActionMode; import android.support.v7.widget.LinearLayoutManager; import android.support.v7.widget.RecyclerView; import android.view.LayoutInflater; +import android.view.Menu; +import android.view.MenuItem; import android.view.View; import android.view.ViewGroup; +import android.view.Window; import android.widget.EditText; import android.widget.Toast; @@ -32,6 +38,7 @@ import org.thoughtcrime.securesms.util.Util; import org.thoughtcrime.securesms.util.ViewUtil; import java.util.ArrayList; +import java.util.Collection; import java.util.List; import java.util.Locale; @@ -48,6 +55,9 @@ public class ProfileSettingsFragment extends Fragment private RecyclerView list; private StickyHeaderDecoration listDecoration; private ProfileSettingsAdapter adapter; + private ActionMode actionMode; + private ActionModeCallback actionModeCallback = new ActionModeCallback(); + private Locale locale; private ApplicationDcContext dcContext; @@ -151,12 +161,35 @@ public class ProfileSettingsFragment extends Fragment } } + @Override + public void onMemberLongClicked(int contactId) { + if (contactId>DcContact.DC_CONTACT_ID_LAST_SPECIAL || contactId==DcContact.DC_CONTACT_ID_SELF) { + if (actionMode==null) { + adapter.toggleMemberSelection(contactId); + actionMode = ((AppCompatActivity) getActivity()).startSupportActionMode(actionModeCallback); + } else { + onMemberClicked(contactId); + } + } + } + @Override public void onMemberClicked(int contactId) { - if(contactId==DcContact.DC_CONTACT_ID_ADD_MEMBER) { + if (actionMode!=null) { + if (contactId>DcContact.DC_CONTACT_ID_LAST_SPECIAL || contactId==DcContact.DC_CONTACT_ID_SELF) { + adapter.toggleMemberSelection(contactId); + if (adapter.getSelectedMembersCount() == 0) { + actionMode.finish(); + actionMode = null; + } else { + actionMode.setTitle(String.valueOf(adapter.getSelectedMembersCount())); + } + } + } + else if(contactId==DcContact.DC_CONTACT_ID_ADD_MEMBER) { onAddMember(); } - if(contactId==DcContact.DC_CONTACT_ID_QR_INVITE) { + else if(contactId==DcContact.DC_CONTACT_ID_QR_INVITE) { onQrInvite(); } else if(contactId>DcContact.DC_CONTACT_ID_LAST_SPECIAL) { @@ -322,6 +355,65 @@ public class ProfileSettingsFragment extends Fragment .show(); } + private class ActionModeCallback implements ActionMode.Callback { + + private int originalStatusBarColor; + + @Override + public boolean onCreateActionMode(ActionMode mode, Menu menu) { + mode.getMenuInflater().inflate(R.menu.profile_context, menu); + mode.setTitle("1"); + + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { + Window window = getActivity().getWindow(); + originalStatusBarColor = window.getStatusBarColor(); + window.setStatusBarColor(getResources().getColor(R.color.action_mode_status_bar)); + } + return true; + } + + @Override + public boolean onPrepareActionMode(ActionMode mode, Menu menu) { + return false; + } + + @Override + public boolean onActionItemClicked(ActionMode mode, MenuItem menuItem) { + switch (menuItem.getItemId()) { + case R.id.delete: + final Collection toDelIds = adapter.getSelectedMembers(); + StringBuilder readableToDelList = new StringBuilder(); + for (Integer toDelId : toDelIds) { + if(readableToDelList.length()>0) { + readableToDelList.append(", "); + } + readableToDelList.append(dcContext.getContact(toDelId).getDisplayName()); + } + new AlertDialog.Builder(getContext()) + .setPositiveButton(android.R.string.ok, (dialog, which) -> { + for (Integer toDelId : toDelIds) { + dcContext.removeContactFromChat(chatId, toDelId); + } + mode.finish(); + }) + .setNegativeButton(android.R.string.cancel, null) + .setMessage(getString(R.string.ask_remove_members, readableToDelList)) + .show(); + return true; + } + return false; + } + + @Override + public void onDestroyActionMode(ActionMode mode) { + actionMode = null; + adapter.clearSelection(); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { + getActivity().getWindow().setStatusBarColor(originalStatusBarColor); + } + } + } + @Override public void onActivityResult(int requestCode, int resultCode, Intent data) { super.onActivityResult(requestCode, resultCode, data); From f59687d6afb20a81d90045c7a106d51a56b3def2 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 18:38:53 +0200 Subject: [PATCH 10/11] cleanup, move several options to the more visible menu --- res/menu/profile_chat.xml | 22 ++ res/menu/profile_contact.xml | 18 ++ res/values/strings.xml | 1 + .../securesms/ProfileActivity.java | 193 ++++++++++++++++-- .../securesms/ProfileSettingsAdapter.java | 26 +-- .../securesms/ProfileSettingsFragment.java | 122 ++--------- 6 files changed, 247 insertions(+), 135 deletions(-) create mode 100644 res/menu/profile_chat.xml create mode 100644 res/menu/profile_contact.xml diff --git a/res/menu/profile_chat.xml b/res/menu/profile_chat.xml new file mode 100644 index 000000000..0fcaa467e --- /dev/null +++ b/res/menu/profile_chat.xml @@ -0,0 +1,22 @@ + + + + + + + + + + + + + diff --git a/res/menu/profile_contact.xml b/res/menu/profile_contact.xml new file mode 100644 index 000000000..bd7d92a5a --- /dev/null +++ b/res/menu/profile_contact.xml @@ -0,0 +1,18 @@ + + + + + + + + + + + diff --git a/res/values/strings.xml b/res/values/strings.xml index 7319a468a..c54b2dea0 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -251,6 +251,7 @@ Shared chats Contact Group + Members Gallery Docs Links diff --git a/src/org/thoughtcrime/securesms/ProfileActivity.java b/src/org/thoughtcrime/securesms/ProfileActivity.java index 97c133566..9be7722f6 100644 --- a/src/org/thoughtcrime/securesms/ProfileActivity.java +++ b/src/org/thoughtcrime/securesms/ProfileActivity.java @@ -1,13 +1,22 @@ package org.thoughtcrime.securesms; +import android.app.Activity; +import android.content.Intent; +import android.media.RingtoneManager; +import android.net.Uri; import android.os.Bundle; +import android.provider.Settings; import android.support.design.widget.TabLayout; import android.support.v4.app.Fragment; import android.support.v4.app.FragmentManager; import android.support.v4.app.FragmentStatePagerAdapter; import android.support.v4.view.ViewPager; +import android.support.v7.app.AlertDialog; import android.support.v7.widget.Toolbar; +import android.view.Menu; +import android.view.MenuInflater; import android.view.MenuItem; +import android.widget.EditText; import com.b44t.messenger.DcChat; import com.b44t.messenger.DcContact; @@ -19,9 +28,11 @@ import org.thoughtcrime.securesms.connect.DcHelper; import org.thoughtcrime.securesms.util.DynamicLanguage; import org.thoughtcrime.securesms.util.DynamicNoActionBarTheme; import org.thoughtcrime.securesms.util.DynamicTheme; +import org.thoughtcrime.securesms.util.Prefs; import org.thoughtcrime.securesms.util.ViewUtil; import java.util.ArrayList; +import java.util.List; public class ProfileActivity extends PassphraseRequiredActionBarActivity implements DcEventCenter.DcEventDelegate @@ -40,6 +51,8 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity public static final int TAB_LINKS = 40; public static final int TAB_MAP = 50; + private static final int REQUEST_CODE_PICK_RINGTONE = 1; + private final DynamicTheme dynamicTheme = new DynamicNoActionBarTheme(); private final DynamicLanguage dynamicLanguage = new DynamicLanguage(); @@ -73,6 +86,25 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity dcContext.eventCenter.addObserver(DcContext.DC_EVENT_CONTACTS_CHANGED, this); } + @Override + public boolean onCreateOptionsMenu(Menu menu) { + MenuInflater inflater = getMenuInflater(); + + if (chatId!=0) { + inflater.inflate(R.menu.profile_chat, menu); + if(!chatIsGroup) { + menu.findItem(R.id.edit_group_name_and_image).setVisible(false); + } + } + + if (isContactProfile()) { + inflater.inflate(R.menu.profile_contact, menu); + } + + super.onCreateOptionsMenu(menu); + return true; + } + @Override public void onResume() { super.onResume(); @@ -86,17 +118,6 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity super.onDestroy(); } - @Override - public boolean onOptionsItemSelected(MenuItem item) { - super.onOptionsItemSelected(item); - - switch (item.getItemId()) { - case android.R.id.home: finish(); return true; - } - - return false; - } - @Override public void handleEvent(int eventId, Object data1, Object data2) { updateToolbar(); @@ -217,7 +238,7 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity return getString(contactId==DcContact.DC_CONTACT_ID_SELF? R.string.self : R.string.tab_contact); } else { - return getString(R.string.tab_group); + return getString(R.string.tab_members); } case TAB_GALLERY: @@ -237,4 +258,152 @@ public class ProfileActivity extends PassphraseRequiredActionBarActivity } } } + + + // handle events + // ========================================================================= + + @Override + public boolean onOptionsItemSelected(MenuItem item) { + super.onOptionsItemSelected(item); + + switch (item.getItemId()) { + case android.R.id.home: + finish(); + return true; + case R.id.menu_mute_notifications: + onNotifyOnOff(); + break; + case R.id.menu_sound: + onSoundSettings(); + break; + case R.id.menu_vibrate: + onVibrateSettings(); + break; + case R.id.edit_group_name_and_image: + onEditGroupNameAndImage(); + break; + case R.id.edit_contact_name: + onEditContactName(); + break; + case R.id.show_encr_info: + onEncrInfo(); + break; + case R.id.block_contact: + onBlockContact(); + break; + } + + return false; + } + + public void onNotifyOnOff() { + if (Prefs.isChatMuted(this, chatId)) { + setMuted(0); + } + else { + MuteDialog.show(this, until -> setMuted(until)); + } + } + + private void setMuted(final long until) { + if(chatId!=0) { + Prefs.setChatMutedUntil(this, chatId, until); + } + } + + public void onSoundSettings() { + Uri current = dcContext.getRecipient(dcContext.getChat(chatId)).getMessageRingtone(); + Uri defaultUri = Prefs.getNotificationRingtone(this); + + if (current == null) current = Settings.System.DEFAULT_NOTIFICATION_URI; + else if (current.toString().isEmpty()) current = null; + + Intent intent = new Intent(RingtoneManager.ACTION_RINGTONE_PICKER); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_SHOW_SILENT, true); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_SHOW_DEFAULT, true); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_DEFAULT_URI, defaultUri); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_TYPE, RingtoneManager.TYPE_NOTIFICATION); + intent.putExtra(RingtoneManager.EXTRA_RINGTONE_EXISTING_URI, current); + + startActivityForResult(intent, REQUEST_CODE_PICK_RINGTONE); + } + + public void onVibrateSettings() { + new AlertDialog.Builder(this) + .setTitle(R.string.pref_vibrate) + .setItems(R.array.recipient_vibrate_entries, (dialog, which) -> { + Prefs.setChatVibrate(this, chatId, Prefs.VibrateState.fromId(which)); + }) + .show(); + } + + public void onEditGroupNameAndImage() { + Intent intent = new Intent(this, GroupCreateActivity.class); + intent.putExtra(GroupCreateActivity.EDIT_GROUP_CHAT_ID, chatId); + if (dcContext.getChat(chatId).isVerified()) { + intent.putExtra(GroupCreateActivity.GROUP_CREATE_VERIFIED_EXTRA, true); + } + startActivity(intent); + } + + public void onEditContactName() { + DcContact dcContact = dcContext.getContact(contactId); + final EditText txt = new EditText(this); + txt.setText(dcContact.getName()); + new AlertDialog.Builder(this) + .setTitle(R.string.menu_edit_name) + .setView(txt) + .setPositiveButton(android.R.string.ok, (dialog, whichButton) -> { + String newName = txt.getText().toString(); + dcContext.createContact(newName, dcContact.getAddr()); + }) + .setNegativeButton(android.R.string.cancel, null) + .show(); + } + + public void onEncrInfo() { + String info_str = dcContext.getContactEncrInfo(contactId); + new AlertDialog.Builder(this) + .setMessage(info_str) + .setPositiveButton(android.R.string.ok, null) + .show(); + } + + public void onBlockContact() { + DcContact dcContact = dcContext.getContact(contactId); + if(dcContact.isBlocked()) { + new AlertDialog.Builder(this) + .setMessage(R.string.ask_unblock_contact) + .setCancelable(true) + .setNegativeButton(android.R.string.cancel, null) + .setPositiveButton(R.string.menu_unblock_contact, (dialog, which) -> { + dcContext.blockContact(contactId, 0); + }).show(); + } + else { + new AlertDialog.Builder(this) + .setMessage(R.string.ask_block_contact) + .setCancelable(true) + .setNegativeButton(android.R.string.cancel, null) + .setPositiveButton(R.string.menu_block_contact, (dialog, which) -> { + dcContext.blockContact(contactId, 1); + }).show(); + } + } + + @Override + public void onActivityResult(int requestCode, int resultCode, Intent data) { + super.onActivityResult(requestCode, resultCode, data); + if (requestCode==REQUEST_CODE_PICK_RINGTONE && resultCode== Activity.RESULT_OK && data!=null) { + Uri value = data.getParcelableExtra(RingtoneManager.EXTRA_RINGTONE_PICKED_URI); + Uri defaultValue = Prefs.getNotificationRingtone(this); + + if (defaultValue.equals(value)) value = null; + else if (value == null) value = Uri.EMPTY; + + Prefs.setChatRingtone(this, chatId, value); + } + } + } diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java index a0e79c76f..95774a30a 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsAdapter.java @@ -269,13 +269,13 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter for (int i = 0; i < memberList.length; i++) { itemData.add(new ItemData(ItemData.TYPE_MEMBER, memberList[i], 0)); } - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_GROUP_NAME_N_IMAGE, context.getString(R.string.menu_group_name_and_image))); +// itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_GROUP_NAME_N_IMAGE, context.getString(R.string.menu_group_name_and_image))); } else if (sharedChats!=null && dcContact!=null) { itemDataContact = dcContact; itemData.add(new ItemData(ItemData.TYPE_PRIMARY_SETTING, SETTING_CONTACT_ADDR,dcContact.getAddr())); - itemData.add(new ItemData(ItemData.TYPE_PRIMARY_SETTING, SETTING_CONTACT_NAME, context.getString(R.string.menu_edit_name))); - itemData.add(new ItemData(ItemData.TYPE_PRIMARY_SETTING, SETTING_ENCRYPTION, context.getString(R.string.profile_encryption))); +// itemData.add(new ItemData(ItemData.TYPE_PRIMARY_SETTING, SETTING_CONTACT_NAME, context.getString(R.string.menu_edit_name))); +// itemData.add(new ItemData(ItemData.TYPE_PRIMARY_SETTING, SETTING_ENCRYPTION, context.getString(R.string.profile_encryption))); itemData.add(new ItemData(ItemData.TYPE_PRIMARY_SETTING, SETTING_NEW_CHAT, context.getString(R.string.menu_new_chat))); itemDataSharedChats = sharedChats; int sharedChatsCnt = sharedChats.getCnt(); @@ -284,17 +284,17 @@ public class ProfileSettingsAdapter extends RecyclerView.Adapter } } - if(dcChat!=null) { - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_NOTIFY, - context.getString(Prefs.isChatMuted(context, dcChat.getId())? R.string.menu_unmute : R.string.menu_mute))); - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_SOUND, context.getString(R.string.pref_sound))); - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_VIBRATE, context.getString(R.string.pref_vibrate))); - } +// if(dcChat!=null) { +// itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_NOTIFY, +// context.getString(Prefs.isChatMuted(context, dcChat.getId())? R.string.menu_unmute : R.string.menu_mute))); +// itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_SOUND, context.getString(R.string.pref_sound))); +// itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_VIBRATE, context.getString(R.string.pref_vibrate))); +// } - if (dcContact!=null) { - itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_BLOCK_CONTACT, - context.getString(dcContact.isBlocked()? R.string.menu_unblock_contact : R.string.menu_block_contact))); - } +// if (dcContact!=null) { +// itemData.add(new ItemData(ItemData.TYPE_SECONDARY_SETTING, SETTING_BLOCK_CONTACT, +// context.getString(dcContact.isBlocked()? R.string.menu_unblock_contact : R.string.menu_block_contact))); +// } notifyDataSetChanged(); } diff --git a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java index 0910e3240..6acdc79fb 100644 --- a/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java +++ b/src/org/thoughtcrime/securesms/ProfileSettingsFragment.java @@ -6,7 +6,6 @@ import android.media.RingtoneManager; import android.net.Uri; import android.os.Build; import android.os.Bundle; -import android.provider.Settings; import android.support.annotation.NonNull; import android.support.v4.app.Fragment; import android.support.v7.app.AlertDialog; @@ -49,7 +48,6 @@ public class ProfileSettingsFragment extends Fragment public static final String CHAT_ID_EXTRA = "chat_id"; public static final String CONTACT_ID_EXTRA = "contact_id"; - private static final int REQUEST_CODE_PICK_RINGTONE = 1; private static final int REQUEST_CODE_PICK_CONTACT = 2; private RecyclerView list; @@ -128,7 +126,7 @@ public class ProfileSettingsFragment extends Fragment } - // handle the various events + // handle events // ========================================================================= @Override @@ -137,26 +135,26 @@ public class ProfileSettingsFragment extends Fragment case ProfileSettingsAdapter.SETTING_CONTACT_ADDR: onContactAddrClicked(); break; - case ProfileSettingsAdapter.SETTING_CONTACT_NAME: - onEditContactName(); - break; - case ProfileSettingsAdapter.SETTING_ENCRYPTION: - onEncrInfo(); - break; case ProfileSettingsAdapter.SETTING_NEW_CHAT: onNewChat(); break; + case ProfileSettingsAdapter.SETTING_CONTACT_NAME: + ((ProfileActivity)getActivity()).onEditContactName(); + break; + case ProfileSettingsAdapter.SETTING_ENCRYPTION: + ((ProfileActivity)getActivity()).onEncrInfo(); + break; case ProfileSettingsAdapter.SETTING_BLOCK_CONTACT: - onBlockContact(); + ((ProfileActivity)getActivity()).onBlockContact(); break; case ProfileSettingsAdapter.SETTING_NOTIFY: - onNotifyOnOff(); + ((ProfileActivity)getActivity()).onNotifyOnOff(); break; case ProfileSettingsAdapter.SETTING_SOUND: - onSoundSettings(); + ((ProfileActivity)getActivity()).onSoundSettings(); break; case ProfileSettingsAdapter.SETTING_VIBRATE: - onVibrateSettings(); + ((ProfileActivity)getActivity()).onVibrateSettings(); break; } } @@ -251,29 +249,6 @@ public class ProfileSettingsFragment extends Fragment .show(); } - private void onEncrInfo() { - String info_str = dcContext.getContactEncrInfo(contactId); - new AlertDialog.Builder(getActivity()) - .setMessage(info_str) - .setPositiveButton(android.R.string.ok, null) - .show(); - } - - private void onEditContactName() { - DcContact dcContact = dcContext.getContact(contactId); - final EditText txt = new EditText(getActivity()); - txt.setText(dcContact.getName()); - new AlertDialog.Builder(getActivity()) - .setTitle(R.string.menu_edit_name) - .setView(txt) - .setPositiveButton(android.R.string.ok, (dialog, whichButton) -> { - String newName = txt.getText().toString(); - dcContext.createContact(newName, dcContact.getAddr()); - }) - .setNegativeButton(android.R.string.cancel, null) - .show(); - } - private void onNewChat() { DcContact dcContact = dcContext.getContact(contactId); new AlertDialog.Builder(getActivity()) @@ -291,70 +266,6 @@ public class ProfileSettingsFragment extends Fragment .show(); } - private void onBlockContact() { - DcContact dcContact = dcContext.getContact(contactId); - if(dcContact.isBlocked()) { - new AlertDialog.Builder(getActivity()) - .setMessage(R.string.ask_unblock_contact) - .setCancelable(true) - .setNegativeButton(android.R.string.cancel, null) - .setPositiveButton(R.string.menu_unblock_contact, (dialog, which) -> { - dcContext.blockContact(contactId, 0); - }).show(); - } - else { - new AlertDialog.Builder(getActivity()) - .setMessage(R.string.ask_block_contact) - .setCancelable(true) - .setNegativeButton(android.R.string.cancel, null) - .setPositiveButton(R.string.menu_block_contact, (dialog, which) -> { - dcContext.blockContact(contactId, 1); - }).show(); - } - } - - private void onNotifyOnOff() { - if (Prefs.isChatMuted(getContext(), chatId)) { - setMuted(0); - } - else { - MuteDialog.show(getActivity(), until -> setMuted(until)); - } - } - - private void setMuted(final long until) { - if(chatId!=0) { - Prefs.setChatMutedUntil(getActivity(), chatId, until); - update(); // in contrast to most other settings, muting is handled in the ui and does not result in an DC_EVENT - } - } - - private void onSoundSettings() { - Uri current = dcContext.getRecipient(dcContext.getChat(chatId)).getMessageRingtone(); - Uri defaultUri = Prefs.getNotificationRingtone(getContext()); - - if (current == null) current = Settings.System.DEFAULT_NOTIFICATION_URI; - else if (current.toString().isEmpty()) current = null; - - Intent intent = new Intent(RingtoneManager.ACTION_RINGTONE_PICKER); - intent.putExtra(RingtoneManager.EXTRA_RINGTONE_SHOW_SILENT, true); - intent.putExtra(RingtoneManager.EXTRA_RINGTONE_SHOW_DEFAULT, true); - intent.putExtra(RingtoneManager.EXTRA_RINGTONE_DEFAULT_URI, defaultUri); - intent.putExtra(RingtoneManager.EXTRA_RINGTONE_TYPE, RingtoneManager.TYPE_NOTIFICATION); - intent.putExtra(RingtoneManager.EXTRA_RINGTONE_EXISTING_URI, current); - - startActivityForResult(intent, REQUEST_CODE_PICK_RINGTONE); - } - - private void onVibrateSettings() { - new AlertDialog.Builder(getContext()) - .setTitle(R.string.pref_vibrate) - .setItems(R.array.recipient_vibrate_entries, (dialog, which) -> { - Prefs.setChatVibrate(getContext(), chatId, Prefs.VibrateState.fromId(which)); - }) - .show(); - } - private class ActionModeCallback implements ActionMode.Callback { private int originalStatusBarColor; @@ -417,16 +328,7 @@ public class ProfileSettingsFragment extends Fragment @Override public void onActivityResult(int requestCode, int resultCode, Intent data) { super.onActivityResult(requestCode, resultCode, data); - if (requestCode==REQUEST_CODE_PICK_RINGTONE && resultCode==Activity.RESULT_OK && data!=null) { - Uri value = data.getParcelableExtra(RingtoneManager.EXTRA_RINGTONE_PICKED_URI); - Uri defaultValue = Prefs.getNotificationRingtone(getContext()); - - if (defaultValue.equals(value)) value = null; - else if (value == null) value = Uri.EMPTY; - - Prefs.setChatRingtone(getContext(), chatId, value); - } - else if (requestCode==REQUEST_CODE_PICK_CONTACT && resultCode==Activity.RESULT_OK && data!=null) { + if (requestCode==REQUEST_CODE_PICK_CONTACT && resultCode==Activity.RESULT_OK && data!=null) { List selected = data.getStringArrayListExtra("contacts"); for (String addr : selected) { if (addr!=null) { From 074ae9f4a39b7313890dbf7c2c208c54939f2f93 Mon Sep 17 00:00:00 2001 From: "B. Petersen" Date: Thu, 23 May 2019 20:03:13 +0200 Subject: [PATCH 11/11] use a simple fade animation to bind the profile closer to the chat --- res/anim/fade_in.xml | 9 +++++++++ res/anim/fade_out.xml | 9 +++++++++ src/org/thoughtcrime/securesms/ConversationActivity.java | 1 + 3 files changed, 19 insertions(+) create mode 100644 res/anim/fade_in.xml create mode 100644 res/anim/fade_out.xml diff --git a/res/anim/fade_in.xml b/res/anim/fade_in.xml new file mode 100644 index 000000000..8c8557d88 --- /dev/null +++ b/res/anim/fade_in.xml @@ -0,0 +1,9 @@ + + + + + \ No newline at end of file diff --git a/res/anim/fade_out.xml b/res/anim/fade_out.xml new file mode 100644 index 000000000..09beb8382 --- /dev/null +++ b/res/anim/fade_out.xml @@ -0,0 +1,9 @@ + + + + + \ No newline at end of file diff --git a/src/org/thoughtcrime/securesms/ConversationActivity.java b/src/org/thoughtcrime/securesms/ConversationActivity.java index 17d3ead42..4fb479510 100644 --- a/src/org/thoughtcrime/securesms/ConversationActivity.java +++ b/src/org/thoughtcrime/securesms/ConversationActivity.java @@ -542,6 +542,7 @@ public class ConversationActivity extends PassphraseRequiredActionBarActivity Intent intent = new Intent(this, ProfileActivity.class); intent.putExtra(ProfileActivity.CHAT_ID_EXTRA, chatId); startActivity(intent); + overridePendingTransition(R.anim.fade_in, R.anim.fade_out); } }