From 56b925f6000b72ac7696c646b4e7187c04f24178 Mon Sep 17 00:00:00 2001 From: Hocuri Date: Sat, 24 Aug 2024 21:47:11 +0200 Subject: [PATCH 1/2] Increase account switcher hitbox The hitbox for the account switcher was only the own avatar in and the title, so when you tapped a bit too low or too high, nothing happened. This PR changes it to be the whole title bar. --- .../org/thoughtcrime/securesms/ConversationListActivity.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java b/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java index 1e1e7aaa8..efbb54733 100644 --- a/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java +++ b/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java @@ -182,8 +182,7 @@ public class ConversationListActivity extends PassphraseRequiredActionBarActivit TooltipCompat.setTooltipText(searchAction, getText(R.string.search_explain)); TooltipCompat.setTooltipText(selfAvatar, getText(R.string.switch_account)); - selfAvatar.setOnClickListener(v -> AccountManager.getInstance().showSwitchAccountMenu(this)); - title.setOnClickListener(v -> { + toolbar.setOnClickListener(v -> { if (!isRelayingMessageContent(this)) { AccountManager.getInstance().showSwitchAccountMenu(this); } From 59435e8975fc548dbf96dc987f03594a95bcb27f Mon Sep 17 00:00:00 2001 From: Hocuri Date: Mon, 26 Aug 2024 22:32:49 +0200 Subject: [PATCH 2/2] Don't count taps that are too far to the right --- .../securesms/ConversationListActivity.java | 2 +- .../res/layout/conversation_list_activity.xml | 94 ++++++++++--------- 2 files changed, 53 insertions(+), 43 deletions(-) diff --git a/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java b/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java index efbb54733..d5f281177 100644 --- a/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java +++ b/src/main/java/org/thoughtcrime/securesms/ConversationListActivity.java @@ -182,7 +182,7 @@ public class ConversationListActivity extends PassphraseRequiredActionBarActivit TooltipCompat.setTooltipText(searchAction, getText(R.string.search_explain)); TooltipCompat.setTooltipText(selfAvatar, getText(R.string.switch_account)); - toolbar.setOnClickListener(v -> { + findViewById(R.id.avatar_and_title).setOnClickListener(v -> { if (!isRelayingMessageContent(this)) { AccountManager.getInstance().showSwitchAccountMenu(this); } diff --git a/src/main/res/layout/conversation_list_activity.xml b/src/main/res/layout/conversation_list_activity.xml index 4a8136aaf..fc0cbb080 100644 --- a/src/main/res/layout/conversation_list_activity.xml +++ b/src/main/res/layout/conversation_list_activity.xml @@ -14,8 +14,8 @@ android:layout_height="?attr/actionBarSize" android:minHeight="?attr/actionBarSize" android:background="?attr/colorPrimary" - app:contentInsetStart="14dp" - app:contentInsetLeft="14dp" + app:contentInsetStart="0dp" + app:contentInsetLeft="0dp" android:elevation="4dp" android:theme="?attr/actionBarStyle"> @@ -24,47 +24,57 @@ android:layout_width="match_parent" android:layout_height="match_parent"> - - - - + - + + + + + + +