mirror of
https://github.com/meshtastic/Meshtastic-Android.git
synced 2026-07-03 14:06:34 +02:00
9e887ed92a
Review feedback (design#113): the green SNR/RSSI text and the signed shield sit on a per-node-tinted message bubble, where the shared "Status Good" green has poor contrast (worst in light mode) — an accessibility/readability problem. The black message text is fine because it derives from the bubble's content color; the green metadata did not. Fix is scoped to the bubble — the shared StatusGreen token is used in ~15 components, almost all on the neutral theme surface where it's fine, so changing the token globally would be the wrong lever. Instead: - Add ensureContrastOn(background): nudges a color toward black/white just enough to meet WCAG AA against a given background, preserving hue (picks the higher-contrast direction, so a mid-tone bubble darkens the green rather than washing it to white). Unit-tested. - Snr/Rssi/SnrAndRssi gain an optional `background` param (default null = unchanged everywhere else — no blast radius). - MessageItem passes the composited bubble background so SNR, RSSI, and the signed shield all stay legible; shield unified onto the same contrast-adjusted StatusGreen. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
:feature:messaging
Overview
The :feature:messaging module handles the core communication features of the app, including text messages, direct messages (DMs), and channel-based chat.
Key Components
1. MessageViewModel
Manages the state of the chat screen, including loading messages from the database, sending new messages, and handling message reactions.
2. QuickChat
A simplified chat interface for quickly sending and receiving messages without entering the full message screen.
3. HomoglyphCharacterStringTransformer
A security-focused utility that detects and transforms homoglyphs (visually similar characters from different scripts) to prevent phishing and impersonation attacks.
Features
- Channel Chat: Group communication on public or private channels.
- Direct Messaging: One-on-one encrypted communication between nodes.
- Message Reactions: Support for reacting to messages with emojis.
- Delivery Status: Indicators for "Sent", "Received", and "Read" (ACK/NACK).
Dependency Graph
graph TB
:feature:messaging[messaging]:::kmp-feature
:feature:messaging -.-> :core:common
:feature:messaging -.-> :core:data
:feature:messaging -.-> :core:database
:feature:messaging -.-> :core:domain
:feature:messaging -.-> :core:model
:feature:messaging -.-> :core:navigation
:feature:messaging -.-> :core:prefs
:feature:messaging -.-> :core:resources
:feature:messaging -.-> :core:service
:feature:messaging -.-> :core:ui
:feature:messaging -.-> :core:testing
classDef android-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-application-compose fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef compose-desktop-application fill:#CAFFBF,stroke:#000,stroke-width:2px,color:#000;
classDef android-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef android-library fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-library-compose fill:#9BF6FF,stroke:#000,stroke-width:2px,color:#000;
classDef android-test fill:#A0C4FF,stroke:#000,stroke-width:2px,color:#000;
classDef jvm-library fill:#BDB2FF,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-feature fill:#FFD6A5,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library-compose fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef kmp-library fill:#FFC1CC,stroke:#000,stroke-width:2px,color:#000;
classDef unknown fill:#FFADAD,stroke:#000,stroke-width:2px,color:#000;