From 77ecde64884442afa1fb57222c3f41561d8e0aa9 Mon Sep 17 00:00:00 2001 From: James Rich Date: Wed, 29 Apr 2026 09:02:31 -0500 Subject: [PATCH] fix: disable preference footer buttons when there are no unsaved changes Fixes #5282 by properly passing the enabled parameter to the ElevatedButtons in PreferenceFooter. --- .../org/meshtastic/core/ui/component/PreferenceFooter.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/PreferenceFooter.kt b/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/PreferenceFooter.kt index 6bf0065bf7..624996aa60 100644 --- a/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/PreferenceFooter.kt +++ b/core/ui/src/commonMain/kotlin/org/meshtastic/core/ui/component/PreferenceFooter.kt @@ -52,6 +52,7 @@ fun PreferenceFooter( shapes = ButtonDefaults.shapesFor(mediumHeight), modifier = Modifier.height(mediumHeight).weight(1f), colors = ButtonDefaults.filledTonalButtonColors(), + enabled = enabled, onClick = onNegativeClicked, ) { Text(text = negativeText, style = ButtonDefaults.textStyleFor(mediumHeight)) @@ -63,7 +64,8 @@ fun PreferenceFooter( shapes = ButtonDefaults.shapesFor(mediumHeight), modifier = Modifier.height(mediumHeight).weight(1f), colors = ButtonDefaults.buttonColors(), - onClick = { if (enabled) onPositiveClicked() }, + enabled = enabled, + onClick = onPositiveClicked, ) { Text(text = positiveText, style = ButtonDefaults.textStyleFor(mediumHeight)) }