Andrew Gunnerson
d874921a69
File reopening was conflating ownership of file-like types with the fact that they support parallel reads and writes at arbitrary offsets. The Reopen trait has now been replaced with ReadAt and WriteAt traits, which are implemented for types that support parallel I/O. If a type compatible with the standard Read/Write/Seek traits is needed, a new UserPosFile type can act as the bridge by storing its own userspace file offset. For the opposite bridge, there's MutexFile, which implements ReadAt/WriteAt by using locks to make the operations sequential. This is only really used in the tests though. This eliminates the need for the PSeekFile and SharedCursor types. The standard File and Cursor types can be used instead, and if shared ownership is needed, Arc can be used. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
End-to-end tests
avbroot's output file is reproducible for a given input file. e2e.toml lists some profiles for generating mock OTA images with unique properties and the expected checksums before and after patching. These tests use pregenerated, hardcoded test keys for signing. These keys should NEVER be used for any other purpose.
For each profile listed in the config, the test process will:
- Generate a mock OTA based on the specification
- Verify tha original OTA checksum
- Run avbroot against the OTA using
--magisk(with a mock Magisk APK) - Verify the patched OTA checksum
- Extract the AVB-related partitions from the patched OTA
- Run avbroot against the OTA again using
--prepatched - Verify the patched OTA checksum again
The default profiles shipped with the project mimic how various stock OTAs for Pixel devices are built. The generated mock OTAs have valid signatures and data structures for all components, but without any actual data where possible. For example, most files in the ramdisks are empty files. To ensure the mock OTAs cannot be mistakenly installed on a real device, the OTA metadata lists a fake device name in the preconditions section.
Running the tests
To test against the profiles listed in e2e.toml, run:
# To test all profiles
cargo run --release -- test -a
# Or to test against specific profiles
cargo run --release -- test -p pixel_v4_gki -p pixel_v4_non_gki