mirror of
https://github.com/newliver666/apk-reverse.git
synced 2026-09-28 21:56:59 +02:00
inliver233
dd8057cfcb
CI went red on `1dc1d9b` in both jobs while the identical command passed locally, and the reason is
worth keeping: the checks depended on state that only exists on a developer's machine.
check_commands.py -- the gate's verdict depended on a gitignored directory
The previous commit's fix recognised a workbench script by matching its name against a walk of
`tools/`. That tree is gitignored, so a clean checkout has none of it: `dcc.py` matched locally and
skipped, and on CI nothing matched, it fell through to `missing-script`, and the gate reported
drift for three quoted lines. A check whose verdict changes with a directory CI does not have is
not a check. Two changes remove the dependency:
* `qualified_basenames()` collects every `.py` the *document itself* writes with a path, so a
bare name the document has already located elsewhere is a skip, computed from the text.
* `./dcc.py` is a declared upstream entry point, checked before the workbench-name test.
* a bare name after a `cd` that resolves nowhere is `after-cd-unresolved` -- unverifiable, which
is not the same claim as broken, and is now reported as such instead of as drift.
Verified by running the whole CI sequence against a tree with `tools/` hidden: five gates exit 0,
the suite passes. That experiment is the one that should have been run before the first push.
check_budget.py -- the measurement was installation-dependent
The gate measures the always-loaded body in tokens, preferring `tiktoken` and falling back to
`characters / N`. `N` had been guessed at 3.6 rather than calibrated, so a machine with tiktoken
saw ~11.1k tokens and passed while a machine without it saw ~14.2k and warned -- and CI's 3.11 job
is the one without it. `N` is now the measured 4.285 characters per token (47,629 chars -> 11,114
tokens on SKILL.md), both paths agree within one token, and `tests/unit/test_budget_measurement.py`
forces both paths and asserts they do not straddle the budget.
CI now installs `tiktoken` so the comparison exercises the real tokenizer instead of skipping.
Also: two `.py` files are formatted for consistency, and the reconstruction record documents the
CI-only failure, since "it passed on my machine" is the lesson rather than an aside.
Gates: check_repo 0 problem, check_refs 0 dangling / 0 warning, check_routing coherent,
check_budget 0 failure / 0 warning (both measurement paths), check_commands 154 checked / 0 drift,
pytest 617 passed on 3.14 and 609 on 3.11.
91 lines
3.3 KiB
YAML
91 lines
3.3 KiB
YAML
# CI for the apk-reverse skill repository.
|
|
#
|
|
# WHAT THIS RUNS
|
|
# * the repository's own structural gates: check_repo.py, check_refs.py,
|
|
# check_budget.py, check_routing.py, and check_commands.py when it is present
|
|
# * the pytest suite: tests/unit, tests/cli, tests/integration
|
|
#
|
|
# WHAT THIS DOES NOT RUN, ON PURPOSE
|
|
# * anything needing a device, adb, frida, a rooted phone, a network peer or a
|
|
# real sample APK. Those routes are recorded experiments in tests/benchmark.md
|
|
# and their status is documented in
|
|
# docs/tool-verification/EXTENSION-test-harness.md.
|
|
# * anything about agent behaviour. Whether a model routes, classifies or
|
|
# refuses correctly is not observable from a unit test; skills/apk-reverse/
|
|
# evals/evals.json is the skeleton for that, and it has never been executed.
|
|
# * the dex_patch_bytes regression hash. Its input lives in git-ignored
|
|
# tools/_work/bench/, so that test self-skips here with a printed reason
|
|
# rather than failing. Run it locally after downloading the sample.
|
|
#
|
|
# Coverage is therefore: static structure, documentation anchors, budget, command
|
|
# references, pure parsers, CLI contracts and no-device flows. Nothing more is
|
|
# claimed.
|
|
name: ci
|
|
|
|
on:
|
|
push:
|
|
pull_request:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
test:
|
|
name: python ${{ matrix.python-version }}
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
python-version: ["3.11", "3.13"]
|
|
|
|
env:
|
|
PYTHONIOENCODING: utf-8
|
|
PYTHONDONTWRITEBYTECODE: "1"
|
|
# The gates spawn sibling scripts and decode their output. On a Windows
|
|
# runner the default codec is the console's (GBK here), and one script's
|
|
# --help text is not GBK-decodable, which is reported as a crash in that
|
|
# script rather than as a harness decoding problem. Pinning UTF-8 removes
|
|
# the whole class of failure on every platform.
|
|
PYTHONUTF8: "1"
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- uses: actions/setup-python@v5
|
|
with:
|
|
python-version: ${{ matrix.python-version }}
|
|
|
|
- name: Install test dependencies
|
|
# `tiktoken` is optional for the suite but not for the budget gate's *measurement*: without
|
|
# it, `check_budget.py` falls back to characters/constant, and the two paths must agree.
|
|
# Installing it here means CI exercises the real tokenizer path, and the unit test comparing
|
|
# both paths runs instead of skipping.
|
|
run: python -m pip install --upgrade pip pytest tiktoken
|
|
|
|
- name: Structural gate - repository layout
|
|
run: python check_repo.py
|
|
|
|
- name: Structural gate - documentation anchors
|
|
run: python check_refs.py
|
|
|
|
- name: Structural gate - context budget
|
|
run: python check_budget.py
|
|
|
|
- name: Structural gate - documented commands (if present)
|
|
run: |
|
|
if [ -f check_commands.py ]; then
|
|
python check_commands.py
|
|
else
|
|
echo "check_commands.py is not present in this revision; skipping."
|
|
fi
|
|
|
|
- name: Structural gate - routing inventory matches the entry point
|
|
run: python check_routing.py
|
|
|
|
- name: Regression suite
|
|
run: python -m pytest -q
|
|
|
|
- name: Summarise skipped and expected-failure coverage
|
|
if: always()
|
|
run: python -m pytest -q -ra --no-header -p no:cacheprovider 2>&1 | tail -n 40
|