2 Commits

Author	SHA1	Message	Date
Ralph Chang	ff4639d153	fix: PR-2 memory plugin behavior improvements ... ## Task 5: Canonical exact dedupe - Already implemented in PR-1 with enforceLongTermLimits() - Source priority: explicit > manual > compaction - Same source: higher confidence wins ## Task 6: Structured negative guard - Add isNegatedMemoryRequest() for adjacency detection - "不要記住" / "don't remember" are now properly ignored - "not forget to remember" no longer false positive (not a directive) - Restrict patterns to line-start (^|\n) to avoid mid-sentence matches ## Task 7: Compaction quality gate - Add shouldAcceptWorkspaceMemoryCandidate() predicate - Reject low-quality candidates: git hashes, errors, stack traces - Reject temporary progress, code signatures, path-heavy facts - Only accept entries with >= 20 chars ## Pattern improvements - All patterns use matchAll() with proper g flag - Dedupe by canonical text in extractExplicitMemories() - Line-start anchor prevents "to remember" mid-sentence matches - Add more trigger patterns: save/add to memory, commit to memory Tests: 36 passing	2026-04-26 13:06:36 +08:00
Ralph Chang	1bba0511bb	fix: PR-1 memory plugin quality fixes ... ## Task 1: Fix exitCode undefined false positive - Add `typeof exitCode !== "number"` check in plugin.ts - Only extract errors when exitCode is explicitly non-zero - Prevent git-log/cat with "errors" text from creating false positives ## Task 2: Fix workspace memory XML truncation - Budget-aware line-by-line rendering - Always include closing </workspace_memory> tag - Return empty string when budget too small - Bonus: canonical exact deduplication with source priority ## Task 3: Remove "always" as trigger - Replace "always" with "going forward" in patterns - Add word boundary via `g` flag and matchAll loop - "from now on" still works as expected ## Task 4: Verification - 22 tests passing - typecheck passing Tests cover: - git log/cat with loose "errors" ignored - TS2345/TypeError strong signals captured - undefined exitCode: no create, no clear - exitCode 0: clears errors - exitCode non-zero: creates error - XML never truncated mid-tag - "always" not a trigger	2026-04-26 12:52:21 +08:00