From d2bed8efa417ef2916c99be7997a90022dcd9ab1 Mon Sep 17 00:00:00 2001 From: Alex Hancock Date: Mon, 3 Nov 2025 13:23:33 -0500 Subject: [PATCH] fix: do not build unsigned desktop app bundles on every PR in ci. add manual option. (#5550) --- .github/workflows/bundle-desktop-manual.yml | 19 +++++++++++++++++++ .github/workflows/bundle-desktop.yml | 1 + .github/workflows/ci.yml | 11 +---------- 3 files changed, 21 insertions(+), 10 deletions(-) create mode 100644 .github/workflows/bundle-desktop-manual.yml diff --git a/.github/workflows/bundle-desktop-manual.yml b/.github/workflows/bundle-desktop-manual.yml new file mode 100644 index 0000000000..f2943e8d66 --- /dev/null +++ b/.github/workflows/bundle-desktop-manual.yml @@ -0,0 +1,19 @@ +name: Manual Desktop Bundle (Unsigned) + +on: + workflow_dispatch: + inputs: + branch: + description: 'Branch name to bundle app from' + required: true + type: string + +jobs: + bundle-desktop-unsigned: + uses: ./.github/workflows/bundle-desktop.yml + permissions: + id-token: write + contents: read + with: + signing: false + ref: ${{ inputs.branch }} diff --git a/.github/workflows/bundle-desktop.yml b/.github/workflows/bundle-desktop.yml index 8995eb92c6..978242a621 100644 --- a/.github/workflows/bundle-desktop.yml +++ b/.github/workflows/bundle-desktop.yml @@ -3,6 +3,7 @@ # - release.yml # - canary.yml # - pr-comment-bundle-desktop.yml +# - bundle-desktop-manual.yml on: workflow_call: inputs: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 172b02d30e..4242db3718 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -131,13 +131,4 @@ jobs: run: source ../../bin/activate-hermit && npm run test:run working-directory: ui/desktop - # Faster Desktop App build for PRs only - bundle-desktop-unsigned: - uses: ./.github/workflows/bundle-desktop.yml - permissions: - id-token: write - contents: read - needs: changes - if: (github.event_name == 'pull_request' || github.event_name == 'merge_group') && (needs.changes.outputs.code == 'true' || github.event_name != 'pull_request') - with: - signing: false +